use pointer receiver

This commit is contained in:
Yasuhiro Matsumoto 2017-03-05 20:49:45 +09:00
parent fca908b496
commit a9d61d54c6
2 changed files with 6 additions and 5 deletions

View File

@ -3,14 +3,15 @@ package main
import (
"database/sql"
"fmt"
"github.com/mattn/go-sqlite3"
"log"
"github.com/mattn/go-sqlite3"
)
func main() {
sql.Register("sqlite3_with_extensions", &sqlite3.SQLiteDriver{
ConnectHook: func(conn *sqlite3.SQLiteConn) error {
return conn.CreateModule("github", githubModule{})
return conn.CreateModule("github", &githubModule{})
},
})
db, err := sql.Open("sqlite3_with_extensions", ":memory:")

View File

@ -19,7 +19,7 @@ type GithubRepo struct {
type githubModule struct {
}
func (m githubModule) Create(c *sqlite3.SQLiteConn, args []string) (sqlite3.VTab, error) {
func (m *githubModule) Create(c *sqlite3.SQLiteConn, args []string) (sqlite3.VTab, error) {
err := c.DeclareVTab(fmt.Sprintf(`
CREATE TABLE %s (
id INT,
@ -33,11 +33,11 @@ func (m githubModule) Create(c *sqlite3.SQLiteConn, args []string) (sqlite3.VTab
return &ghRepoTable{}, nil
}
func (m githubModule) Connect(c *sqlite3.SQLiteConn, args []string) (sqlite3.VTab, error) {
func (m *githubModule) Connect(c *sqlite3.SQLiteConn, args []string) (sqlite3.VTab, error) {
return m.Create(c, args)
}
func (m githubModule) DestroyModule() {}
func (m *githubModule) DestroyModule() {}
type ghRepoTable struct {
repos []GithubRepo