From a9d61d54c6d919d7f627743daa26e54687244566 Mon Sep 17 00:00:00 2001 From: Yasuhiro Matsumoto Date: Sun, 5 Mar 2017 20:49:45 +0900 Subject: [PATCH] use pointer receiver --- _example/vtable/main.go | 5 +++-- _example/vtable/vtable.go | 6 +++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/_example/vtable/main.go b/_example/vtable/main.go index 442069f..2f3b8a4 100644 --- a/_example/vtable/main.go +++ b/_example/vtable/main.go @@ -3,14 +3,15 @@ package main import ( "database/sql" "fmt" - "github.com/mattn/go-sqlite3" "log" + + "github.com/mattn/go-sqlite3" ) func main() { sql.Register("sqlite3_with_extensions", &sqlite3.SQLiteDriver{ ConnectHook: func(conn *sqlite3.SQLiteConn) error { - return conn.CreateModule("github", githubModule{}) + return conn.CreateModule("github", &githubModule{}) }, }) db, err := sql.Open("sqlite3_with_extensions", ":memory:") diff --git a/_example/vtable/vtable.go b/_example/vtable/vtable.go index 40b460f..eb80e2a 100644 --- a/_example/vtable/vtable.go +++ b/_example/vtable/vtable.go @@ -19,7 +19,7 @@ type GithubRepo struct { type githubModule struct { } -func (m githubModule) Create(c *sqlite3.SQLiteConn, args []string) (sqlite3.VTab, error) { +func (m *githubModule) Create(c *sqlite3.SQLiteConn, args []string) (sqlite3.VTab, error) { err := c.DeclareVTab(fmt.Sprintf(` CREATE TABLE %s ( id INT, @@ -33,11 +33,11 @@ func (m githubModule) Create(c *sqlite3.SQLiteConn, args []string) (sqlite3.VTab return &ghRepoTable{}, nil } -func (m githubModule) Connect(c *sqlite3.SQLiteConn, args []string) (sqlite3.VTab, error) { +func (m *githubModule) Connect(c *sqlite3.SQLiteConn, args []string) (sqlite3.VTab, error) { return m.Create(c, args) } -func (m githubModule) DestroyModule() {} +func (m *githubModule) DestroyModule() {} type ghRepoTable struct { repos []GithubRepo