Commit Graph

419 Commits

Author SHA1 Message Date
beorn7 32b10bd039 Initial refactoring. WIP. 2016-02-25 12:35:49 +01:00
Björn Rabenstein 67994f1771 Merge pull request #186 from stapelberg/slash
Strip trailing / from push URL.
2015-11-27 19:24:33 +01:00
Michael Stapelberg c1370d07ca Strip trailing / from push URL.
This circumvents the following problem:
• The prometheus client library appends “/metrics/…” to the pushURL.
• When pushURL ends in a trailing slash, the URL becomes e.g.
  http://pushgateway.example.com:9091//metrics/…
• The pushgateway will reply with an HTTP 307 status code
  (temporary redirect).
• While Go’s net/http client follows redirects by default, it will only
  follow HTTP 302 (Found) and HTTP 303 (See Other) redirects for PUT and
  POST requests, which the prometheus client library uses.

Hence, when calling e.g.:

    prometheus.Push("foo", "bar", "http://pushgateway.example.com:9091/")

…your metrics would not actually get pushed successfully, but rather
you’d see the error message:

    2015/11/26 10:59:49 main.go:209: unexpected status code 307 while pushing to http://push...
2015-11-26 19:16:53 +01:00
Fabian Reinartz 8ab2490e0f Merge pull request #185 from stapelberg/patch-2
fix typo: s/addr/url/
2015-11-25 10:54:27 +01:00
Michael Stapelberg 1a09b46c2e fix typo: s/addr/url/ 2015-11-25 08:46:01 +01:00
Björn Rabenstein 275368fd9e Merge pull request #184 from realzeitmedia/allfnv
use local fnv hash everywhere
2015-11-12 14:29:20 +01:00
Harmen 5d4fdca1a5 use local fnv hash everywhere 2015-11-12 14:07:23 +01:00
Björn Rabenstein cfd904193d Merge pull request #180 from dnesting/dnesting-sort-metrics
Make metric sort stable and sort by timestamp
2015-11-10 22:31:22 +01:00
David Nesting b0bd184e74 Simplify metricSorter timestamp comparison and improve comment 2015-11-10 09:37:58 -05:00
Björn Rabenstein cf3f724ef6 Merge pull request #181 from realzeitmedia/locking
Less locking for metric vectors.
2015-11-10 14:58:49 +01:00
David Nesting 544f65f7fc metricSorter stops relying on time.Now and respects nil timestamps 2015-11-09 17:14:07 -05:00
David Nesting 5fb1b89678 Make metric sort stable and sort by timestamp 2015-11-09 16:55:26 -05:00
Robert Vollmert 8c96b12588 try getting metrics with a read lock, first 2015-11-09 15:16:26 +01:00
Robert Vollmert 5183814775 ok not has 2015-11-09 15:16:26 +01:00
Robert Vollmert 1312da4c0c Inline hash/fnv. 2015-11-09 15:16:26 +01:00
Robert Vollmert 39a26f2e35 concurrency benchmark 2015-11-09 14:34:37 +01:00
Julius Volz 449ccefff1 Update Julius's email address in AUTHORS.md 2015-10-26 02:27:06 +01:00
Björn Rabenstein e51041b3fa Merge pull request #146 from KevinPike/memstats
memstats collection
2015-10-08 16:32:47 +02:00
Kevin Pike db58b27d95 heap bytes released total 2015-10-07 11:21:49 -07:00
Kevin Pike 1eb8d032a8 use counter for heap released bytes 2015-10-06 08:18:17 -07:00
Kevin Pike 9a6b9d3ddf fix descriptions 2015-10-05 09:27:28 -07:00
Kevin Pike 6c7a1db6bf don't reuse memstats 2015-10-05 07:37:59 -07:00
Kevin Pike 8a031ee219 unembed memstats collector 2015-10-02 18:10:36 -07:00
Fabian Reinartz b6cad5edaf Merge pull request #178 from prometheus/ctx
Use ctxhttp package for cancelable requests
2015-10-02 13:48:55 +02:00
Fabian Reinartz f664cd7ea5 Use ctxhttp package for cancelable requests 2015-10-02 12:04:48 +02:00
Björn Rabenstein 3b78d7a77f Merge pull request #175 from prometheus/documentation
Update README.md
2015-09-18 15:37:02 +02:00
beorn7 75109d1c90 Update README.md 2015-09-18 14:41:53 +02:00
Björn Rabenstein dcd7417a58 Merge pull request #174 from prometheus/move-to-common
Move to common
2015-09-17 14:40:12 +02:00
Björn Rabenstein f3be6f9400 Merge pull request #173 from prometheus/remove-text-model-extraction
Remove the text, model, and extraction packages.
2015-09-17 14:38:51 +02:00
Björn Rabenstein 13985ab413 Merge pull request #172 from prometheus/move-to-common
Move from client_golang/text to common/expfmt
2015-09-17 14:37:51 +02:00
beorn7 cf0a294118 Remove the text, model, and extraction packages
They have all been moved to common/expfmt. All uses of it have been
migrated.
2015-09-17 14:22:05 +02:00
beorn7 90ddfa1c1e Move from client_golang/text to common/expfmt 2015-09-17 13:06:43 +02:00
Björn Rabenstein 29939ec908 Merge pull request #160 from ardan-bkennedy/master
Update histogram_test.go
2015-08-28 12:34:13 +02:00
Fabian Reinartz 8c899cd820 Merge pull request #167 from prometheus/nomodel
Remove client_golang/model als direct dependency
2015-08-23 15:13:01 +02:00
Fabian Reinartz f2de0f589a Remove client_golang/model als direct dependency 2015-08-23 13:51:32 +02:00
Fabian Reinartz 223315ae31 Merge pull request #165 from prometheus/api
Add initial HTTP API v1 package
2015-08-19 19:06:35 +02:00
Fabian Reinartz 2aae630ba8 Add initial HTTP API v1 package 2015-08-19 19:00:22 +02:00
Fabian Reinartz 8f8d39e0fd Merge pull request #164 from prometheus/godepp
Remove vendoring
2015-08-19 16:39:11 +02:00
Fabian Reinartz 7ca3eb1775 Set sudo=false for travis CI 2015-08-19 16:13:11 +02:00
Fabian Reinartz 71b95dc48e Remove vendoring 2015-08-19 16:13:11 +02:00
Julius Volz 4a339dcbca Fix minor typos in comment. 2015-08-17 12:58:16 +02:00
Fabian Reinartz bbd006bc5e Merge pull request #162 from prometheus/fabxc/runtime-test
Turn allocation test into a benchmark.
2015-08-13 23:05:05 +02:00
Fabian Reinartz e6310b190e Turn allocation test into a benchmark. 2015-08-13 19:09:23 +02:00
Fabian Reinartz 762de31e01 Merge pull request #161 from prometheus/fabxc/runtime-test
Remove runtime-dependent test.
2015-08-13 18:49:01 +02:00
Fabian Reinartz 89773a6194 Remove runtime-dependent test.
Success of this test was runtime dependent and did not validate
the implementation logic itself.
2015-08-13 18:08:36 +02:00
William Kennedy f075821cbb Update histogram_test.go
These tests are always timing out in our Jenkins CI environment. We have moved our timeout to 2 minutes. I have added a check for the short flag so other can skip these tests as we are until this can be identified.
2015-08-12 17:51:21 -04:00
Fabian Reinartz dd33f764bd Merge pull request #158 from ardan-bkennedy/patch-1
Update go_collector_test.go
2015-08-12 22:22:03 +02:00
Fabian Reinartz fa8495136c Merge pull request #157 from prometheus/reserve-tmp
Reserve a label prefix for use for temporary relabeling.
2015-08-12 21:58:35 +02:00
William Kennedy a794f77b54 Update go_collector_test.go
We are running into a timeout with TestHistogramConcurrency on our Jenkins box. I noticed in the stack trace for the timeout this block.

goroutine 2348 [chan send]:
github.comcast.com/ventris/kober/vnd/github.com/prometheus/client_golang/prometheus.(*goCollector).Collect(0xc20801e8e0, 0xc20800a7e0)
	/var/lib/jenkins/jobs/Kober/workspace/src/github.comcast.com/ventris/kober/vnd/github.com/prometheus/client_golang/prometheus/go_collector.go:49 +0x6dd
github.comcast.com/ventris/kober/vnd/github.com/prometheus/client_golang/prometheus.func·028()
	/var/lib/jenkins/jobs/Kober/workspace/src/github.comcast.com/ventris/kober/vnd/github.com/prometheus/client_golang/prometheus/go_collector_test.go:27 +0x11a
created by github.comcast.com/ventris/kober/vnd/github.com/prometheus/client_golang/prometheus.TestGoCollector
	/var/lib/jenkins/jobs/Kober/workspace/src/github.comcast.com/ventris/kober/vnd/github.com/prometheus/client_golang/prometheus/go_collector_test.go:28 +0x35e

This suggested that even though the TestGoCollector test was finished, a goroutine was still hanging around. I traced it back to the call to c.Collect always sending twice of the provided channel. This change receives that second value and allows the goroutine to finish with the test.

Still can't figure out why TestHistogramConcurrency is timing out after 2 minutes :(
2015-08-12 15:23:41 -04:00
Brian Brazil babaf53025 Reserve a label prefix for use for temporary relabeling. 2015-08-12 10:34:26 +01:00