59c00e3e9c
Fix data-race in metric without code and method but with `WithLabelFromCtx` ( #1318 )
...
This commit fixes a data race that exists when the metric used in any
`promhttp` middleware doesn't collect the `code` and `method` but uses
`WithLabelFromCtx` to collect values from context.
The problem happens because when no `code` and `method` tags are
collected, the `labels` function returns a pre-initialized map
`emptyLabels` for every request.
When one or multipe `WithLabelFromCtx` options are configured, the
returned map from the `labels` function call is used to collect the
metrics from context which creates a multi-write data race.
Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
2023-08-01 17:11:17 +01:00
7f2db5f1ed
Update common Prometheus files ( #1302 )
...
Signed-off-by: prombot <prometheus-team@googlegroups.com>
2023-07-26 12:54:03 +01:00
6e3b962584
Bump github.com/prometheus/procfs from 0.10.1 to 0.11.0 ( #1305 )
...
Bumps [github.com/prometheus/procfs](https://github.com/prometheus/procfs ) from 0.10.1 to 0.11.0.
- [Release notes](https://github.com/prometheus/procfs/releases )
- [Commits](https://github.com/prometheus/procfs/compare/v0.10.1...v0.11.0 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/procfs
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-26 12:53:49 +01:00
90b169a60d
Merge pull request #1314 from prometheus/beorn7/histogram
...
histogram: Enable detection of a native histogram without observations
2023-07-26 13:53:11 +02:00
98025d8797
Bump google.golang.org/grpc from 1.45.0 to 1.53.0 in /tutorial/whatsup ( #1307 )
...
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go ) from 1.45.0 to 1.53.0.
- [Release notes](https://github.com/grpc/grpc-go/releases )
- [Commits](https://github.com/grpc/grpc-go/compare/v1.45.0...v1.53.0 )
---
updated-dependencies:
- dependency-name: google.golang.org/grpc
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-26 12:46:42 +01:00
3b6fb7aa3f
Bump golang.org/x/sys from 0.8.0 to 0.9.0 ( #1306 )
...
Bumps [golang.org/x/sys](https://github.com/golang/sys ) from 0.8.0 to 0.9.0.
- [Commits](https://github.com/golang/sys/compare/v0.8.0...v0.9.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/sys
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-26 12:46:32 +01:00
3d82c94432
histogram: Add a no-op span for an otherwise empty histogram
...
Fixes #1127 .
If a native histogram has no observations and a zero threshold of
zero, then it is indistinguishable from a classic histogram. To give
scrapers a hint that it is indeed a native histogram, we add a no-op
span.
This needs follow-up PRs in prometheus/prometheus and
prometheus/client_model.
Signed-off-by: beorn7 <beorn@grafana.com>
2023-07-20 17:34:00 +02:00
f9db3821a8
histograms: Small code comment and code formatting improvements
...
Signed-off-by: beorn7 <beorn@grafana.com>
2023-07-20 16:13:28 +02:00
644c80d136
Do not allocate memory when there's no constraints ( #1296 )
...
Signed-off-by: Quentin Devos <4972091+Okhoshi@users.noreply.github.com>
2023-06-27 12:21:36 +01:00
553eb4c7a8
ci: define minimal permissions to github workflows ( #1295 )
...
Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>
2023-06-19 09:53:04 +01:00
f6bb79e03d
Update common Prometheus files ( #1297 )
...
Signed-off-by: prombot <prometheus-team@googlegroups.com>
2023-06-19 09:12:39 +01:00
c3fa5a74f1
Merge pull request #1293 from prometheus/release-1.16
...
Merge v1.16.0 to main
2023-06-15 12:57:21 +02:00
3583c1e1d0
Cut v1.16.0 ( #1292 )
...
Signed-off-by: bwplotka <bwplotka@gmail.com>
2023-06-15 11:46:32 +01:00
2feda42e44
Fixed README & CHANGELOG; Added fmt makefile command (+bingo) for easier contributions. ( #1289 )
...
* Fixed README; Added fmt command for easier contributions.
Signed-off-by: bwplotka <bwplotka@gmail.com>
* Updated golint.
Signed-off-by: bwplotka <bwplotka@gmail.com>
* Update Makefile
Co-authored-by: Kemal Akkoyun <kakkoyun@users.noreply.github.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
---------
Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Co-authored-by: Kemal Akkoyun <kakkoyun@users.noreply.github.com>
2023-06-13 14:54:49 +01:00
5b9cf9c6a8
Merge pull request #1290 from prometheus/fix-nh-docstring-refs
...
Fix docstring references to renamed native histogram fields / functions.
2023-06-13 15:54:22 +02:00
1b19d5f458
Fix docstring references to renamed native histogram fields / functions.
...
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2023-06-13 10:36:40 +02:00
7352ab7f80
Moving fully to GH actions. ( #1288 )
...
Signed-off-by: bwplotka <bwplotka@gmail.com>
2023-06-08 12:44:53 +01:00
e4ff34d23e
Improve metricUnits runtime ( #1286 )
...
We tested this function runtime in both cases using "testing",
and the runtime for this pr is much shorter.
Signed-off-by: alitman <alitman@redhat.com>
2023-06-08 11:35:32 +01:00
781ea28024
added circleci as gh action YAML ( #1281 )
...
* added circleci as gh action YAML
Signed-off-by: krishnaduttPanchagnula <krishnadutt123@gmail.com>
* merged all changes into one
Signed-off-by: krishnaduttPanchagnula <krishnadutt123@gmail.com>
---------
Signed-off-by: krishnaduttPanchagnula <krishnadutt123@gmail.com>
2023-06-08 10:51:42 +01:00
a09a1d34cb
Reduce constrainLabels allocations ( #1272 )
...
* Add bench
Signed-off-by: Bulat Khasanov <afti@yandex.ru>
* Reduce constrainLabels allocations
Signed-off-by: Bulat Khasanov <afti@yandex.ru>
---------
Signed-off-by: Bulat Khasanov <afti@yandex.ru>
2023-06-07 08:39:02 +01:00
8840afcfc2
Bump github.com/prometheus/procfs from 0.9.0 to 0.10.1 ( #1283 )
...
Bumps [github.com/prometheus/procfs](https://github.com/prometheus/procfs ) from 0.9.0 to 0.10.1.
- [Release notes](https://github.com/prometheus/procfs/releases )
- [Commits](https://github.com/prometheus/procfs/compare/v0.9.0...v0.10.1 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/procfs
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-07 08:12:43 +01:00
5e78d5f66b
Merge pull request #1279 from prometheus/beorn7/histogram
...
Fix bug in bucket key calculation
2023-05-29 00:09:18 +02:00
b8cb86a865
add process start time header to client_golang prometheus ( #1278 )
...
* add process start time header to client_golang prometheus
Signed-off-by: Han Kang <hankang@google.com>
* Apply suggestions from code review
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Han Kang <hankang@google.com>
* fix up changes due to incorporation of feedback
* fix lint issues
---------
Signed-off-by: Han Kang <hankang@google.com>
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
2023-05-26 12:58:36 +01:00
77e97da564
histogram: Fix bug in bucket key calculation
...
The current code doesn't work fork negative schemas if the observed
value should go into a bucket with a non-positive key.
Signed-off-by: beorn7 <beorn@grafana.com>
2023-05-25 19:03:43 +02:00
30948120dc
histogram: expose bug in bucket key calculation
...
The current code doesn't work fork negative schemas if the observed
value should go into a bucket with a non-positive key.
Signed-off-by: beorn7 <beorn@grafana.com>
2023-05-25 19:02:28 +02:00
8b1a836e7d
GitHub Workflows security hardening ( #1180 )
...
* build: harden golangci-lint.yml permissions
Signed-off-by: Alex <aleksandrosansan@gmail.com>
* Update golangci-lint.yml
Signed-off-by: Alex <aleksandrosansan@gmail.com>
---------
Signed-off-by: Alex <aleksandrosansan@gmail.com>
2023-05-17 11:39:40 +02:00
f51d823bda
Merge pull request #1267 from prometheus/release-1.15
...
Merge release 1.15.1 to main
2023-05-17 11:37:25 +02:00
4bbb297e54
Cut 1.15.1 ( #1266 )
...
Signed-off-by: bwplotka <bwplotka@gmail.com>
2023-05-03 10:48:04 +01:00
297fea317b
fix undefined execution order in return statements ( #1260 )
...
Signed-off-by: Piotr Lewandowski <lewandowski323@gmail.com>
2023-05-03 10:25:51 +01:00
0f060a0277
Add detection for WSL address ( #1257 )
...
Signed-off-by: Evers, Martijn <mevers@gk-software.com>
2023-05-03 09:52:46 +01:00
2eaffbdb02
Merge pull request #1253 from prometheus/fixpro
...
Fixed promhttp Instrument* handlers.
2023-05-03 10:50:04 +02:00
8a51463540
Cleanup proto use in tests ( #1264 )
...
Switch tests over to new proto libary, eliminating the direct dependency
on the old proto library. Note the indirect requirement is still needed
due to upstream use by the client_model package.
Related: https://github.com/prometheus/client_golang/issues/1175
Signed-off-by: SuperQ <superq@gmail.com>
2023-05-03 09:46:41 +01:00
0ae00134d8
Bump golang.org/x/sys from 0.6.0 to 0.7.0 ( #1265 )
...
Bumps [golang.org/x/sys](https://github.com/golang/sys ) from 0.6.0 to 0.7.0.
- [Release notes](https://github.com/golang/sys/releases )
- [Commits](https://github.com/golang/sys/compare/v0.6.0...v0.7.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/sys
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-05-03 09:45:35 +01:00
b8fdd239b2
Added clarification.
...
Signed-off-by: bwplotka <bwplotka@gmail.com>
2023-05-03 09:41:34 +01:00
2ea234eef0
Revert "Remove unnecessary check if label is nil in observeWithExemplar ( #1235 )"
...
This reverts commit 3ce88f33d1
2023-05-03 09:41:26 +01:00
671a2f0568
Fixed tutorial. ( #1256 )
...
Signed-off-by: bwplotka <bwplotka@gmail.com>
2023-04-21 14:23:45 +01:00
90eb83b690
Added interactive tutorial [kubeCon] ( #1255 )
...
Signed-off-by: bwplotka <bwplotka@gmail.com>
2023-04-21 13:16:14 +01:00
c36c6abb8d
[collectors]: fix typo in test assertion ( #1153 )
...
Signed-off-by: Max 👨🏽💻 Coplan Max.Coplan@walmart.com
Signed-off-by: Max 👨🏽💻 Coplan Max.Coplan@walmart.com
Co-authored-by: Max 👨🏽💻 Coplan <Max.Coplan@walmart.com>
2023-04-17 21:35:49 +01:00
0392dffd0e
Switch to POST for LabelNames, Series, and QueryExemplars to DoGetFallback ( #1252 )
...
The upstream prometheus HTTP API supports POSTS for these methods (the
same as Query and QueryRange). Similar to the original issue
(https://github.com/prometheus/client_golang/issues/428 ) we can hit 414
errors with these other APIs. This change simply duplicates the logic to
these other endpoints
Related to: https://github.com/jacksontj/promxy/issues/588
Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>
2023-04-16 13:41:34 +01:00
e3b6de8c3d
Merge pull request #1250 from prometheus/release-1.15
2023-04-13 14:15:17 +02:00
d7896d4bd0
Cut v1.15.0 ( #1249 )
...
Signed-off-by: bwplotka <bwplotka@gmail.com>
2023-04-13 12:51:09 +02:00
bba12b5514
Bump github.com/prometheus/common from 0.41.0 to 0.42.0 ( #1244 )
...
Bumps [github.com/prometheus/common](https://github.com/prometheus/common ) from 0.41.0 to 0.42.0.
- [Release notes](https://github.com/prometheus/common/releases )
- [Commits](https://github.com/prometheus/common/compare/v0.41.0...v0.42.0 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/common
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-13 10:57:59 +01:00
9015fcfc2c
Bump github.com/golang/protobuf from 1.5.2 to 1.5.3 ( #1245 )
...
Bumps [github.com/golang/protobuf](https://github.com/golang/protobuf ) from 1.5.2 to 1.5.3.
- [Release notes](https://github.com/golang/protobuf/releases )
- [Commits](https://github.com/golang/protobuf/compare/v1.5.2...v1.5.3 )
---
updated-dependencies:
- dependency-name: github.com/golang/protobuf
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-13 10:57:49 +01:00
1bb8cf8306
Bump golang.org/x/sys from 0.5.0 to 0.6.0 ( #1246 )
...
Bumps [golang.org/x/sys](https://github.com/golang/sys ) from 0.5.0 to 0.6.0.
- [Release notes](https://github.com/golang/sys/releases )
- [Commits](https://github.com/golang/sys/compare/v0.5.0...v0.6.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/sys
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-13 10:41:40 +01:00
ff7efedd43
Merge pull request #1243 from prometheus/dependabot/go_modules/google.golang.org/protobuf-1.30.0
...
Bump google.golang.org/protobuf from 1.28.1 to 1.30.0
2023-04-01 12:21:01 +02:00
852a282f10
Bump google.golang.org/protobuf from 1.28.1 to 1.30.0
...
Bumps google.golang.org/protobuf from 1.28.1 to 1.30.0.
---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-04-01 09:58:51 +00:00
63a3955992
Merge pull request #1238 from jacksontj/issue_621
...
Only set start/end if time is not Zero
2023-03-22 14:54:16 +01:00
eb339714f5
Filter expected metrics as well in CollectAndCompare ( #1143 )
...
* Filter expected metrics as well in CollectAndCompare
Signed-off-by: Daria Danilenko <daria.danilenko@fluxninja.com>
* Add testcase for multiple expected metrics
Signed-off-by: Daria Danilenko <daria.danilenko@fluxninja.com>
* Change test values for filtering multiple expected metrics
Signed-off-by: Daria Danilenko <daria.danilenko@fluxninja.com>
---------
Signed-off-by: Daria Danilenko <daria.danilenko@fluxninja.com>
2023-03-22 10:45:45 +00:00
5c7821d84a
Update common Prometheus files ( #1237 )
...
Signed-off-by: prombot <prometheus-team@googlegroups.com>
2023-03-22 09:46:56 +01:00
603786389c
Only set start/end if time is not Zero
...
This is an updated PR of #615 -- based on discussion in #621
Fixes #621
Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>
2023-03-21 13:10:58 -07:00
Tiago Silva