Commit Graph

1756 Commits

Author SHA1 Message Date
bwplotka 584a7ce3d9 Revert "testutil compareMetricFamilies: make less error-prone (#1424)"
This reverts commit c7c7509669.
2024-10-14 21:52:04 +01:00
George Krajcsovits 05fcde9fe4
Merge pull request #1623 from krajorama/data-race-in-histogram-write
native histogram: Fix race between Write and addExemplar
2024-09-07 07:57:39 +02:00
György Krajcsovits 209f4c041e Add changelog
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-09-06 12:41:51 +02:00
György Krajcsovits 1e398ccb12 native histogram: Fix race between Write and addExemplar
Follow-up to 1608

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-09-06 11:01:04 +02:00
Arthur Silva Sens ef2f87ea98
Merge pull request #1620 from prometheus/arthursens/prepare-1.20.3
Add changelog entry for 1.20.3
2024-09-05 09:29:29 -03:00
Arthur Silva Sens 937ac63d3d
Add changelog entry for 1.20.3
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
2024-09-05 09:23:41 -03:00
George Krajcsovits 6e9914db5a
Merge pull request #1608 from krajorama/index-out-of-range-native-histogram-exemplar
bugfix: native histogram: exemplars index out of range
2024-09-04 21:21:43 +02:00
György Krajcsovits d6b8c8925b Update comments with more explanations
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-09-04 21:10:22 +02:00
György Krajcsovits 504566f07c Use simplified solution from #1609 for the data race
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-09-04 21:10:22 +02:00
György Krajcsovits dc8e9a4d8a fix: native histogram: Simplify and fix addExemplar
mdIdx was redundant when len(exemplars)>1, so got rid of it, rIdx
is enough.

Don't compare timestamp of incoming exemplar to timestamp of
minimal distance exemplar. Most of the time the incoming exemplar
will be newer. And if not, the previous code just replaced an
exemplar one index after the minimal distance exemplar. Which had
an index out of range bug, plus is essentially random.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-09-04 21:10:22 +02:00
György Krajcsovits dc819ceb1b Use a trivial solution to #1605
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-09-04 21:10:22 +02:00
György Krajcsovits e061dfae88 native histogram: use exemplars in concurrency test
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-09-04 21:10:22 +02:00
Arthur Silva Sens 67121dc55a
Merge pull request #1596 from mrueg/fix-uncompressed-content-header
fix: Unset Content-Encoding header when uncompressed
2024-08-23 16:09:01 -03:00
Manuel Rüger 187acd4ca1 Cut 1.20.2
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
2024-08-23 18:55:43 +02:00
Manuel Rüger f7f8f3a1e2 fix: Unset Content-Encoding header when uncompressed
Fixes: #1595
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
2024-08-23 18:53:42 +02:00
Arthur Silva Sens 2254d6c308
Merge pull request #1587 from prometheus/fix-processcollector
Fix processcollector
2024-08-20 08:43:51 -03:00
bwplotka 4a15d05846 Cut 1.20.1
Signed-off-by: bwplotka <bwplotka@gmail.com>
2024-08-20 11:46:16 +01:00
bwplotka f2dd7b35fd Use pedantic registry in other places too, to double check.
Signed-off-by: bwplotka <bwplotka@gmail.com>
2024-08-20 11:44:35 +01:00
Arthur Silva Sens 261fe84cd4 bugfix: Pass network metrics to processCollector's Describe() function
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
2024-08-20 11:44:35 +01:00
Arthur Silva Sens 5bf3341b66 Use NewPedanticRegistry in Process' Collector tests
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
2024-08-20 11:44:35 +01:00
Bartlomiej Plotka 73b811c54a
Cut 1.20.0 release. (#1580)
* Cut 1.20.0.

Signed-off-by: bwplotka <bwplotka@gmail.com>

* Update CHANGELOG.md

Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>

---------

Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com>
2024-08-14 15:14:14 +01:00
Bartlomiej Plotka 7ce508988a
gocollector: Attach original runtime/metrics metric name to help. (#1578)
This helps in filtering capabilities and generally in discovery/knowledge sharing.

Signed-off-by: bwplotka <bwplotka@gmail.com>
2024-08-14 12:25:55 +00:00
Bartlomiej Plotka 062300ede9
Remove go_memstat_lookups_total; added runtime/metrics calculation to memstat metric's help. (#1577)
* Removeed go_memstat_lookups_total which was always set to 0; added runtime/metrics info to memstat metric helps.

I know we ideally should not remove any metric from default list, but
this one is always zero, so let's save everyone's money.

Signed-off-by: bwplotka <bwplotka@gmail.com>

* Update prometheus/go_collector.go

Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>

---------

Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com>
2024-08-14 12:11:51 +00:00
PrometheusBot aa3c00d2ee
Update common Prometheus files (#1576)
Signed-off-by: prombot <prometheus-team@googlegroups.com>
2024-08-11 18:16:49 +01:00
Arianna Vespri 3ad272204b
Add default Go runtime metrics for /gc/gogc:percent, /gc/gomemlimit:bytes, /sched/gomaxprocs:threads (#1559)
* Add go_gomaxprocs, go_gogc_percent and go_gomemlimit to the default Go runtime metrics

Signed-off-by: Arianna Vespri <arianna.vespri@yahoo.it>

* Move newly added metrics out of base metrics and into goCollector

Signed-off-by: Arianna Vespri <arianna.vespri@yahoo.it>

* Rethink struct for newly added metrics, adapt and add tests

Signed-off-by: Arianna Vespri <arianna.vespri@yahoo.it>

* Simplify new metrics reading

Signed-off-by: Arianna Vespri <arianna.vespri@yahoo.it>

* Correct loop, add debugging lines

Signed-off-by: Arianna Vespri <arianna.vespri@yahoo.it>

* Make goRuntimeEnvVarsMetrics function Go version dependent

Signed-off-by: Arianna Vespri <arianna.vespri@yahoo.it>

* Fix go mod

Signed-off-by: Arianna Vespri <arianna.vespri@yahoo.it>

* Remove debuggin line

Signed-off-by: Arianna Vespri <arianna.vespri@yahoo.it>

* Move default runtime metrics into the runtime metrics flow, change tests accordingly

Signed-off-by: Arianna Vespri <arianna.vespri@yahoo.it>

* Go version expected default runtime metrics map for tests

Signed-off-by: Arianna Vespri <arianna.vespri@yahoo.it>

* 1.21 update.

Signed-off-by: bwplotka <bwplotka@gmail.com>

* Addressed comments on Arianna's PR.

Signed-off-by: bwplotka <bwplotka@gmail.com>

* Use default GoCollector func in test

Signed-off-by: Arianna Vespri <arianna.vespri@yahoo.it>

---------

Signed-off-by: Arianna Vespri <arianna.vespri@yahoo.it>
Signed-off-by: bwplotka <bwplotka@gmail.com>
Co-authored-by: bwplotka <bwplotka@gmail.com>
2024-08-09 20:27:25 +01:00
PrometheusBot 071572721c
Update common Prometheus files (#1573)
Signed-off-by: prombot <prometheus-team@googlegroups.com>
2024-08-09 11:29:19 +01:00
Marcos Nils 3634bd9bda
ci: daggerize test and lint pipelines (#1534)
* ci: daggerize go.yml pipeline

Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>

* ci: upgrade dagger to v0.12 and apply comment fixes

Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>

* rename dagger function to make it more descriptive

Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>

---------

Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>
Co-authored-by: Kemal Akkoyun <kakkoyun@users.noreply.github.com>
2024-08-07 14:49:16 +02:00
Arthur Silva Sens 28b5e6e136
Merge pull request #1572 from prometheus/repo_sync
Synchronize common files from prometheus/prometheus
2024-08-06 15:34:54 -03:00
prombot 8e18075c9e Update common Prometheus files
Signed-off-by: prombot <prometheus-team@googlegroups.com>
2024-08-01 17:47:58 +00:00
github-actions[bot] 46f77a97fa
Merge pull request #1571 from prometheus/dependabot/github_actions/github-actions-1edf403647
build(deps): bump the github-actions group with 3 updates
2024-08-01 09:57:16 +00:00
github-actions[bot] f751d1363b
Merge pull request #1570 from prometheus/dependabot/go_modules/golang.org/x/sys-0.22.0
build(deps): bump golang.org/x/sys from 0.21.0 to 0.22.0
2024-08-01 09:56:23 +00:00
dependabot[bot] 7983708ebd
build(deps): bump the github-actions group with 3 updates
Bumps the github-actions group with 3 updates: [github/codeql-action](https://github.com/github/codeql-action), [actions/setup-go](https://github.com/actions/setup-go) and [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action).


Updates `github/codeql-action` from 3.25.13 to 3.25.15
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](2d790406f5...afb54ba388)

Updates `actions/setup-go` from 5.0.1 to 5.0.2
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/v5.0.1...v5.0.2)

Updates `golangci/golangci-lint-action` from 6.0.1 to 6.1.0
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](a4f60bb28d...aaa42aa062)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-08-01 09:53:37 +00:00
dependabot[bot] 2e98f83366
build(deps): bump golang.org/x/sys from 0.21.0 to 0.22.0
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.21.0 to 0.22.0.
- [Commits](https://github.com/golang/sys/compare/v0.21.0...v0.22.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-08-01 09:52:29 +00:00
Bartlomiej Plotka 0ce6d719bc
go collector: add default metrics acceptance tests; adding more context to HELP (#1568)
* go collector: add default metrics acceptance tests; adding more context to HELP

The context and details for help were possible thanks to @vesari research, thanks for that!

Signed-off-by: bwplotka <bwplotka@gmail.com>

* Update prometheus/go_collector.go

Co-authored-by: Arianna Vespri <36129782+vesari@users.noreply.github.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>

---------

Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Co-authored-by: Arianna Vespri <36129782+vesari@users.noreply.github.com>
2024-08-01 09:24:31 +01:00
Bartlomiej Plotka 697372d81e
tutorials: Renamed for consistency + fixed tutorial code. (#1569) 2024-07-31 14:06:25 +02:00
PrometheusBot 0581180d24
Update common Prometheus files (#1567)
Signed-off-by: prombot <prometheus-team@googlegroups.com>
2024-07-30 07:49:57 +01:00
Bartlomiej Plotka d7f83d1629
deps: Updated to prometheus/common to 0.55 (#1566)
Signed-off-by: bwplotka <bwplotka@gmail.com>
2024-07-29 15:05:07 +01:00
github-actions[bot] cbfe44a2f2
Merge pull request #1551 from prometheus/dependabot/go_modules/google.golang.org/protobuf-1.34.2
build(deps): bump google.golang.org/protobuf from 1.34.1 to 1.34.2
2024-07-29 10:31:27 +00:00
Bartlomiej Plotka f8718b0c47
Merge branch 'main' into dependabot/go_modules/google.golang.org/protobuf-1.34.2 2024-07-29 12:27:38 +02:00
PrometheusBot 6f511c3f23
Update common Prometheus files (#1563)
Signed-off-by: prombot <prometheus-team@googlegroups.com>
2024-07-29 11:27:25 +01:00
github-actions[bot] 9f203a098e
Merge pull request #1565 from prometheus/dependabot/github_actions/github-actions-fde7c240f8
build(deps): bump the github-actions group across 1 directory with 3 updates
2024-07-19 16:17:11 +00:00
dependabot[bot] 3d81bddb0f
build(deps): bump the github-actions group across 1 directory with 3 updates
Bumps the github-actions group with 3 updates in the / directory: [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata), [github/codeql-action](https://github.com/github/codeql-action) and [actions/setup-go](https://github.com/actions/setup-go).


Updates `dependabot/fetch-metadata` from 2.1.0 to 2.2.0
- [Release notes](https://github.com/dependabot/fetch-metadata/releases)
- [Commits](5e5f99653a...dbb049abf0)

Updates `github/codeql-action` from 3.25.3 to 3.25.13
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](d39d31e687...2d790406f5)

Updates `actions/setup-go` from 5.0.0 to 5.0.2
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/v5...v5.0.2)

---
updated-dependencies:
- dependency-name: dependabot/fetch-metadata
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-19 16:13:47 +00:00
Arthur Silva Sens d85cd60da9
chore: Remove half-implemented changelog automation (#1564)
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
2024-07-19 17:12:40 +01:00
Arthur Silva Sens 5d119ae726
Merge pull request #1561 from prometheus/repo_sync
Synchronize common files from prometheus/prometheus
2024-07-18 12:21:21 -03:00
Arthur Silva Sens a46cfa7f0b
Merge branch 'main' into repo_sync 2024-07-17 15:01:18 -03:00
Huw Jones 10f4161c7d
process_collector: collect received/transmitted bytes (#1555)
Signed-off-by: Huw Jones <huw@pexip.com>
2024-07-17 12:19:40 +02:00
Ben Kochie fec6b222d9
Update Go tests (#1562)
Add new metric that appeared in 1.22.5 and 1.21.12.
* Improve test output with `cmp.Diff`.

Signed-off-by: SuperQ <superq@gmail.com>
2024-07-15 19:28:14 +02:00
prombot e0573a6c76 Update common Prometheus files
Signed-off-by: prombot <prometheus-team@googlegroups.com>
2024-07-12 17:47:44 +00:00
dependabot[bot] 1b23087a63
build(deps): bump google.golang.org/protobuf from 1.34.1 to 1.34.2
Bumps google.golang.org/protobuf from 1.34.1 to 1.34.2.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-12 12:27:14 +00:00
github-actions[bot] 45f1e72421
Merge pull request #1553 from prometheus/dependabot/go_modules/github.com/klauspost/compress-1.17.9
build(deps): bump github.com/klauspost/compress from 1.17.8 to 1.17.9
2024-07-12 13:26:01 +01:00