Kemal Akkoyun
53e51c4f53
Merge pull request #1157 from prometheus/cut-1.13.1
...
Bugfixes + Cut 1.13.1 + documenting release process.
2022-11-02 09:12:58 +01:00
bwplotka
79ca0eb2ba
Added tip from Björn + Grammarly.
...
Signed-off-by: bwplotka <bwplotka@gmail.com>
2022-11-01 16:54:19 +00:00
bwplotka
078f11f85b
Cut 1.13.1 release (+ documenting release process).
...
Signed-off-by: bwplotka <bwplotka@gmail.com>
2022-11-01 16:37:13 +00:00
Fabian Stäber
ddd7f0edcd
Fix race condition with Exemplar in Counter ( #1146 )
...
* Fix race condition with Exemplar in Counter
Potential fix for #1145 .
Signed-off-by: Fabian Stäber <fabian@fstab.de>
* Fix race condition with Exemplar in Counter
Signed-off-by: Fabian Stäber <fabian@fstab.de>
Signed-off-by: Fabian Stäber <fabian@fstab.de>
2022-11-01 16:22:27 +00:00
Balint Zsilavecz
1f93f64580
Fix `CumulativeCount` value of `+Inf` bucket created from exemplar ( #1148 )
...
* Fix `CumulativeCount` value of `+Inf` bucket created from exemplar
Signed-off-by: Balint Zsilavecz <balint.zsilavecz@skyscanner.net>
* Update prometheus/metric_test.go
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Balint Zsilavecz <balint.zsilavecz@skyscanner.net>
* Clarify description of implicit `+Inf` bucket count
Signed-off-by: Balint Zsilavecz <balint.zsilavecz@skyscanner.net>
* Fix test variables
Signed-off-by: Balint Zsilavecz <balint.zsilavecz@skyscanner.net>
Signed-off-by: Balint Zsilavecz <balint.zsilavecz@skyscanner.net>
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
2022-11-01 16:22:22 +00:00
Dave Henderson
8cc2b6c472
Fix double-counting bug in promhttp.InstrumentRoundTripperCounter ( #1118 )
...
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
2022-11-01 16:20:44 +00:00
Björn Rabenstein
5f202eefdb
Merge pull request #1150 from prometheus/sparsehistogram
...
Merge sparsehistogram branch into main
2022-10-31 16:55:36 +01:00
beorn7
fffb76cafe
Merge branch 'main' into sparsehistogram
2022-10-31 16:30:59 +01:00
beorn7
e92a8c7f48
Avoid the term 'sparse' where possible
...
This intends to avoid confusing users by the subtle difference between
a native histogram and a sparse bucket.
Signed-off-by: beorn7 <beorn@grafana.com>
2022-10-31 16:23:08 +01:00
Kemal Akkoyun
0859bb8f37
Merge pull request #1152 from jessicalins/update-to-custom-reg
...
Update examples to use custom registry
2022-10-26 10:15:58 -04:00
Jéssica Lins
a340ca4ba6
Run make format
...
Signed-off-by: Jéssica Lins <jessicaalins@gmail.com>
2022-10-21 17:23:15 +02:00
Jéssica Lins
6056615b26
Update random example to use custom registry
...
Signed-off-by: Jéssica Lins <jessicaalins@gmail.com>
2022-10-21 16:47:21 +02:00
Jéssica Lins
0b7f4888b0
Update simple example to use custom registry
...
Signed-off-by: Jéssica Lins <jessicaalins@gmail.com>
2022-10-21 16:22:25 +02:00
Jéssica Lins
9b5c5b8a47
Update basic example to use custom registry
...
Signed-off-by: Jéssica Lins <jessicaalins@gmail.com>
2022-10-21 16:06:49 +02:00
beorn7
d31f13b599
Add SparseBucketsZeroThresholdZero and groom doc comments
...
Signed-off-by: beorn7 <beorn@grafana.com>
2022-10-19 19:22:46 +02:00
beorn7
58a8ca4588
examples: Adjust doc comment for native histograms
...
Signed-off-by: beorn7 <beorn@grafana.com>
2022-10-19 18:38:57 +02:00
beorn7
4e71e6ff20
Update prometheus/client_model dependency
...
Native histograms are now in a tagged version (v0.3.0).
Signed-off-by: beorn7 <beorn@grafana.com>
2022-10-19 18:27:50 +02:00
beorn7
111fae11e1
Merge branch 'main' into sparsehistogram
2022-10-19 18:09:21 +02:00
Fabian Stäber
10b0550932
Fix race condition with Exemplar in Counter ( #1146 )
...
* Fix race condition with Exemplar in Counter
Potential fix for #1145 .
Signed-off-by: Fabian Stäber <fabian@fstab.de>
* Fix race condition with Exemplar in Counter
Signed-off-by: Fabian Stäber <fabian@fstab.de>
Signed-off-by: Fabian Stäber <fabian@fstab.de>
2022-10-17 20:50:50 +02:00
Balint Zsilavecz
dcea97eee2
Fix `CumulativeCount` value of `+Inf` bucket created from exemplar ( #1148 )
...
* Fix `CumulativeCount` value of `+Inf` bucket created from exemplar
Signed-off-by: Balint Zsilavecz <balint.zsilavecz@skyscanner.net>
* Update prometheus/metric_test.go
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Balint Zsilavecz <balint.zsilavecz@skyscanner.net>
* Clarify description of implicit `+Inf` bucket count
Signed-off-by: Balint Zsilavecz <balint.zsilavecz@skyscanner.net>
* Fix test variables
Signed-off-by: Balint Zsilavecz <balint.zsilavecz@skyscanner.net>
Signed-off-by: Balint Zsilavecz <balint.zsilavecz@skyscanner.net>
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
2022-10-13 13:52:19 +02:00
Björn Rabenstein
25bc1886c0
Merge pull request #1144 from prometheus/beorn7/histogram2
...
sparse buckets: Fix handling of +Inf/-Inf/NaN observations
2022-10-11 12:57:40 +02:00
beorn7
6942f9e454
sparse buckets: Fix handling of +Inf/-Inf/NaN observations
...
NaN observations now go to no bucket, but increment count (and
effectively set sum to NaN, too).
±Inf observations now go to the bucket following the bucket that would
have received math.MaxFloat64. The former is now the last bucket that
can be created.
The getLe is modified to return math.MaxFloat64 for the penultimate
possible bucket.
Also add a test for getLe.
Signed-off-by: beorn7 <beorn@grafana.com>
2022-10-06 17:40:15 +02:00
rogerogers
9801a4e3ce
Examples: Replace deprecated WithGoCollections with WithGoCollectorRuntimeMetrics ( #1130 )
...
Signed-off-by: rogerogers <rogers@rogerogers.com>
Signed-off-by: rogerogers <rogers@rogerogers.com>
2022-09-12 11:24:20 +02:00
Rafael Franco
7c46c150bd
Clarify documentation around what constructors do ( #1125 )
...
The wording of the documentation is slightly misleading. Before this
commit, it says that the returned collectors are "already registered".
This could be interpreted in two ways, one could think that promauto
keeps some sort of cache of already registered Collectors that are
returned by this package, and the other way is that the Collectors
constructed are registered before being returned. What is actually
happening is the latter, and the wording after this PR leaves no room to
think that the former could be the case.
Signed-off-by: Rafael Franco <me@rafaelfranco.es>
Signed-off-by: Rafael Franco <me@rafaelfranco.es>
2022-09-12 11:17:56 +02:00
beorn7
95cf173f19
Merge branch 'main' into sparsehistogram
2022-08-23 14:28:33 +02:00
Robert Fratto
83d56b1144
Extend prometheus.Registry to implement Collector ( #1103 )
...
* prometheus: implement Collector interface for Registry
This change allows Registries to be used as Collectors.
This enables new instances of Registry to be passed to ephemeral
subroutines for collecting metrics from subroutines which are still
running:
```go
package main
import (
"fmt"
"github.com/prometheus/client_golang/prometheus"
)
func main() {
globalReg := prometheus.NewRegistry()
for i := 0; i < 100; i++ {
workerReg := prometheus.WrapRegistererWith(prometheus.Labels{
// Add an ID label so registered metrics from workers don't
// collide.
"worker_id": fmt.Sprintf("%d", i),
}, prometheus.NewRegistry()
globalReg.MustRegister(workerReg)
go func(i int) {
runWorker(workerReg)
// Unregister any metrics the worker may have created.
globalReg.Unregister(workerReg)
}(i)
}
}
// runWorker runs a worker, registering worker-specific metrics.
func runWorker(reg *prometheus.Registry) {
// ... register metrics ...
// ... do work ...
}
```
This change makes it easier to avoid leaking metrics from subroutines
which do not consistently properly unregister metrics.
Signed-off-by: Robert Fratto <robertfratto@gmail.com>
* fix grammar in doc comment
Signed-off-by: Robert Fratto <robertfratto@gmail.com>
* document why Registry implements Collector with example
Signed-off-by: Robert Fratto <robertfratto@gmail.com>
Signed-off-by: Robert Fratto <robertfratto@gmail.com>
2022-08-23 11:09:29 +02:00
Dave Henderson
4c41dfbcd5
Clarify exemplar(Add|Observe) by renaming to (add|observe)WithExemplar ( #1122 )
...
* Clarify exemplarAdd by renaming to addWithExemplar
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
* Documenting addWithExemplar
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
* Also rename exemplarObserve to follow the same pattern
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
2022-08-22 17:31:08 +02:00
Dave Henderson
f73e3cc0e2
Fix double-counting bug in promhttp.InstrumentRoundTripperCounter ( #1118 )
...
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
2022-08-22 08:28:46 +03:00
Kemal Akkoyun
c7aa2a5b84
Merge pull request #1113 from prometheus/release-1.13
...
Merging release-1.13.0 to main (non-squash)
2022-08-06 10:02:27 +02:00
PrometheusBot
1e61b8ea3c
Update common Prometheus files ( #1111 )
...
Signed-off-by: prombot <prometheus-team@googlegroups.com>
2022-08-05 22:38:30 +02:00
Bartlomiej Plotka
64435fc00a
Cut 1.13.0 ( #1110 )
...
Signed-off-by: bwplotka <bwplotka@gmail.com>
2022-08-05 20:31:42 +02:00
Bartlomiej Plotka
5b7e8b2e67
collectors.GoCollector: Added rule support for granular metric configuration. ( #1102 )
...
* goCollector: Added rule support for granular metric configuration.
Fixes: https://github.com/prometheus/client_golang/issues/1089
Signed-off-by: bwplotka <bwplotka@gmail.com>
* Added compatibility mode with old options. (#1107 )
* Added compatibility mode with old options.
Signed-off-by: bwplotka <bwplotka@gmail.com>
* Copyright header.
Signed-off-by: bwplotka <bwplotka@gmail.com>
* Remove bucket option for now. (#1108 )
Signed-off-by: bwplotka <bwplotka@gmail.com>
* collectors/GoCollector: Add tests and examples (#1109 )
* Add tests and examples
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
* Add docs for the presets
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Co-authored-by: Kemal Akkoyun <kakkoyun@users.noreply.github.com>
2022-08-05 19:37:46 +02:00
Christian Stewart
d44fbbefdd
Fix build against GopherJS ( #897 )
...
* Fix build against GopherJS
When building against GopherJS, ThreadCreateProfile and Getpid are not
available.
Return 1 to shim the functions.
Signed-off-by: Christian Stewart <christian@paral.in>
* Fix formatting
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
* Fix linter issue
Move build tags for licence header checks
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Co-authored-by: Kemal Akkoyun <kakkoyun@gmail.com>
2022-08-05 16:28:54 +02:00
Soroosh Azary Marhabi
1638da9ae4
testutil: Add ScrapeAndCompare ( #1043 )
...
* testutil: Add ScrapeAndCompare
Signed-off-by: sazary <soroosh@azary.ir>
* testutil: Use %w verb wherever we're using an error in fmt.Errorf
Signed-off-by: sazary <soroosh@azary.ir>
* Format
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Co-authored-by: Kemal Akkoyun <kakkoyun@users.noreply.github.com>
Co-authored-by: Kemal Akkoyun <kakkoyun@gmail.com>
2022-08-05 16:27:47 +02:00
Kemal Akkoyun
c576b951ad
Generate new Go runtime metrics for go 1.19 ( #1105 )
...
* Generate new Go runtime metrics
Fix generation script
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
* Address review issues
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
2022-08-05 15:48:33 +02:00
Christoph Mewes
618194de6a
fix assorted oddities found by golangci-lint ( #1040 )
...
* fix assorted oddities found by golangci-lint
Signed-off-by: Christoph Mewes <christoph@kubermatic.com>
* permanently enable the linters
Signed-off-by: Christoph Mewes <christoph@kubermatic.com>
* post-rebase blues
Signed-off-by: Christoph Mewes <christoph@kubermatic.com>
2022-08-03 06:30:51 +02:00
Bartlomiej Plotka
c7488be2e4
Added exemplar support to http middleware. ( #1055 )
...
* Added exemplar support to http middlewares.
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
* Small fix.
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
* Fixed test.
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
* Added tests and options for RT.
Signed-off-by: bwplotka <bwplotka@gmail.com>
* goimports.
Signed-off-by: bwplotka <bwplotka@gmail.com>
2022-08-02 19:33:08 +02:00
Bartlomiej Plotka
3faf3bae70
Fixed support for unordered input of exemplars. ( #1100 )
...
Signed-off-by: bwplotka <bwplotka@gmail.com>
2022-08-02 11:32:30 +02:00
Joseph Woodward
44ce5e1ee5
Ensure tests verify request params ( #1047 )
...
* Ensure tests verify request params
Signed-off-by: Joseph Woodward <joseph.woodward@xeuse.com>
* Fix error message
Signed-off-by: Joseph Woodward <joseph.woodward@xeuse.com>
* gofumpt-ed with extra.
Signed-off-by: bwplotka <bwplotka@gmail.com>
Co-authored-by: bwplotka <bwplotka@gmail.com>
2022-08-02 11:24:17 +02:00
Arun Mahendra
807b1ee73c
explicitly add +inf bucket in withExemplarsMetric ( #1094 )
...
* explicitly adding +inf bucket to withExemplarsMetric
Signed-off-by: Arun Mahendra <arun.mahendra@shopify.com>
* Update prometheus/metric_test.go
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
* Update prometheus/metric.go
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
* updated comment and removed unnecessary test
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
2022-08-02 10:48:18 +02:00
dependabot[bot]
c6d4e40244
Bump github.com/prometheus/procfs from 0.7.3 to 0.8.0 ( #1097 )
...
Bumps [github.com/prometheus/procfs](https://github.com/prometheus/procfs ) from 0.7.3 to 0.8.0.
- [Release notes](https://github.com/prometheus/procfs/releases )
- [Commits](https://github.com/prometheus/procfs/compare/v0.7.3...v0.8.0 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/procfs
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-08-02 10:43:54 +02:00
inosato
44c2c4de85
Remove ioutil ( #1096 )
...
Signed-off-by: inosato <si17_21@yahoo.co.jp>
2022-08-02 10:27:49 +02:00
dependabot[bot]
76cdae298e
Bump google.golang.org/protobuf from 1.28.0 to 1.28.1 ( #1099 )
...
Bumps [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go ) from 1.28.0 to 1.28.1.
- [Release notes](https://github.com/protocolbuffers/protobuf-go/releases )
- [Changelog](https://github.com/protocolbuffers/protobuf-go/blob/master/release.bash )
- [Commits](https://github.com/protocolbuffers/protobuf-go/compare/v1.28.0...v1.28.1 )
---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-08-02 10:24:34 +02:00
dependabot[bot]
9154d30db7
Bump github.com/prometheus/common from 0.35.0 to 0.37.0 ( #1098 )
...
Bumps [github.com/prometheus/common](https://github.com/prometheus/common ) from 0.35.0 to 0.37.0.
- [Release notes](https://github.com/prometheus/common/releases )
- [Commits](https://github.com/prometheus/common/compare/v0.35.0...v0.37.0 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/common
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-08-02 10:23:53 +02:00
Fredrik Enestad
a528affed9
Update documentation for exemplar label limit ( #1095 )
...
Signed-off-by: Fredrik Enestad <fredrik@enestad.com>
2022-07-27 17:45:49 +02:00
Björn Rabenstein
ec86ef1833
Merge pull request #1092 from prometheus/beorn7/histogram
...
histograms: Move to new exposition protobuf format
2022-07-20 13:26:40 +02:00
beorn7
8cbcd4076a
histograms: Move to new exposition protobuf format
...
Note that this is an incompatible change. To scrape this new format,
the Prometheus server needs to be updated at the same time. PR
incoming.
Signed-off-by: beorn7 <beorn@grafana.com>
2022-07-19 16:54:05 +02:00
Bryan Boreham
ba4a543ab4
Raise exemplar labels limit from 64 to 128 ( #1091 )
...
In line with the OpenMetrics spec:
"The combined length of the label names and values of an Exemplar's
LabelSet MUST NOT exceed 128 UTF-8 character code points"
https://github.com/OpenObservability/OpenMetrics/blob/98ae26c87b/specification/OpenMetrics.md#exemplars
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2022-07-19 16:50:45 +02:00
beorn7
6141a0784e
Merge branch 'main' into sparsehistogram
2022-07-19 14:53:32 +02:00
Bartlomiej Plotka
3d482bb7cf
Merge pull request #1081 from prometheus/beorn7/release
...
Merging release branch back to main again
2022-07-07 18:19:45 +02:00