Commit Graph

2184 Commits

Author SHA1 Message Date
Saxon 6992ab395b protocol/rtp: removed extHeaderLen func 2019-04-09 15:45:40 +09:30
Saxon b5c018276f protocol/rtp: commented rtpVer const and made defaultHeadSize 12 rather than 4*3 2019-04-09 15:45:40 +09:30
Saxon df3e66e5b2 protocol/rtp: removed redundant version checks from helper funcs in parse.go 2019-04-09 15:45:40 +09:30
Saxon 09b8a2baff protocol/rtp: fixed indentation issue in file header in parse_test.go 2019-04-09 15:45:40 +09:30
Saxon b5711d18c5 protocol/rtp: fixed indentation issue in file header 2019-04-09 15:45:40 +09:30
Saxon 3dfc7ed990 protocol/rtp: wrote TestPayload
Wrote test TestPayload which will check that we can correctly get the payload from an RTP
packet using Payload for a variety of different RTP packet configurations.
2019-04-09 15:45:40 +09:30
Saxon 275b86285e protocol/rtp: added TestExtHeaderLen
Added test TestExtHeaderLen which checks that extHeaderLen returns the correct len for
an RTP packet with an extension header.
2019-04-09 15:45:40 +09:30
Saxon 3dc6d7733b protocol/rtp: wrote TestHasExt
Wrote test TestHasExt which checks the behaviour of hasExt for when it's call with an
RTP packet with an extension indicator and also for an RTP packet with no extension
indicator.
2019-04-09 15:45:40 +09:30
Saxon c2b67d7fb9 protocol/rtp: wrote TestCsrcCount
Wrote test TestCsrcCount to check behaviour of csrcCount is expected.
2019-04-09 15:45:40 +09:30
Saxon 74b25e646a protocol/rtp: wrote TestVersion
Wrote test that checks the version func will correctly get the
version from an RTP packet.
2019-04-09 15:45:40 +09:30
Saxon fa9888723f protocol/rtp: added parse_test.go file and fixed copyrights. 2019-04-09 15:45:40 +09:30
Saxon af9a9bc6c0 protocol/rtp: added parse.go file with parsing functionality
Added parse.go. This file contains functionality to obtain the Payload from an RTP packet.
Unexported functions to help with this extraction have been added; extHeaderLen, hasExt,
csrcCount and version.
2019-04-09 15:45:40 +09:30
Saxon 4978db2f2b revid: fixed silly rtp bug 2019-04-09 15:44:18 +09:30
Saxon Milton 2d15e98445 Merged in remove-load-and-send (pull request #178)
revid: remove load and send methods for senders

Approved-by: kortschak <dan@kortschak.io>
2019-04-03 04:05:10 +00:00
Saxon Milton 62defd0e8f Merged in rtp-improve (pull request #177)
protocol/rtp: extended functionality of rtp pkg

Approved-by: kortschak <dan@kortschak.io>
2019-04-03 01:52:31 +00:00
Saxon 6dbbee81d2 protocol/rtp: rtp packet payload comment update 2019-04-03 12:20:54 +10:30
Saxon e0d85b8598 revid: removed comment of a print in senders_test.go 2019-04-03 11:40:33 +10:30
Saxon 9435baec5c revid: fixed Write for dummyMultiWriter in revid_test.go 2019-04-03 11:38:37 +10:30
Saxon a061a79805 revid: don't need to make new r.encoder each time just do r.encoder = r.encoder[:0] 2019-04-03 11:36:49 +10:30
Saxon 2bd17d0296 revid: removed restarter interface from senders.go as not required anymore 2019-04-03 11:34:18 +10:30
Saxon b9e7c3ff8c revid: fixed dummyMultiWriter Write func so that it satisfies semantics of io.Writer.Write 2019-04-03 11:31:21 +10:30
Saxon 9bd41b7c3b revid: simplified signature for setupPipeline and fixed commenting 2019-04-03 11:29:54 +10:30
Saxon efa0d38aad protocol/rtp: removed Len field from ExtensionHeader struct as we can gather from len(ExtensionHeader.Header) 2019-04-02 21:49:11 +10:30
Saxon dbcac80d1f revid: fixed some general commenting 2019-04-02 13:45:36 +10:30
Saxon 681e07540a revid: removed loadSender interface as no longer required
Removed the loadSender interface as no longer required. As a result close implementations that do nothing have also been removed.
2019-04-02 13:29:18 +10:30
Saxon 6b91746cf6 revid: removed multiSender and started using std io.multiWriter
We are now using an io.multiWriter rather than the multiSender. Code has been updated inside revid.go to account for this change, and tests have also been updated accordingly. Tests for
the multiSender have been removed. A dummyMultiWriter has been written to inject our own multiWriter during testing.
2019-04-02 13:21:46 +10:30
Saxon 065f8ded79 revid: finished simplifying senders
simplified rtmp and rtp senders by removing load and send methods and doing equivalent logic inside their Write functions.
2019-04-02 12:53:42 +10:30
Saxon cdd2537cc3 revid: simplified file sender to remove load and send and just do logic in Write 2019-04-01 12:11:05 +10:30
Saxon f17d2ffb8c revid: got rid of minimalHttpSender
Now that we're removing the concept of a loadSender, there is no need to have a minimalHttpSender (did not implement loadSender) and a httpSender (implemented loadSender). So we can now have
a single httpSender that implements io.Writer just like every other sender.
2019-04-01 12:07:28 +10:30
Saxon 5a67e71fe4 revid: made minimalHttpSender implement io.Writer 2019-04-01 12:02:15 +10:30
Saxon 24e484c07f revid: simplified mtsSender to remove load and send
mtsSender has been simplified such that load and send are no longer called in Write. Load and Send have removed and logic is now in Write. The logic has been simplified such that it does not
try to send again. On next PR when ringbuffers are added to senders, we will add logic to deal with this.
2019-04-01 11:50:11 +10:30
Saxon Milton ec3e0df977 Merged in senders-are-writers (pull request #176)
revid: senders are now io.Writers

Approved-by: kortschak <dan@kortschak.io>
Approved-by: Alan Noble <anoble@gmail.com>
2019-03-30 05:57:08 +00:00
Saxon afe2948cf7 revid: removed unnecessary assertion 2019-03-30 10:08:27 +10:30
Saxon 86971ca055 revid: simplified comments for sender Write methods 2019-03-29 16:24:47 +10:30
Saxon 8cc7f6e500 revid: improved some naming 2019-03-29 16:22:51 +10:30
Saxon 7c724c9fc3 revid: simplified determination of sender types 2019-03-29 16:17:11 +10:30
Saxon 95a9e4a2ef protocol/rtp: extended functionality of rtp pkg
rtp.Bytes can now deal with CSRC fields, extension fields and padding. Tests have been updated to be more extensive in checks.
2019-03-29 15:48:34 +10:30
Saxon 648b43c50a revid: added some commentary 2019-03-29 13:29:31 +10:30
Saxon 3896a5e804 revid: senders are now io.Writers
Added a Write method to senders such that they implement io.Writer. The multiSender now takes a slice of io.writers.
Also modified revid code and tests to account for this chance.
2019-03-29 12:49:26 +10:30
Saxon Milton 7c31f6fd6c Merged in av-restructure (pull request #175)
av: restructured directories

Approved-by: Alan Noble <anoble@gmail.com>
2019-03-28 06:57:18 +00:00
Saxon a67844e1c6 av: adding go.sum 2019-03-28 12:34:54 +10:30
Saxon da54f7af27 av: fixed remaining import errors 2019-03-28 11:35:32 +10:30
Saxon de172bd0a1 av: updated go.mod 2019-03-28 11:28:46 +10:30
Saxon 937f54f418 av: fixed conflicts with master 2019-03-28 11:03:05 +10:30
Saxon Milton fb6402d5e7 Merged in ringbuffer-move (pull request #167)
cmd/revid-cli & revid: moved ringBuffer to earlier in pipeline

Approved-by: Alan Noble <anoble@gmail.com>
Approved-by: kortschak <dan@kortschak.io>
2019-03-27 23:04:29 +00:00
Trek Hopton d491e1fb6d Merged in channel-and-rate-conversion (pull request #169)
Channel and rate conversion

Approved-by: kortschak <dan@kortschak.io>
2019-03-27 03:28:50 +00:00
Trek H 9a9a38dbe1 pcm: simplified and improved efficiency of code. 2019-03-26 15:43:11 +10:30
Trek H 72f0b009fe Merge branch 'master' into channel-and-rate-conversion 2019-03-26 11:59:07 +10:30
Saxon 5366eca2f2 av: fixed imports 2019-03-25 11:51:03 +10:30
Saxon 3a736172ee av: restructured directories 2019-03-25 11:34:56 +10:30