Commit Graph

189 Commits

Author SHA1 Message Date
Saxon a025d55d81 protocol/rtsp: using Fprintf with strings.Builder in Request.String() and Response.String() 2019-04-30 21:41:46 +09:30
Saxon 960d0b4477 protocol/rtsp/cmd/record: using select rather than for loop to wait at end of record program 2019-04-30 21:37:06 +09:30
Saxon 6a9d2755d1 protocol/rtsp: don't need to wrap conn in bufio.Reader() 2019-04-30 21:36:06 +09:30
Saxon a4da3dab15 protocol/rtsp/client.go: using u instead of url from url.Parse in Client.Setup() 2019-04-30 21:33:35 +09:30
Saxon 8196df52d7 protocol/rtsp: added newline after file headers 2019-04-30 21:32:05 +09:30
Saxon 299b13b691 codec/h265: started writing lexer
Started writing lexer for h265. Wrote type Lexer as we required a data struct we can initialize before starting the lexing process, with for example, information regarding the presense of DONL and
DOND. Wrote handler for aggregation packet. Still need to do fragmentation packet.
2019-04-30 16:38:23 +09:30
Saxon d358f70585 protocol/rtp: made client_test.go more robust 2019-04-30 09:39:41 +09:30
Saxon 6694cab956 protocol/rtp: commented Client.Err() 2019-04-30 02:38:38 +09:30
Saxon 49a401681d protocol/rtp: Client.ErrChan => Client.err and wrote accessor function Client.Err() to access this chan as only receive 2019-04-30 02:37:18 +09:30
Saxon 944fe00e5d protocol/rtsp: commented TestReadResponse 2019-04-30 02:32:24 +09:30
Saxon f197acc50a protocol/rtsp: fixed conflicts in go.mod and go.sum 2019-04-30 02:30:12 +09:30
Saxon 401376c059 protocol/rtsp: expected CSeq key is just Cseq now to match ReadResponse result. 2019-04-30 02:19:34 +09:30
Saxon c552238da5 protocol/rtsp: added some commenting to TestReadResponse and required helper function 2019-04-29 20:18:07 +09:30
Saxon 86bf4cdb90 protocol/rtsp: TestReadResponse now working 2019-04-29 19:28:18 +09:30
Saxon d2b76fab36 protocol/rtsp: wrote test ReadResponse, but work in progress 2019-04-29 18:21:59 +09:30
Saxon 0a27395aea protocol/rtsp: doing length check in same if but before RTSP protocol check 2019-04-29 13:35:58 +09:30
Saxon 64f6a3d814 protocol/rtsp: used utter/dump to get ASCII text as well 2019-04-29 13:34:09 +09:30
Saxon eac5652f1b protocol/rtsp: in ReadResponse response length check comes before protocol check 2019-04-29 13:19:32 +09:30
Saxon ba7e768269 protocol/rtsp/cmd/record: sess => clt in record 2019-04-29 13:16:15 +09:30
Saxon dd58851e6c protocol/rtsp: added todo to test client connect retry regarding use of generalised retry utility when available. 2019-04-29 13:13:12 +09:30
Saxon a783b2052e protocol/rtsp: for test, read buf size is now const called max reequest size 2019-04-29 13:11:27 +09:30
Saxon 66bc6bbe33 protocol/rtsp: only giving Sscanf s[5:] and then checking number of decimals read as well as error 2019-04-29 13:08:05 +09:30
Saxon 77e5d234de protocol/rtsp: doing RTSP and response length check in same if 2019-04-29 13:03:39 +09:30
Saxon ba5a0d898c protocol/rtsp: removed status 2019-04-29 13:01:17 +09:30
Saxon 6605ee7295 protocol/rtsp: general naming clean up 2019-04-29 12:39:58 +09:30
Saxon d91995a1cf protocol/rtsp: using bufio.Scanner 2019-04-28 14:04:45 +09:30
Saxon d7c2421146 protocol/rtsp: fixed sscanf in ReadResponse 2019-04-28 13:51:25 +09:30
Saxon fa7c3044f3 protocol/rtsp: simplified ReadResponse further by using only one sscanf 2019-04-28 13:23:35 +09:30
Saxon 9abcfb138b protocol/rtsp: checking error from scans 2019-04-28 12:27:54 +09:30
Saxon 39d0b5d6da protocol/rtsp: using sscanf to parse response 2019-04-28 02:35:13 +09:30
Saxon 26d05d1bd4 protocol/rtsp/cmd/record: removed stream binary 2019-04-28 01:44:33 +09:30
Saxon a57d3f66ff protocol/rtsp: using int rather than int64 for Response.ConentLength 2019-04-28 01:32:44 +09:30
Saxon 94660e730b protocol/rtsp: using strings.Builder to write String formats for Request and Response 2019-04-28 01:29:47 +09:30
Saxon eb6b5a04b0 protocol/rtsp: indicate that minResponse size is in bytes 2019-04-28 00:58:33 +09:30
Saxon 31508f8940 protocol/rtsp: removed pre-existing license 2019-04-28 00:57:40 +09:30
Saxon a62adca171 protocol/rtsp/cmd: renamed stream to record 2019-04-28 00:56:44 +09:30
Saxon 01a22ffc38 protocol/rtsp: Client.Do r parameter now req. 2019-04-28 00:54:44 +09:30
Saxon 07e7235dc4 protocol/rtsp: using string literals for request methods 2019-04-28 00:53:47 +09:30
Saxon 2f752d5b7f protocol/rtsp: NewClient u parameter now addr and client instance not s now c 2019-04-28 00:51:06 +09:30
Saxon Milton b4ff40e269 Merged in remove-early-ringbuffer (pull request )
revid: removed main ringBuffer

Approved-by: Alan Noble <anoble@gmail.com>
Approved-by: kortschak <dan@kortschak.io>
2019-04-27 12:24:08 +00:00
Saxon 5d6e3171bf protocol/rtmp: fixed usage of h264 lexer in rtmp_test.go 2019-04-27 20:37:23 +09:30
Saxon 77094acc67 protocol/rtsp: Client.session => Client.sessionID 2019-04-26 19:53:08 +09:30
Saxon f2b941394b protocol/rtsp: fixed read response bug 2019-04-26 19:51:00 +09:30
Saxon 999eab21ab protocol/rtsp: cleaned up ReadResponse 2019-04-26 19:46:03 +09:30
Saxon 3e17016390 protocol/rtsp: updated licensing 2019-04-26 16:01:57 +09:30
Saxon f0a1a866dd protocol/rtsp: removed writeRequest receiver method 2019-04-26 15:09:59 +09:30
Saxon 4998d8d4d6 protocol/rtsp/cmd/stream: using NewClient rather than NewSession 2019-04-26 14:35:25 +09:30
Saxon 14cb6f7f07 protocol/rtsp: reflect go net.http package patterns
Request now has a Write receiver method that will write to the passed io.Writer. Client now has Do method that will send the request and return the respons and any errors. Also Renamed the Client
field to Session, which was mistakenly changed.
2019-04-26 14:20:58 +09:30
Saxon 4e98b4d2ea protocol/rtsp: renamed urlStr to addr 2019-04-26 14:08:58 +09:30
Saxon cd18d9f5a7 protocol/rtsp: removed Client field from client struct as not useful 2019-04-26 14:07:29 +09:30
Saxon a0fb299b06 protocol/rtsp: moved client functionality into client.go file 2019-04-26 13:57:18 +09:30
Alan Noble 149a2fa6b9 Fix package-level doc comment. 2019-04-26 00:36:23 +00:00
Saxon 9169afe34f protocol/rtsp: general clean up 2019-04-25 15:30:28 +09:30
Saxon f3f3be5fc6 protocol/rtsp: completed test for rtsp
Completed test to check that each method we support works and can produce valid requests. The requests are compared to requests that have been proven valid. This test also checks that the RTSP
client communicates over tcp correctly. i.e. we have set up a client and server, and we check that this communication happens correctly.
2019-04-25 14:46:21 +09:30
Saxon adbb9d1c99 protocol/rtsp: added testing file and wrote some signature for possible tests 2019-04-23 17:27:37 +09:30
Saxon e00c959a84 protocol/rtcp: renamed NTPTimestamp to Timestamp
Renamed NTPTimestamp and referenced specifications rather than quoting. Renamed Timestamp func to ParseTimestamp.
2019-04-23 16:40:26 +09:30
Saxon a256dc9133 protocol/rtsp: made rtsp/cmd/stream functional 2019-04-23 16:22:58 +09:30
Saxon 34c59c95d6 protocol/rtsp: working on main.go in rtsp/cmd/stream
Added file header to main.go, and modified rtsp.go to work with cmd/stream/main.go. This change modifies writeRequest, which now takes a *url.URL. This means the Setup() method can parse a new
URL that contains a given track, and then give this to writeRequest.
2019-04-23 15:49:54 +09:30
Saxon d03ae3ff7e protocol/rtsp: fixed rtsp.go file header indentation 2019-04-23 15:33:07 +09:30
Saxon 63da7dbb59 protocol/rtcp: removed unecessary logging in test files 2019-04-23 14:45:16 +09:30
Saxon 017abea667 protocol/rtcp: fixed indentation in file headers 2019-04-23 14:38:26 +09:30
Saxon 4c2962ba75 protocol/rtcp: renamed SourceDescription to Description 2019-04-23 14:33:27 +09:30
Saxon 889072bde0 protocol/rtcp: improve ReportBlock field names 2019-04-23 14:30:05 +09:30
Saxon 4068aea207 protocol/rtp: better comment for NTPTimestamp and renamed fields 2019-04-23 14:25:22 +09:30
Saxon b43f6f8072 protocol/rtcp: renamed highestSequence() to sequence. 2019-04-23 14:16:40 +09:30
Saxon 6b994d0dba protocol/rtcp: made Client error channel unexported
Renamed Client ErrChan field to err, i.e. made unexported. Wrote Err() accessor that allows user to only read from error channel.
2019-04-23 13:26:56 +09:30
Saxon a43ef56618 protocol/rtcp: addressing PR feedback 2019-04-22 00:34:03 +09:30
Saxon cbad00b6e6 av: fixed conflict 2019-04-21 23:58:59 +09:30
Saxon a0c324a813 protocol/rtp: simplified test
Simplified clien_test.go file by testing two different RTP packet operations using loop. We now first test no operation,
and then test a rtp.Payload operation, which gets the payload of the packets and stores them in the client ringbuffer for the
user of the client to read.
2019-04-21 23:07:30 +09:30
Saxon be76998c7d protocol/rtp: wrote TestReceiveNoOp
Wrote test TestReceiveNoOP to check that client works correctly when we give no operation to perform on RTP packets before
storing in the client ringBuffer, which calling io.Reader implementation Read will get packets form.
2019-04-21 22:40:08 +09:30
Saxon f454a34856 protocol/rtp: added client_test.go for client testing 2019-04-20 21:10:03 +09:30
Saxon 00db293b44 protocol/rtp: consts for chan and ringbuffer sizes 2019-04-20 21:05:34 +09:30
Saxon 190d546c58 protocol/rtp: commented file 2019-04-19 18:40:15 +09:30
Saxon b302eafa68 protocol/rtp: setting Client's op field in constructor 2019-04-19 18:22:43 +09:30
Saxon ccc08bfad1 protoocl/rtp: added client.go file
Added client.go which contains a struct to describe an RTP client. It provides a method, Start, which will
invoke a recv routine to start receiving packets and process them using an op function passed on the Client's
creation. Client implements io.Reader, so that the client may be read from.
2019-04-19 18:17:06 +09:30
Saxon a8e56311c2 protocol/rtcp: addressing PR feedback 2019-04-19 14:15:43 +09:30
Saxon 68b996f698 protocol/rtsp: removed LICENSE.BSD file as license now in rtsp.go 2019-04-18 13:53:02 +09:30
Saxon e87eadf8fd protocol/rtsp/rtsp.go: commenting and general clean up. 2019-04-17 18:31:03 +09:30
Saxon c9082c1b4c protocol/rtsp/rtsp.go: put tcp dial in new session
tcp dial is now in new session, firstly so that we don't have to do the s.conn == nil check and also so that we dont't have to pass around the url everywhere.
2019-04-17 12:45:02 +09:30
Saxon 85bb88c325 protocol/rtsp: removed README 2019-04-17 12:22:54 +09:30
Saxon 1bcf05830d protocol/rtsp: removing rtp package
We already have an rtp package, which I will extend with client functionality, so we don't need this here.
2019-04-17 12:20:36 +09:30
Saxon 02c11c234f protocol/rtsp/rtsp.go: added back beatgammits structs
Added them back because i realised I can't use http Requests and Responses and the accompanying methods because then this wouldn't be the RTSP protocol, it would be the HTTP protocol, which is not what we're doing.
2019-04-17 12:18:23 +09:30
Saxon 0543cb0968 protocol/rtsp/rtsp.go: got rid of NewRequest and put logic into writeRequest 2019-04-17 10:20:49 +09:30
Saxon 948e9a67e1 protocol/rtsp/rtsp.go: simplified RTSP method functions wrap a single writeRequest func 2019-04-17 09:05:34 +09:30
Saxon 6f4738a04c protocol/rtsp: removed sdp stuff
We won't be using this, at least not initially, so it's being deleted.
2019-04-17 08:15:52 +09:30
Saxon cd7e2ce3f3 protocol/rtsp: removed response writer interface, which was just http.ResponseWriter 2019-04-17 07:51:34 +09:30
Saxon d34eabcd34 protocol/rtcp/client.go: not using defer for simple setters/getters 2019-04-17 07:41:31 +09:30
Saxon 9de1b541a9 protocol/rtsp: removed unused stuff
Firstly removed unused RTSP method string consts. Also removed all the unused http response codes. Removed
ReadRequest, as this was also not used.
2019-04-16 23:32:50 +09:30
Saxon 4a97a626a0 protocol/rtsp: added beatgammits pkg and also my stream/main.go program
Most of this is unmodified except for the stream/main.go program. I am going to use this as a test that simply streams from an RTSP server to vlc.
2019-04-16 22:47:13 +09:30
Saxon 881ddc3d38 protocol/rtcp: using defer where I can 2019-04-16 22:01:38 +09:30
Saxon f66a94543a protocol/rtcp: fixed some further feedback 2019-04-16 17:17:48 +09:30
Saxon 51478ee064 protocol/rtcp: addressing of PR feedback 2019-04-16 17:16:13 +09:30
Saxon f54dd13959 protocol/rtcp: added file headers 2019-04-16 16:45:44 +09:30
Saxon 5cf39595eb protocol/rtcp: fix case of protocols in comments 2019-04-16 16:31:04 +09:30
Saxon 9e55feafe7 protocol: removed rtsp stuff
For this branch we will only include efforts regarding rtcp.
2019-04-16 12:38:14 +09:30
Saxon 1a19412223 protocol/rtcp: finished client_test.go improved usability or client
Finished writing the client_test.go file and through the process fixed some bugs in the client. Also increased usability by providing a Stop() method
so that the send and recv routines, and also the connection can be terminated. Also created a sender report struct in rtcp.go - this helped with
testing.
2019-04-16 12:33:58 +09:30
Saxon Milton 6ee286e988 Merged in rtp-parsing (pull request )
protocol/rtp: can parse payload from RTP packet

Approved-by: Alan Noble <anoble@gmail.com>
Approved-by: kortschak <dan@kortschak.io>
2019-04-16 00:31:21 +00:00
Saxon aa947d112c protocol/rtcp: wrote test for Client.formPayload 2019-04-15 17:35:36 +09:30
Saxon dca007a5ba rtcp/protocol: tried to make Bytes funcs and client formation of payload more efficient 2019-04-15 16:56:52 +09:30
Saxon 2669862ced protocol/rtcp: wrote struct for RTCP sender report 2019-04-15 15:53:06 +09:30