Commit Graph

113 Commits

Author SHA1 Message Date
Trek H 5fe586913f alsa, revid: added correct device configuration and defaulting for audio 2020-08-11 11:43:17 +09:30
Saxon Milton 4cf155bbc2 Merged in correct-config-types (pull request #401)
Correct types of fields in revid/config/config.go Config struct
2020-05-02 03:55:13 +00:00
Ella Pietraroia 890f142fb9 Merged in godoc (pull request #387)
Package level comments

Approved-by: Saxon Milton <saxon.milton@gmail.com>
2020-04-23 05:35:23 +00:00
Ella Pietraroia 1dbf40952a device/device.go package level comment vs function commenty 2020-04-23 14:54:25 +09:30
Ella Pietraroia b9c413fdd2 device/device.go package level comment wording 2020-04-23 14:51:12 +09:30
Ella Pietraroia 36dfb05326 formatting changes 2020-04-23 14:49:30 +09:30
Ella Pietraroia 2f95c3836c checking godoc on localhost and making edits 2020-04-23 13:13:37 +09:30
Ella Pietraroia 237ecadbc9 more accurate comment for device/device.go 2020-04-23 12:40:54 +09:30
Ella Pietraroia 149f95af84 no package level comments in test files 2020-04-23 12:34:11 +09:30
Saxon Nelson-Milton 1525714439 device/raspivid: fix of closing closed chan 2020-03-31 10:13:21 +01:00
Ella Pietraroia 892e1b92da device: package level comments 2020-03-12 15:56:29 +10:30
Scott 6e1ccf6bda device: add package comments to file, raspivid, geovision and webcam packages 2020-02-26 14:30:42 +10:30
Dan Kortschak 2f85dbcdf6 device/webcam: don't close closed chan 2020-02-03 16:31:42 +10:30
Scott c682f49071 device: use fatal instead of skip in tests 2020-01-31 14:02:45 +10:30
Scott 9ddd4be089 device: use constants for test code 2020-01-31 12:22:48 +10:30
Scott a123789cac device/geovision: implement IsRunning method for geovision 2020-01-30 11:22:41 +10:30
Scott 0bd21b9003 device/alsa: implement IsRunning method for alsa 2020-01-30 11:22:24 +10:30
Scott 25d68cf124 device/raspivid: implement IsRunning method for raspivid 2020-01-30 11:22:11 +10:30
Scott 4c65173604 device/file: implement IsRunning method for file 2020-01-30 11:21:56 +10:30
Scott 5c5672486e device/webcam: implement IsRunning method for webcam 2020-01-30 11:21:39 +10:30
Scott f1d1fe2cad device: add tests for IsRunning
To check that the IsRunning method is working, some tests are needed. These tests shall be skipped when an AVdevice is not connected, such as when testing within Circle-CI.
2020-01-30 11:21:06 +10:30
Scott 9a0e52a8f3 device: add IsRunning method to device interface
This commit adds the IsRunning method to the AVDevice interface. It doesn't implement it yet, that will be for a future commit.
2020-01-29 09:28:44 +10:30
Saxon ed626e02ab cmd/rv: did some cleaning and commenting
Modified profile.go file header. Updated binary name in run.sh.
2020-01-27 15:50:24 +10:30
Saxon 7033d62cc6 cmd/rv: created new revid binary that is only netsender client, not CLI as well 2020-01-27 13:55:09 +10:30
Saxon Milton 36220e967f Merged in rtp-jpeg-extractor (pull request #289)
codec/mjpeg: RTP/JPEG extractor

Approved-by: Alan Noble <anoble@gmail.com>
2020-01-07 04:43:07 +00:00
Ella Pietraroia 55e13c2f8f device/raspivid/raspivid.go changing default bitrate to fit within buffer 2020-01-07 11:26:17 +10:30
Saxon 2d824707ee Fixed bugs, now working 2020-01-03 17:15:06 +10:30
Ella Pietraroia 0da4c3b618 device/webcam/webcam.go: fixed error output 2019-12-23 15:37:20 +10:30
Ella Pietraroia d0102779ed stderr implementation in webcam
same stderr messages made avaliable in raspivid.go now in webcam, so can see when there are problems with with the webcam, rather then our code
2019-12-23 15:27:46 +10:30
Scott c11444f043 FlipHorizontal & FlipVertical variables renamed 2019-12-06 16:36:29 +10:30
Ella Pietraroia f8da6b0609 Merged in raspivid-stderr (pull request #299)
device/raspivid/raspivid.go: piping stderr and checking for errors

Approved-by: Saxon Milton <saxon.milton@gmail.com>
2019-12-05 01:05:20 +00:00
Ella Pietraroia 9f567fbfed device/raspivid/raspivid.go: piping stderr and checking for errors
We now pipe stderr as well as stdout and check for errors on this pipe in a routine called in
raspivid.Start().
2019-12-04 16:41:26 +10:30
Scott e116e197ae Changed all %v's to %w's where appropriate 2019-12-04 14:12:20 +10:30
Scott 565ba3079c Formatted code 2019-12-03 14:55:08 +10:30
Scott 48d36c2082 Ffmpeg gets different args for mjpeg encoding 2019-12-03 14:36:16 +10:30
Scott d5191d9daf Revid CLI accepts MJPEG as an input codec
The ffmpeg command uses the input codec value (H264 or mjpeg). However, it does not yet capture in mjpeg correctly.
2019-12-03 12:05:57 +10:30
Saxon c2c0a576e6 using slice functions from sliceutils package 2019-11-22 17:38:30 +10:30
Saxon ed9f6f5336 fixed typo and also defaulting to CBR for RTMP with geovision 2019-11-22 17:38:30 +10:30
Saxon a6797a929d revid: defaulting to VBR for camera devices
Easiest way to do this is change VBR config field to CBR (therefore CBR defaults to false without having to do anything).
2019-11-22 17:38:30 +10:30
scruzin b4570f1aa1 Use sliceUtils.ContainsString instead of stringInSlice. 2019-11-22 17:19:27 +10:30
scruzin c49e716a59 Added Name to AVDevice. 2019-11-22 10:55:13 +10:30
Trek H 395e8bf278 alsa: increase ring buffer timeout
Removed validate function.
2019-11-16 23:56:18 +10:30
Trek H 4b4b3cb2cb alsa: increase read timeout 2019-11-16 23:47:05 +10:30
Trek H cd63d0d95a alsa: unexported ringbuffer chunksize
Chunksize can be calculated without needing an ALSA device instance.

Added a DataSize function to pcm package for calculating size of pcm data given relevant attributes.

Removed ChunkSize from config revid config struct.

Changed NewByteLexer to accept an in rather than a pointer.
2019-11-13 19:56:13 +10:30
Trek H d7a8d2bd87 Merge branch 'general-pcm' into unexport-chunksize 2019-11-13 17:15:38 +10:30
Trek H f2c9cc5881 alsa: renamed ALSA.buf to ALSA.pb since there are two buffers
Also elaborated on the difference in the comments.
2019-11-13 17:11:35 +10:30
Trek H 796a3b9a97 pcm: changed term clip to buffer 2019-11-13 16:54:41 +10:30
Saxon 91e5e765f5 fix webcam bug and also consider webcam Input var value 2019-11-13 14:11:29 +10:30
Saxon 1a65dc9da4 fixing build errors and testing bugs + removed config_test.go as not relevant anymore 2019-11-13 14:11:29 +10:30
Saxon dec39a3636 revid: now using AVDevice implementations
Also renamed constructors of devices to reduce stutter e.g. raspivid.NewRaspivid to
raspivid.New
2019-11-13 14:11:29 +10:30
Trek H 5e472ba4c9 pcm: refactored to be general not alsa only
Addition of new structs and helper functions for passing around pcm clips/buffers and their formats so that we don't have to import and rely on yobert/alsa code.

Updated any commands and alsa package to use refactored code.
2019-11-12 21:24:08 +10:30
Alan Noble 7da3778485 Fix license hyperlink in comment. 2019-11-12 05:35:01 +00:00
Alan Noble cdc7755634 Fix license hyperlink in comment. 2019-11-12 05:34:16 +00:00
Trek H b6dd737034 device: audio package name changed to alsa
yobert/alsa imports changed to yalsa
directory and file names changed to reflect package name change
2019-11-12 13:28:53 +10:30
Trek H 151ec56fc9 audio: changed comment wording 2019-11-11 22:40:13 +10:30
Trek H c4134fd30e audio: renamed ADPCMDevice to ALSA 2019-11-11 22:26:53 +10:30
Trek H 733785254e audio: renamed AudioDevice to ADPCMDevice 2019-11-11 19:39:10 +10:30
Trek H b66f415e1c audio: renamed Device to AudioDevice 2019-11-11 17:50:46 +10:30
Trek H 78b31c6322 audio: inline syntax for NewDevice 2019-11-11 17:23:15 +10:30
Trek H 4858797d91 audio: moved package from input/audio to device/audio 2019-11-11 16:55:47 +10:30
Saxon 772c381293 device/geovision: renamed gvctrl package to config 2019-11-08 17:29:01 +10:30
Saxon 61b1059205 device/device.go: fixed file header 2019-11-06 17:47:14 +10:30
Saxon 57d73a8d0a created av/device package and sub packages raspivid, geovision, webcam and file
av/device/device.go now contains the AVDevice interface and implementations of this
interface, namely, raspivid, geovision, webcam and file are contained in the packages
av/device/raspivid, av/device/geovision, av/device/webcam and av/device/file
respctively. config.go and testing was also moved to a new package called config.go in
order to remove would be circular dependency between AVDevice implementations and revid.
Modifications were made elsewhere expecting config.Config to be part of the revid package.
2019-11-06 17:44:50 +10:30