Commit Graph

2126 Commits

Author SHA1 Message Date
Vladimir Mihailenco 69ae6ddc00
Merge pull request #2184 from ash2k/remove-iterator-mutex
fix: remove iterator mutex as it's not needed
2022-08-13 12:15:33 +03:00
Mikhail Mazurskiy a10bc3e21c
fix: remove iterator mutex as it's not needed
It's not safe to concurrently use an iterator even with a mutex.
2022-08-13 11:05:04 +10:00
Vladimir Mihailenco 9be4a9e6d3 chore: fix some command names 2022-08-08 10:28:46 +03:00
Vladimir Mihailenco 5a806ca2ba
Merge pull request #2180 from armsnyder/vet-tool
test: vet that all Cmders have a SetVal() method
2022-08-08 10:03:42 +03:00
Vladimir Mihailenco b4a0726f55
Merge pull request #2179 from armsnyder/add-missing-set-val
feat: add some missing SetVal methods
2022-08-08 10:02:07 +03:00
Adam Snyder faa496ba7d test: vet that all Cmders have a SetVal() method 2022-08-07 22:40:51 -07:00
Adam Snyder 3f8edc686f feat: add some missing SetVal methods 2022-08-07 22:36:49 -07:00
Vladimir Mihailenco 084c0c8914
Merge pull request #2174 from j178/master
Remove duplicate safe & unsafe
2022-08-02 08:50:01 +03:00
jianghang b50b1c8f7a chore(internal): remove duplicate safe & unsafe 2022-08-02 00:11:40 +08:00
Vladimir Mihailenco ce016ed85f
Merge pull request #2173 from go-redis/fix/cluster-slots-redis-7
fix: fix ClusterSlots to read full metadata
2022-07-29 14:43:43 +03:00
Vladimir Mihailenco 2aeddfaa28 fix: fix ClusterSlots to read full metadata 2022-07-29 14:28:22 +03:00
Vladimir Mihailenco 2fdda42e7b
Merge pull request #2172 from go-redis/release/v9.0.0-beta.2
chore: release v9.0.0-beta.2 (release.sh)
2022-07-28 16:04:33 +03:00
Vladimir Mihailenco 2e174a228f chore: release v9.0.0-beta.2 (release.sh) 2022-07-28 15:40:09 +03:00
Vladimir Mihailenco 3d1e2e5bc8
Merge pull request #2171 from go-redis/fix/cleanup-pool-options
fix: remove conn reaper from the pool and uptrace option names
2022-07-28 15:33:33 +03:00
Vladimir Mihailenco f6a8adc50c fix: remove conn reaper from the pool and uptrace option names 2022-07-28 15:17:59 +03:00
Vladimir Mihailenco ae6c6deaf4
Merge pull request #2141 from ash2k/ash2k/fix-test-panic
fix: don't panic when test cannot start
2022-07-28 14:28:25 +03:00
Vladimir Mihailenco 60081bdd55
Merge pull request #2148 from signalfx/cluster-pipeline-err
fix: additional node failures in clustered pipelined reads
2022-07-28 13:27:22 +03:00
Vladimir Mihailenco f99baf4fed
Merge pull request #2153 from kavu/fix/2126_ringshards_panic
fix: Handle panic in ringShards Hash function when Ring got closed
2022-07-28 13:25:06 +03:00
Vladimir Mihailenco 1492628ad0
Merge pull request #2157 from kavu/fix/ring_heartbeat_leak
fix: provide a signal channel to end heartbeat goroutine
2022-07-28 13:23:32 +03:00
Vladimir Mihailenco 6343311c4a
Merge pull request #2166 from go-redis/dependabot/go_modules/github.com/onsi/gomega-1.20.0
chore(deps): bump github.com/onsi/gomega from 1.19.0 to 1.20.0
2022-07-28 13:18:40 +03:00
dependabot[bot] 2be58234e3
chore(deps): bump github.com/onsi/gomega from 1.19.0 to 1.20.0
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.19.0 to 1.20.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/gomega/compare/v1.19.0...v1.20.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-07-25 01:30:21 +00:00
Mikhail Mazurskiy 9e16c79951
fix: don't panic when test cannot start 2022-07-21 20:10:08 +10:00
Max Riveiro 20d0ca235e fix: replace heartbeat signal channel with context.WithCancel 2022-07-20 12:20:03 +03:00
Max Riveiro f032c126db fix: provide a signal channel to end heartbeat goroutine 2022-07-14 22:58:53 +03:00
Knut Zuidema e061db8c13
refactor: remove unused context attributes (#2154)
* refactor: remove unused context field
2022-07-14 13:43:42 +03:00
Max Riveiro a80b84f01f fix: handle panic in ringShards Hash function when Ring got closed
Fixes #2126
2022-07-13 18:09:42 +03:00
Knut Zuidema 092a692384
refactor: remove unused context attribute from conn (#2150) 2022-07-13 08:49:28 +03:00
Ben Keith 03376a5d9c fix: additional node failures in clustered pipelined reads
This causes a node to be marked as failing if the client is in READONLY mode
and any error occurs that is either a LOADING error (existing behvaior) or
any non-redis error (e.g. connection error, timeout, etc.).  This prevents that
node from being tried again on the next attempt as usually non-redis errors are
a strong indication that that node is not operational or degraded in some way.
2022-07-07 15:09:48 -04:00
Vladimir Mihailenco 9c34c5345f
Merge pull request #2146 from jsha/log-cmdsinfo-error
cluster: log errors from cmdsInfoCache
2022-07-07 09:04:24 +03:00
Jacob Hoffman-Andrews fa4d1ea839 fix: log errors from cmdsInfoCache
Since the error gets swallowed in cmdInfo(), it's important to log it so
it's possible for the user to see what the error was.
2022-07-06 14:58:53 -07:00
Vladimir Mihailenco 9f5aacde23
Merge pull request #2137 from signalfx/latency-errs
Disregard failed Pings in updateLatency() for cluster nodes
2022-07-03 08:55:48 +03:00
Ben Keith 64f972fbea fix: disregard failed pings in updateLatency() for cluster nodes
It is possible that a ping command might fail very quickly due to an
immediate connection refused message or some other server failure
condition. In this case, the derived latency is not reliable and should
not be used to compare this node to other nodes in the cluster.

This change will only count successful Ping commands in the average
latency and in the case of no successful Pings, set the latency to an
arbitrarily high value to make this node have the least priority when
routing by latency.
2022-07-01 11:04:26 -04:00
youseebiggirl 89d6dfe09a
fix: ignore Nil error when reading EntriesRead 2022-06-25 15:11:46 +03:00
Vladimir Mihailenco a40b4f0f69
Merge pull request #2125 from go-redis/dependabot/github_actions/wagoid/commitlint-github-action-5
chore(deps): bump wagoid/commitlint-github-action from 4 to 5
2022-06-20 08:44:19 +03:00
dependabot[bot] 6e561bc5b9
chore(deps): bump wagoid/commitlint-github-action from 4 to 5
Bumps [wagoid/commitlint-github-action](https://github.com/wagoid/commitlint-github-action) from 4 to 5.
- [Release notes](https://github.com/wagoid/commitlint-github-action/releases)
- [Changelog](https://github.com/wagoid/commitlint-github-action/blob/master/CHANGELOG.md)
- [Commits](https://github.com/wagoid/commitlint-github-action/compare/v4...v5)

---
updated-dependencies:
- dependency-name: wagoid/commitlint-github-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-06-20 01:28:00 +00:00
Vladimir Mihailenco 25db55cdc0
Merge pull request #2119 from szyhf/szyhf-patch-1
fix: #2114 for redis-server not support Hello
2022-06-12 10:48:59 +03:00
Back Yu b6d2a92529
fix: #2114 for redis-server not support Hello
Using `strings.HasPrefix` instead of `equal`
2022-06-10 21:19:02 +08:00
Vladimir Mihailenco 4ddd7d1803 chore: remove WithContext 2022-06-05 09:58:05 +03:00
Vladimir Mihailenco 0768a688c6 chore: update readme 2022-06-04 18:20:41 +03:00
Vladimir Mihailenco 53c26684c1
Merge pull request #2112 from go-redis/release/v9.0.0-beta.1
Release/v9.0.0 beta.1
2022-06-04 18:19:49 +03:00
Vladimir Mihailenco 58e087fe08 chore: release v9.0.0-beta.1 (release.sh) 2022-06-04 18:02:11 +03:00
Vladimir Mihailenco 98300d72b9 chore: cleanup 2022-06-04 18:00:44 +03:00
Vladimir Mihailenco 27f0addeb2
Merge pull request #2111 from go-redis/chore/v9
chore: v9
2022-06-04 17:58:40 +03:00
Vladimir Mihailenco a18fad5bd3 chore: v9 2022-06-04 17:42:06 +03:00
Vladimir Mihailenco a8e56a2961
Merge pull request #2110 from go-redis/feat/redis-7
feat: upgrade to Redis 7
2022-06-04 17:38:02 +03:00
Vladimir Mihailenco d09c27e604 feat: upgrade to Redis 7 2022-06-04 17:25:12 +03:00
Vladimir Mihailenco c98c5f0eeb fix: update ChannelWithSubscriptions to accept options 2022-06-04 16:20:10 +03:00
Vladimir Mihailenco f44b325a6d
Merge pull request #2109 from go-redis/fix/build
chore: fix build
2022-06-04 16:19:25 +03:00
Vladimir Mihailenco b0bb514059 fix: update COMMAND parser for Redis 7 2022-06-04 16:07:28 +03:00
Vladimir Mihailenco 3a722be811 fix: fix tests 2022-06-04 15:25:01 +03:00