Commit Graph

1835 Commits

Author SHA1 Message Date
Ben Keith 74fdad907c ClusterSlots Config and ReadOnly
You have to set the ReadOnly flag on the ClusterOptions to make it fall back to
non-master nodes on reads. For non-clustered situations where you have multiple
nodes in a single ClusterSlot, it made the non-master node useless because it would
never route requests to it and if you set ReadOnly=true it would issue a READONLY
command to it, which would fail.

See comment in code for more details.
2021-01-06 12:14:04 -05:00
Vladimir Mihailenco b3e0aa270a
Merge pull request #1589 from williamkinney/maxretry
add disable/-1 comment to max retries
2020-12-29 08:24:24 +02:00
= 9c56dbd862 add disable/-1 comment to max retries 2020-12-28 14:47:46 -08:00
Jiekun 72e5988b6e
Added test setup document in README.md (#1585)
* Added test setup document in README.md

* Fixed typo
2020-12-21 08:55:13 +02:00
Renovate Bot 50541e67f3
Update module go-redis/redis/v8 to v8.4.4 2020-12-16 15:56:09 +00:00
Vladimir Mihailenco 143859e345 Rename 2020-12-16 17:45:06 +02:00
Vladimir Mihailenco 602b106abb go mod tidy 2020-12-16 17:32:17 +02:00
Vladimir Mihailenco e9fef17b52
Merge pull request #1581 from prathik/replica-cmd
Add support to get cluster replica node for a given key
2020-12-16 17:29:41 +02:00
Prathik Rajendran M fd6643daa1 Add support to get cluster replica node for a given key 2020-12-16 16:55:40 +05:30
Vladimir Mihailenco 80d296154f
Merge pull request #1580 from darkyzhou/patch-1
make error message for unreachable sentinels more clear
2020-12-16 10:17:18 +02:00
darkyzhou ea806acb7e
make error message for unreachable sentinels more clear
The original text `all sentinels are unreachable` can sometimes be misleading, making some users think that all of their redis sentinels are down.

But it might not be the reality especially when using kubernetes and specify `c.sentinelAddrs` as the Service's domain. In this case, when the sentinel to which the domain is redirected runs into some errors despite other sentinels running healthily, the original text given by redis client will be confusing and delivering false message!

Just got out of a similar dilemma after checking the source code, feel free to correct me if I am wrong :)
2020-12-15 19:25:31 +08:00
Vladimir Mihailenco 19e561f0f0
Merge pull request #1575 from go-redis/renovate/github.com-onsi-gomega-1.x
Update module onsi/gomega to v1.10.4
2020-12-11 08:43:30 +02:00
Vladimir Mihailenco 8271b88d02
Merge pull request #1578 from go-redis/renovate/go.opentelemetry.io-otel-sdk-0.x
Update module go.opentelemetry.io/otel/sdk to v0.15.0
2020-12-11 08:43:09 +02:00
Renovate Bot 935e3d0806
Update module onsi/gomega to v1.10.4 2020-12-11 06:42:54 +00:00
Vladimir Mihailenco ec7fb0d479
Merge pull request #1535 from go-redis/renovate/github.com-go-redis-redis-v8-8.x
Update module go-redis/redis/v8 to v8.4.2
2020-12-11 08:42:51 +02:00
Renovate Bot a4a55d1e85
Update module go.opentelemetry.io/otel/sdk to v0.15.0 2020-12-11 06:42:12 +00:00
Renovate Bot d082354160
Update module go-redis/redis/v8 to v8.4.2 2020-12-11 06:42:02 +00:00
Vladimir Mihailenco a464b70c06
Merge pull request #1577 from go-redis/renovate/go.opentelemetry.io-otel-0.x
Update module go.opentelemetry.io/otel to v0.15.0
2020-12-11 08:39:47 +02:00
Renovate Bot 59a2ddc589
Update module go.opentelemetry.io/otel to v0.15.0 2020-12-11 05:34:41 +00:00
Vladimir Mihailenco 9cd21762d8 Add link to Redis Mock 2020-12-10 09:19:39 +02:00
Vladimir Mihailenco 50f12a149b
Merge pull request #1574 from go-redis/fix/wait-goroutine-to-finish
Wait for the goroutine to finish
2020-12-06 17:27:38 +02:00
Vladimir Mihailenco 2c9c526023 Wait for the goroutine to finish 2020-12-06 17:09:22 +02:00
Vladimir Mihailenco 2e398ada86
Merge pull request #1572 from go-redis/fix/close-conn-on-context-timeout
Close the conn on context timeout
2020-12-06 11:34:07 +02:00
Vladimir Mihailenco 02ccf05ed0 Close the conn on context timeout 2020-12-06 11:14:07 +02:00
Vladimir Mihailenco 43d9b98d48 Fix race 2020-12-06 10:05:26 +02:00
Vladimir Mihailenco a60ca8bc24
Merge pull request #1564 from git-hulk/fix/data-race-in-sentinel-client
FIX: data race warning in sentinel client since the newConnPool would spawn the new goroutine and use the onFailover at the same time.
2020-12-06 10:03:33 +02:00
AdamKorcz 0d9368cb32 Updated variable names and added build comment 2020-11-30 16:26:51 +00:00
AdamKorcz 309e57583c Added fuzzer 2020-11-30 16:02:50 +00:00
Vladimir Mihailenco 0b9986c43c Update extra 2020-11-21 10:18:39 +02:00
Vladimir Mihailenco 55a8f1a601
Merge pull request #1567 from go-redis/feature/otel-0.14
Update to otel v0.14
2020-11-21 10:12:54 +02:00
Vladimir Mihailenco 3921cd497c Update to otel v0.14 2020-11-21 09:56:52 +02:00
Vladimir Mihailenco 94de9f93b8
Merge pull request #1566 from go-redis/renovate/go.opentelemetry.io-otel-sdk-0.x
Update module go.opentelemetry.io/otel/sdk to v0.14.0
2020-11-21 09:31:32 +02:00
Renovate Bot 416035e9c9
Update module go.opentelemetry.io/otel/sdk to v0.14.0 2020-11-20 17:25:55 +00:00
git-hulk 956f43e3f9 FIX: data race warning in sentinel client since the newConnPool would spawn the new
goroutine and use the onFailover at the same time.
2020-11-19 20:12:56 +08:00
Vladimir Mihailenco 5aedb90a65
Merge pull request #1562 from johejo/golangci-lint_v1.32
Update golangci-lint to v1.32
2020-11-18 17:53:55 +02:00
Vladimir Mihailenco 015c456597 Add funding 2020-11-18 17:44:34 +02:00
Mitsuo Heijo f5a1707d3c Update golangci-lint to v1.32 2020-11-17 23:08:15 +09:00
Vladimir Mihailenco d4f01eda28 go mod tidy 2020-11-17 08:51:42 +02:00
Yanis 4ab19e228a
Add LPOS command (#1556)
* Add LPos
2020-11-17 08:48:46 +02:00
Vladimir Mihailenco 16981c0c00 Tweak name 2020-11-15 14:35:04 +02:00
Vladimir Mihailenco 7bd3bffc5b Merge branch 'master' of github.com:go-redis/redis 2020-11-15 14:31:14 +02:00
Vladimir Mihailenco 13782c03d0 Tweak otel span and attr names 2020-11-15 14:30:27 +02:00
Vladimir Mihailenco b2a1c6ced0
Merge pull request #1557 from wziww/master
CLUSTER_REDIR_UNSTABLE error should be retry
2020-11-12 13:58:37 +02:00
wziww e0aa8939c7 TRYAGAIN error should be retry 2020-11-12 17:47:04 +08:00
Vladimir Mihailenco fa2e0da4e8 Move changelog to docs 2020-11-06 16:54:46 +02:00
Vladimir Mihailenco 51a4ea4358
Merge pull request #1549 from go-redis/feature/retry-overflow
Guard against overflow in retry
2020-10-28 12:01:51 +02:00
Vladimir Mihailenco caee2887e2
Merge pull request #1546 from TwinProduction/master
Add SetEX command
2020-10-28 11:16:46 +02:00
Vladimir Mihailenco f92951b835 Guard against overflow in retry 2020-10-28 11:12:46 +02:00
TwinProduction b2df72a23d Refactor useless lines 2020-10-22 22:51:54 -04:00
TwinProduction cc71f5d293 Add SetEX command 2020-10-22 14:38:36 -04:00