Added a new SentryHook initialization func for setting tags.

This commit is contained in:
Adam Wonak 2015-07-07 11:41:45 -05:00
parent cd321ca94d
commit 8ce3556d31
2 changed files with 45 additions and 2 deletions

View File

@ -2,8 +2,8 @@ package logrus_sentry
import ( import (
"fmt" "fmt"
"time"
"net/http" "net/http"
"time"
"github.com/Sirupsen/logrus" "github.com/Sirupsen/logrus"
"github.com/getsentry/raven-go" "github.com/getsentry/raven-go"
@ -68,7 +68,18 @@ type SentryHook struct {
// and initializes the raven client. // and initializes the raven client.
// This method sets the timeout to 100 milliseconds. // This method sets the timeout to 100 milliseconds.
func NewSentryHook(DSN string, levels []logrus.Level) (*SentryHook, error) { func NewSentryHook(DSN string, levels []logrus.Level) (*SentryHook, error) {
client, err := raven.NewClient(DSN, nil) client, err := raven.New(DSN)
if err != nil {
return nil, err
}
return &SentryHook{100 * time.Millisecond, client, levels}, nil
}
// NewWithTagsSentryHook creates a hook with tags to be added to an instance
// of logger and initializes the raven client. This method sets the timeout to
// 100 milliseconds.
func NewWithTagsSentryHook(DSN string, tags map[string]string, levels []logrus.Level) (*SentryHook, error) {
client, err := raven.NewWithTags(DSN, tags)
if err != nil { if err != nil {
return nil, err return nil, err
} }

View File

@ -6,6 +6,7 @@ import (
"io/ioutil" "io/ioutil"
"net/http" "net/http"
"net/http/httptest" "net/http/httptest"
"reflect"
"strings" "strings"
"testing" "testing"
@ -98,3 +99,34 @@ func TestSentryHandler(t *testing.T) {
} }
}) })
} }
func TestSentryTags(t *testing.T) {
WithTestDSN(t, func(dsn string, pch <-chan *raven.Packet) {
logger := getTestLogger()
tags := map[string]string{
"site": "test",
}
levels := []logrus.Level{
logrus.ErrorLevel,
}
hook, err := NewWithTagsSentryHook(dsn, tags, levels)
if err != nil {
t.Fatal(err.Error())
}
logger.Hooks.Add(hook)
logger.Error(message)
packet := <-pch
expected := raven.Tags{
raven.Tag{
Key: "site",
Value: "test",
},
}
if !reflect.DeepEqual(packet.Tags, expected) {
t.Errorf("message should have been %s, was %s", message, packet.Message)
}
})
}