Merge pull request #1210 from baijum/error-zero-args

If no arguments, return error at once

main.go

@@ -44,7 +44,8 @@ func Open(dialect string, args ...interface{}) (*DB, error) {
 
 	if len(args) == 0 {
 		err = errors.New("invalid database source")
-	} else {
+		return nil, err
+	}
 	var source string
 	var dbSQL sqlCommon
 
@@ -79,7 +80,6 @@ func Open(dialect string, args ...interface{}) (*DB, error) {
 			db.DB().Close()
 		}
 	}
-	}
 
 	return &db, err
 }

main_test.go

@@ -761,6 +761,16 @@ func TestDdlErrors(t *testing.T) {
 	}
 }
 
+func TestOpenWithOneParameter(t *testing.T) {
+	db, err := gorm.Open("dialect")
+	if db != nil {
+		t.Error("Open with one parameter returned non nil for db")
+	}
+	if err == nil {
+		t.Error("Open with one parameter returned err as nil")
+	}
+}
+
 func BenchmarkGorm(b *testing.B) {
 	b.N = 2000
 	for x := 0; x < b.N; x++ {