From b0104943edf50bba6072d18ca91e949ff8d4e3a2 Mon Sep 17 00:00:00 2001
From: Cr <631807682@qq.com>
Date: Sat, 30 Apr 2022 09:57:16 +0800
Subject: [PATCH] fix: callbcak sort when using multiple plugin (#5304)

---
 callbacks.go            |  8 +++++++-
 tests/callbacks_test.go | 35 +++++++++++++++++++++++++++++++++++
 2 files changed, 42 insertions(+), 1 deletion(-)

diff --git a/callbacks.go b/callbacks.go
index f344649e..c060ea70 100644
--- a/callbacks.go
+++ b/callbacks.go
@@ -246,7 +246,13 @@ func sortCallbacks(cs []*callback) (fns []func(*DB), err error) {
 		sortCallback  func(*callback) error
 	)
 	sort.Slice(cs, func(i, j int) bool {
-		return cs[j].before == "*" || cs[j].after == "*"
+		if cs[j].before == "*" && cs[i].before != "*" {
+			return true
+		}
+		if cs[j].after == "*" && cs[i].after != "*" {
+			return true
+		}
+		return false
 	})
 
 	for _, c := range cs {
diff --git a/tests/callbacks_test.go b/tests/callbacks_test.go
index 02765b8c..2bf9496b 100644
--- a/tests/callbacks_test.go
+++ b/tests/callbacks_test.go
@@ -38,6 +38,7 @@ func c2(*gorm.DB) {}
 func c3(*gorm.DB) {}
 func c4(*gorm.DB) {}
 func c5(*gorm.DB) {}
+func c6(*gorm.DB) {}
 
 func TestCallbacks(t *testing.T) {
 	type callback struct {
@@ -168,3 +169,37 @@ func TestCallbacks(t *testing.T) {
 		}
 	}
 }
+
+func TestPluginCallbacks(t *testing.T) {
+	db, _ := gorm.Open(nil, nil)
+	createCallback := db.Callback().Create()
+
+	createCallback.Before("*").Register("plugin_1_fn1", c1)
+	createCallback.After("*").Register("plugin_1_fn2", c2)
+
+	if ok, msg := assertCallbacks(createCallback, []string{"c1", "c2"}); !ok {
+		t.Errorf("callbacks tests failed, got %v", msg)
+	}
+
+	// plugin 2
+	createCallback.Before("*").Register("plugin_2_fn1", c3)
+	if ok, msg := assertCallbacks(createCallback, []string{"c3", "c1", "c2"}); !ok {
+		t.Errorf("callbacks tests failed, got %v", msg)
+	}
+
+	createCallback.After("*").Register("plugin_2_fn2", c4)
+	if ok, msg := assertCallbacks(createCallback, []string{"c3", "c1", "c2", "c4"}); !ok {
+		t.Errorf("callbacks tests failed, got %v", msg)
+	}
+
+	// plugin 3
+	createCallback.Before("*").Register("plugin_3_fn1", c5)
+	if ok, msg := assertCallbacks(createCallback, []string{"c5", "c3", "c1", "c2", "c4"}); !ok {
+		t.Errorf("callbacks tests failed, got %v", msg)
+	}
+
+	createCallback.After("*").Register("plugin_3_fn2", c6)
+	if ok, msg := assertCallbacks(createCallback, []string{"c5", "c3", "c1", "c2", "c4", "c6"}); !ok {
+		t.Errorf("callbacks tests failed, got %v", msg)
+	}
+}