Commit Graph

885 Commits

Author SHA1 Message Date
mattn 4396a38886
Merge pull request #747 from azavorotnii/open_journal_mode
Fix Open() journal mode regression
2019-09-24 10:39:45 +09:00
Andrii Zavorotnii 27d3ed467c Fix typo in "_locking_mode" DSN handling 2019-09-23 14:57:24 -07:00
Andrii Zavorotnii c4a8658099 Fix Open() journal mode regression
[why]
see https://github.com/mattn/go-sqlite3/issues/607

SQLite default journal mode is DELETE, but forcing it on open causes "database is locked"
if other connection exists with WAL mode, for example.

[how]
Don't set DELETE mode if not set in DSN explicitly.

[testing]
Run tests in my project where WAL mode is used.
2019-09-23 14:56:04 -07:00
Andrii Zavorotnii 7e1a61dbcd Fix context cancellation racy handling
[why]
Context cancellation goroutine is not in sync with Next() method lifetime.
It leads to sql.ErrNoRows instead of context.Canceled often (easy to reproduce).
It leads to interruption of next query executed on same connection (harder to reproduce).

[how]
Do query in goroutine, wait when interruption done.

[testing]
Add unit test that reproduces error cases.
2019-09-06 12:15:53 -07:00
Gert-Jan Timmer d3c690956b
Fix memory leak in ExpandedSQL (#738)
Fixes: #733
2019-08-22 14:55:11 +02:00
G.J.R. Timmer e3726ad6eb Fixed operator 2019-08-22 14:53:27 +02:00
G.J.R. Timmer b22da71572 Fix _auth_* parameter check
Fixes: #724
2019-08-22 14:53:27 +02:00
G.J.R. Timmer 2ea5857c0e Closes #597 2019-08-22 10:59:46 +02:00
mattn e24345b069
Merge pull request #734 from gwd/out/fix-libsqlite3-darwin-build
darwin/libsqlite3: Also use the homebrew include path
2019-08-20 00:43:48 +09:00
mattn f4ce3be229
Merge pull request #735 from mahler/master
Issue #651: Fix of typo
2019-08-20 00:43:38 +09:00
= 85bf186e05 Issue #651: Fix of typo
https://github.com/mattn/go-sqlite3/issues/651
2019-08-19 15:53:09 +02:00
George Dunlap f9aab7dda8 darwin/libsqlite3: Also use the homebrew include path
When building on darwin with the `libsqlite3` tag, go-sqlite3 adds the
homebrew library path.  It does not, however, add the homebrew include
path, which means that the MacOS sqlite3 header is used instead.  On
my system, this results in build errors that look like this:

./sqlite3_load_extension.go:25:8: could not determine kind of name for C.sqlite3_enable_load_extension
./sqlite3_load_extension.go:33:8: could not determine kind of name for C.sqlite3_load_extension

Add the homebrew include path as well, so that he header matches the
libraries we're using.

Signed-off-by: George Dunlap <george.dunlap@citrix.com>
2019-08-19 11:27:31 +01:00
mattn d6f416f91c
Merge pull request #732 from mattn/sqlite-amalgamation-3290000
upgrade amalgamation code
2019-07-16 16:15:03 +09:00
Yasuhiro Matsumoto b612a2feea
upgrade amalgamation code 2019-07-16 14:56:09 +09:00
mattn fba062bdb6
Merge pull request #731 from Jason-Cooke/patch-1
docs: fix typo
2019-07-09 13:10:54 +09:00
Jason Cooke 9889b11544
docs: fix typo 2019-07-09 09:09:23 +12:00
mattn 5dd71670cc
Merge pull request #727 from MichaelS11/master
Updated Ping and doTestOpen. Added TestOpenContext and TestFileCopyTruncate
2019-06-20 10:01:18 +09:00
MichaelS11 57484d0899 Updated Ping to return ErrBadConn
Added TestOpenContext
Added TestFileCopyTruncate
Added ping to doTestOpen
2019-06-19 16:50:49 -07:00
mattn c25061c4b7
Merge pull request #725 from auxten/patch-1
Fix typo in readme
2019-06-17 16:04:10 +09:00
auxten 2e7be7d089
Fix typo in readme 2019-06-17 14:29:55 +08:00
mattn 070b17a2fd
Merge pull request #680 from rittneje/improve-faq-in-memory-shared-cache
improve FAQ re: in-memory databases
2019-05-29 17:43:13 +09:00
mattn afa0250ddf
Create FUNDING.yml 2019-05-24 00:19:27 +09:00
mattn 2a192bf782
Merge pull request #716 from mattn/fix-variadic
Fix type of variadic
2019-05-11 01:41:06 +09:00
Yasuhiro Matsumoto 81b9db8126
Fix type of variadic 2019-05-10 23:23:32 +09:00
mattn 5994cc52df
Merge pull request #712 from mattn/sqlite-amalgamation-3280000
upgrade amalgamation code
2019-04-24 18:37:27 +09:00
Yasuhiro Matsumoto 4bbd87b29d
upgrade amalgamation code 2019-04-24 16:55:17 +09:00
mattn 31f5bb843b
Merge pull request #702 from mattn/sqlite-amalgamation-3270200
upgrade amalgamation code
2019-03-15 17:37:29 +09:00
Yasuhiro Matsumoto 93716266ad
upgrade amalgamation code 2019-03-15 16:07:56 +09:00
mattn ad30583d83
Merge pull request #695 from mattn/fix-typo
Fix typo
2019-02-18 02:40:29 +09:00
Yasuhiro Matsumoto eac3a7fd21
Fix typo
[ci skip]
2019-02-18 02:39:13 +09:00
mattn 4cb37250b6
Merge pull request #693 from egonelbre/unify-travis-runs
Unify travis runs
2019-02-11 11:28:46 +09:00
mattn 58039ab376
Merge pull request #692 from mattn/fix-688
Fix 688
2019-02-11 11:20:17 +09:00
Egon Elbre 54fcf30aef Remove separate go build 2019-02-10 21:39:53 +02:00
Egon Elbre 01e5d0e24c Faster travis running 2019-02-10 19:04:48 +02:00
Yasuhiro Matsumoto 4731d0e6ab
Print type of result 2019-02-11 01:36:01 +09:00
Yasuhiro Matsumoto 5e7aedf685
Add test 2019-02-11 00:48:49 +09:00
Dimitri Roche ae5cbb218c
column_type SQLITE_TEXT returned as string by default 2019-02-11 00:48:38 +09:00
Dimitri Roche abc8991d4d
column types text, varchar, *char return as strings:
As opposed to []byte arrays. This brings sqlite closer
in line with other dbs like postgres, allowing downstream
consumers to assume the scanned value is string across underlying
dbs.
2019-02-11 00:48:28 +09:00
Jesse Rittner 062811fcbd more code formatting 2019-01-04 18:57:33 -05:00
Jesse Rittner 2ee07a473f adding additional info to FAQ about in-memory databases 2019-01-04 18:54:34 -05:00
mattn 3fa1c550ff
Merge pull request #679 from pocke/an-a
Fix typo in README
2019-01-05 01:17:12 +09:00
Masataka Pocke Kuwabara 1688b64fb7
Fix typo in README
s/an/a/
2019-01-04 23:55:45 +09:00
mattn 87ac1cb497
Merge pull request #675 from mattn/sqlite-amalgamation-3260000
upgrade amalgamation code
2018-12-18 12:04:05 +09:00
Yasuhiro Matsumoto aa13f26d02
upgrade amalgamation code 2018-12-18 09:11:45 +09:00
mattn 03cb0c0623
Merge pull request #673 from rittneje/revert-671
Revert 671
2018-12-09 01:24:40 +09:00
Jesse Rittner 2fe51daa56 fixed typo 2018-12-08 08:39:01 -05:00
Jesse Rittner 5846e1aa22 adding unit test 2018-12-08 08:31:45 -05:00
Jesse Rittner 291594080b Revert "SQLITE_OPEN_CREATE should be specified for sqlite3_open_v2 if mode is not rw"
This reverts commit 03b96a53ba.
2018-12-08 08:01:50 -05:00
mattn 248a1e667c
Merge pull request #671 from mattn/fix667
SQLITE_OPEN_CREATE should be specified for sqlite3_open_v2 if mode is…
2018-12-07 23:22:43 +09:00
Yasuhiro Matsumoto 03b96a53ba
SQLITE_OPEN_CREATE should be specified for sqlite3_open_v2 if mode is not rw
Fixes #667
Fixes #669
2018-12-07 16:07:16 +09:00