Commit Graph

296 Commits

Author SHA1 Message Date
rittneje 53cff3fceb fix typo in doc comment (#770) 2019-12-17 16:07:49 +09:00
rittneje b4f5cc77d1 add SystemErrno to Error (#740)
* adding SystemErrno to Error, and fixing error logic when open fails

* fix for old versions of libsqlite3 that do not have sqlite3_system_errno defined

* fixing pre-processor logic
2019-12-17 15:58:28 +09:00
mattn 590d44c02b
Merge pull request #744 from azavorotnii/ctx_cancel
Fix context cancellation racy handling
2019-11-19 01:19:53 +09:00
Yasuhiro Matsumoto fc06e55305
Add build constraints for non cgo 2019-11-18 18:03:31 +09:00
Andrii Zavorotnii 27d3ed467c Fix typo in "_locking_mode" DSN handling 2019-09-23 14:57:24 -07:00
Andrii Zavorotnii c4a8658099 Fix Open() journal mode regression
[why]
see https://github.com/mattn/go-sqlite3/issues/607

SQLite default journal mode is DELETE, but forcing it on open causes "database is locked"
if other connection exists with WAL mode, for example.

[how]
Don't set DELETE mode if not set in DSN explicitly.

[testing]
Run tests in my project where WAL mode is used.
2019-09-23 14:56:04 -07:00
Andrii Zavorotnii 7e1a61dbcd Fix context cancellation racy handling
[why]
Context cancellation goroutine is not in sync with Next() method lifetime.
It leads to sql.ErrNoRows instead of context.Canceled often (easy to reproduce).
It leads to interruption of next query executed on same connection (harder to reproduce).

[how]
Do query in goroutine, wait when interruption done.

[testing]
Add unit test that reproduces error cases.
2019-09-06 12:15:53 -07:00
G.J.R. Timmer e3726ad6eb Fixed operator 2019-08-22 14:53:27 +02:00
G.J.R. Timmer b22da71572 Fix _auth_* parameter check
Fixes: #724
2019-08-22 14:53:27 +02:00
= 85bf186e05 Issue #651: Fix of typo
https://github.com/mattn/go-sqlite3/issues/651
2019-08-19 15:53:09 +02:00
Yasuhiro Matsumoto 81b9db8126
Fix type of variadic 2019-05-10 23:23:32 +09:00
Dimitri Roche ae5cbb218c
column_type SQLITE_TEXT returned as string by default 2019-02-11 00:48:38 +09:00
Dimitri Roche abc8991d4d
column types text, varchar, *char return as strings:
As opposed to []byte arrays. This brings sqlite closer
in line with other dbs like postgres, allowing downstream
consumers to assume the scanned value is string across underlying
dbs.
2019-02-11 00:48:28 +09:00
Jesse Rittner 291594080b Revert "SQLITE_OPEN_CREATE should be specified for sqlite3_open_v2 if mode is not rw"
This reverts commit 03b96a53ba.
2018-12-08 08:01:50 -05:00
Yasuhiro Matsumoto 03b96a53ba
SQLITE_OPEN_CREATE should be specified for sqlite3_open_v2 if mode is not rw
Fixes #667
Fixes #669
2018-12-07 16:07:16 +09:00
Yasuhiro Matsumoto 8f4ea282cf
Close db even if sqlite3_open_v2 return non-zero. 2018-12-07 13:13:49 +09:00
mattn 6a9185d7b1
Merge pull request #626 from otoolep/fix_data_race
Fix data race in AutoCommit()
2018-11-22 01:49:42 +09:00
mattn 873ec57005
Merge pull request #643 from akalin/zero-length-blob
Distinguish between NULL and zero-length blobs on query
2018-11-22 01:48:38 +09:00
mattn c880439687
Merge pull request #644 from akalin/fix-pointer-conversion
Clean up blob to byte slice conversion
2018-11-22 01:47:23 +09:00
Mario Trangoni b76b90f754 Fix misspell issues.
See,
$ gometalinter --vendor --disable-all --enable=misspell ./...
sqlite3.go:1379:45⚠️ "succesfully" is a misspelling of "successfully" (misspell)
sqlite3.go:1390:30⚠️ "registerd" is a misspelling of "registered" (misspell)
sqlite3_func_crypt.go:16:27⚠️ "ceasar" is a misspelling of "caesar" (misspell)
sqlite3_func_crypt.go:43:59⚠️ "Ceasar" is a misspelling of "Caesar" (misspell)
sqlite3_opt_userauth_test.go:450:27⚠️ "succesful" is a misspelling of "successful" (misspell)
sqlite3_opt_userauth_test.go:456:27⚠️ "succesful" is a misspelling of "successful" (misspell)
2018-11-21 11:30:42 +01:00
Kevin Burke 6a26e21416
all: fix cgo compile failures on tip
Apparently the cgo typechecks get better on tip, so use C.int instead
of Go integers.

Build tip as part of the Travis build, so we can ensure that any
errors are resolved before they get released to a wider audience.
2018-11-01 20:42:26 -10:00
Mura Li 68e53de11e Rename the wrapper functions to not pollute the sqlite3_* namespace 2018-10-20 23:02:21 +08:00
Mura Li eb08795f52 Add support for sqlite3_unlock_notify 2018-10-20 10:15:13 +08:00
Frederick Akalin 2364b288cc Use GoBytes 2018-09-22 11:29:00 -07:00
Frederick Akalin ab4f1745f3 Fix bug 2018-09-22 11:26:20 -07:00
Yasuhiro Matsumoto c37ebbc6b2
Fix build
Related on #623
2018-09-11 10:29:35 +09:00
mattn 0eec847b70
Merge pull request #623 from graf0/feature/#619
implementation of set_authorizer interface
2018-09-11 09:39:02 +09:00
Philip O'Toole abfacf5684 Fix data race in AutoCommit()
Detected via https://circleci.com/gh/rqlite/rqlite/2223.
2018-08-30 05:47:34 -07:00
Grzegorz Marszałek df0c034d7c clearer const formatting
with comments what const are used for what
2018-08-30 10:25:56 +02:00
Grzegorz Marszałek e30f9ffa3a implementation of set_authorizer interface 2018-08-25 20:25:16 +02:00
AndrewMurrell e20c81b825 Update go doc comments to refer to correct interfaces.
sql.Driver, sql.Conn, sql.Tx sql.Stmt, and sql.Rows are not interfaces.
Updated the comments to refer to the correct interfaces: driver.Driver,
driver.Conn, driver.Tx, driver.Stmt, and driver.Rows.
2018-08-21 20:46:58 -04:00
Collin Van Dyck b3511bfdd7 Ensure that SqliteStmt.closed property is guarded.
Because the closed property of the SQLiteRows's *SqliteStmt
was not guarded, it was causing an issue during context
cancellation.

be424d27ac/sqlite3.go (L1785-L1796)

When a statement is performing a query(), if it determines that
the context has been canceled, it will launch a goroutine that
closes the resulting driver.Rows if it's not already completed.

If the driver.Rows is not done (and the context has been canceled),
it will interrupt the connection and more importantly, perform
a rows.Close(). The method rows.Close() guards the closed bool with
a sync.Mutex to set it to true.

If a reader is reading from the SqliteRow, it will call Next()
and that performs this check:

be424d27ac/sqlite3.go (L1915-L1917)

Because this is not guarded, a data race ensues, and this was
actually caught by the Go race detector recently.

I didn't include a test case here because the fix seemed
straightforward enough and because race conditions are hard
to test for.  It's been verified in another program that this
fixes the issue.  If tests should be provided I'm more than
happy to do so.
2018-07-19 11:16:09 +02:00
Gert-Jan Timmer 62b7bd5f54 fix/118
* Added TestMultiBlobs
* Removed dead code

Fixes #118
2018-06-12 11:06:00 +02:00
Zachary Gramana f268891078 Adds GetFilename (sqlite3_db_filename) to SqliteConn 2018-06-12 10:33:32 +02:00
mattn 4218441e44
Merge pull request #586 from mattn/feature/userauth
Feature/userauth
2018-06-08 10:05:37 +09:00
Gert-Jan Timmer 7337e65c27 ADD: User Authentication Password Encoders
Allow user to choose how to encode passwords with connection string overrides of embedded `sqlite_crypt` function.
2018-06-05 13:45:32 +02:00
Gert-Jan Timmer 11627e4483 Implemented goconvey for User Authentication Tests
Reference #580
2018-06-04 15:50:00 +02:00
Gert-Jan Timmer 0e289439a2 Update User Authentication
* Update bindings
* Add user authentication sql functions

Reference #579
2018-06-01 11:28:04 +02:00
Gert-Jan Timmer 4a33fcc1d2 Stash
[ci skip]
2018-05-31 16:42:03 +02:00
Gert-Jan Timmer 183e7d61d1 UPD: User Authentication
Implemented table check; only activate User Authentication on a database which has no UA enabled.

Closes #582
2018-05-31 14:55:22 +02:00
Lucas Manuel Rodriguez 8d6d326be6 Add nil check in bind and a test 2018-05-30 21:39:01 -03:00
Gert-Jan Timmer 6ae7f98274 ADD: User authentication
* User Authentication Implementation
* Rename file to conform to fileformat `sqlite3_*_omit.go`
* Updated sqlite3-binding.* with new upgrade tool
* Add: callbackRetNil required for error type return because of adding `RegisterFunc`s directly on the connection.
* Add: TestCreateAuthDatabase
2018-05-30 23:48:02 +02:00
Gert-Jan Timmer 42560ec600 Fix: Display of secure_delete error message 2018-05-29 14:57:40 +02:00
Gert-Jan Timmer d6b854186d Fix: Condition of queryOnly Variable 2018-05-29 14:57:25 +02:00
Gert-Jan Timmer 4857d602fe Fix: Connection DSN Keys
* Conform keys to match PRAGMA
* UPD: README
* Fix error of _auto_vacuum
* Fix error of _case_sensitive_like
* Fix error of _locking_mode
* Fix error of _secure_delete
2018-05-29 14:11:49 +02:00
Gert-Jan Timmer 24cbd402e4 ADD: PRAGMA writable_schema 2018-05-29 14:01:33 +02:00
Gert-Jan Timmer cb041405c6 ADD: PRAGMA synchronous 2018-05-29 13:55:31 +02:00
Gert-Jan Timmer 6a80b70b7a Add: PRAGMA secure_delete
ADD: Connection PRAGMA
ADD: Build tag for secure_delete mode: FAST
2018-05-29 13:41:52 +02:00
Gert-Jan Timmer 764e391156 ADD: PRAGMA query_only 2018-05-29 13:29:06 +02:00
Gert-Jan Timmer 9e79299c09 Add: Documentation for opening as Immutable 2018-05-29 13:23:39 +02:00