Commit Graph

828 Commits

Author SHA1 Message Date
Mario Trangoni c46327f585 sqlite3_test.go: Simplify return err 2018-11-21 11:31:05 +01:00
Mario Trangoni b76b90f754 Fix misspell issues.
See,
$ gometalinter --vendor --disable-all --enable=misspell ./...
sqlite3.go:1379:45⚠️ "succesfully" is a misspelling of "successfully" (misspell)
sqlite3.go:1390:30⚠️ "registerd" is a misspelling of "registered" (misspell)
sqlite3_func_crypt.go:16:27⚠️ "ceasar" is a misspelling of "caesar" (misspell)
sqlite3_func_crypt.go:43:59⚠️ "Ceasar" is a misspelling of "Caesar" (misspell)
sqlite3_opt_userauth_test.go:450:27⚠️ "succesful" is a misspelling of "successful" (misspell)
sqlite3_opt_userauth_test.go:456:27⚠️ "succesful" is a misspelling of "successful" (misspell)
2018-11-21 11:30:42 +01:00
mattn 1ef6010539
Merge pull request #664 from bk521234/patch-1
updating Windows TDM-GCC link to properly render
2018-11-18 01:49:37 +09:00
bk521234 76c6ec0516
updating link to properly render
fixing "[here](ttps://sourceforge.net/projects/tdm-gcc/)" to "[here](https://sourceforge.net/projects/tdm-gcc/)".
2018-11-17 09:45:35 -07:00
Yasuhiro Matsumoto eed79b8657
update README.md 2018-11-09 18:53:04 +09:00
mattn 1fc3fd346d
Merge pull request #657 from kevinburke/compile-tip
travis.yml: build Go tip
2018-11-02 16:49:07 +09:00
Kevin Burke 6a26e21416
all: fix cgo compile failures on tip
Apparently the cgo typechecks get better on tip, so use C.int instead
of Go integers.

Build tip as part of the Travis build, so we can ensure that any
errors are resolved before they get released to a wider audience.
2018-11-01 20:42:26 -10:00
mattn c7c4067b79
Merge pull request #655 from typeless/fix-too-large-arrary-error-v2
Fix build failure of incorrect expression for unsafe.Sizeof
2018-10-24 11:40:35 +09:00
Mura Li 576a2cb9f5 Fix build failure of incorrect expression for unsafe.Sizeof 2018-10-24 09:55:24 +08:00
mattn 276457a170
Merge pull request #654 from typeless/fix-too-large-arrary-error
Fix build failure on Windows/386
2018-10-24 10:09:38 +09:00
Mura Li d12a1386ff Fix build failure on Windows/386
The array size exceeds the address space of 32-bit platform.
See https://github.com/mattn/go-sqlite3/issues/238
2018-10-24 00:12:27 +08:00
mattn f3aa5ce899
Merge pull request #439 from typeless/add-unlock-notify
Add support for sqlite3_unlock_notify
2018-10-21 09:58:17 +09:00
Mura Li 68e53de11e Rename the wrapper functions to not pollute the sqlite3_* namespace 2018-10-20 23:02:21 +08:00
Mura Li eb08795f52 Add support for sqlite3_unlock_notify 2018-10-20 10:15:13 +08:00
mattn c67b489f7e
Merge pull request #616 from jung-kurt/patch-1
Update README: URL-encode connection options
2018-10-15 22:44:34 +09:00
mattn 3e1d67a264
Merge pull request #652 from rutsky/patch-1
Remove extra backtick and fix Markdown formatting
2018-10-15 22:43:54 +09:00
mattn a98b6a4af5
Merge pull request #648 from emirb/patch-1
Add Go 1.11 to Travis build matrix
2018-10-15 22:43:41 +09:00
Vladimir Rutsky 2bf2b22523
Remove extra backtick and fix Markdown formatting 2018-10-14 18:56:19 +02:00
mattn 5cd1ba5866
Merge pull request #650 from relud/patch-1
Fix typo in README.md
2018-10-13 10:15:51 +09:00
Daniel Thorn 0ad25499b6
Fix typo in README.md 2018-10-12 13:04:07 -07:00
Emir Beganović 3b73f9366b
Add Go 1.11 to Travis build matrix 2018-10-09 14:54:41 +04:00
mattn 0a88db3545
Merge pull request #645 from mattn/sqlite-amalgamation-3250200
upgrade amalgamation code
2018-09-26 18:02:20 +09:00
Yasuhiro Matsumoto 9cb060a131
upgrade amalgamation code 2018-09-26 17:18:13 +09:00
mattn e85a2792f3
Merge pull request #641 from akalin/fix-test-call
Actually check the value of RunTests
2018-09-25 00:01:02 +09:00
Frederick Akalin 3955886e38 Add fatal message 2018-09-22 11:50:52 -07:00
Frederick Akalin 2364b288cc Use GoBytes 2018-09-22 11:29:00 -07:00
Frederick Akalin ab4f1745f3 Fix bug 2018-09-22 11:26:20 -07:00
Frederick Akalin d61fdcd55b Clean up test 2018-09-22 11:26:20 -07:00
Frederick Akalin 568d682daa Add failing test 2018-09-22 11:26:20 -07:00
Frederick Akalin 25a6a28602 Actually check the value of RunTests 2018-09-22 11:26:08 -07:00
mattn 6de94b0b99
Merge pull request #637 from mattn/fix-build2
Fix build
2018-09-18 18:41:35 +09:00
Yasuhiro Matsumoto eadad87753
Fix build 2018-09-18 17:09:27 +09:00
mattn 89b0dfee1a
Merge pull request #636 from mattn/fix-635
Upgrade to SQLite 3.25.0
2018-09-18 17:07:49 +09:00
Yasuhiro Matsumoto 554bc0fb2e
Upgrade to SQLite 3.25.0
Fixes #634, #635
2018-09-18 17:02:27 +09:00
mattn 593fde6929
Merge pull request #633 from israel-lugo/patch-1
Mention correct algorithm in function docs.
2018-09-16 13:50:09 +09:00
Israel G. Lugo 3598735dae
Mention correct algorithm in function docs.
CryptEncoder SHA384 and SHA512 variants (with and without salt) were incorrectly documented as using SHA256.
2018-09-16 04:01:58 +01:00
mattn 1a378fb5bb
Merge pull request #631 from mattn/fix-build
Fix build
2018-09-11 11:41:34 +09:00
Yasuhiro Matsumoto c71eddf069
icu4c 62.1 already installed 2018-09-11 10:39:41 +09:00
Yasuhiro Matsumoto c37ebbc6b2
Fix build
Related on #623
2018-09-11 10:29:35 +09:00
mattn 0eec847b70
Merge pull request #623 from graf0/feature/#619
implementation of set_authorizer interface
2018-09-11 09:39:02 +09:00
Philip O'Toole abfacf5684 Fix data race in AutoCommit()
Detected via https://circleci.com/gh/rqlite/rqlite/2223.
2018-08-30 05:47:34 -07:00
Grzegorz Marszałek df0c034d7c clearer const formatting
with comments what const are used for what
2018-08-30 10:25:56 +02:00
Grzegorz Marszałek e30f9ffa3a implementation of set_authorizer interface 2018-08-25 20:25:16 +02:00
mattn 3198c7714d
Merge pull request #621 from AndrewMurrell/master
Update go doc comments to refer to correct interfaces.
2018-08-24 23:21:20 +09:00
AndrewMurrell e20c81b825 Update go doc comments to refer to correct interfaces.
sql.Driver, sql.Conn, sql.Tx sql.Stmt, and sql.Rows are not interfaces.
Updated the comments to refer to the correct interfaces: driver.Driver,
driver.Conn, driver.Tx, driver.Stmt, and driver.Rows.
2018-08-21 20:46:58 -04:00
Kurt Jung 0109106b87
Update README: URL-encode connection options
This change could save users from having to dig into source code to see how connection options are parsed.
2018-08-12 08:34:51 -04:00
Collin Van Dyck b3511bfdd7 Ensure that SqliteStmt.closed property is guarded.
Because the closed property of the SQLiteRows's *SqliteStmt
was not guarded, it was causing an issue during context
cancellation.

be424d27ac/sqlite3.go (L1785-L1796)

When a statement is performing a query(), if it determines that
the context has been canceled, it will launch a goroutine that
closes the resulting driver.Rows if it's not already completed.

If the driver.Rows is not done (and the context has been canceled),
it will interrupt the connection and more importantly, perform
a rows.Close(). The method rows.Close() guards the closed bool with
a sync.Mutex to set it to true.

If a reader is reading from the SqliteRow, it will call Next()
and that performs this check:

be424d27ac/sqlite3.go (L1915-L1917)

Because this is not guarded, a data race ensues, and this was
actually caught by the Go race detector recently.

I didn't include a test case here because the fix seemed
straightforward enough and because race conditions are hard
to test for.  It's been verified in another program that this
fixes the issue.  If tests should be provided I'm more than
happy to do so.
2018-07-19 11:16:09 +02:00
Ingve Vormestrand 3aefd9f0a1 Fix typo in readme 2018-07-02 20:40:57 +02:00
Gert-Jan Timmer f08fefa53a fix/306
* ppc
* ppc64
* ppc64le
2018-06-28 11:44:40 +02:00
Gert-Jan Timmer a3114e1a2c fix/306
Add: -lpthread for ppc / ppc64

Issue: #306

[ci ckip]
2018-06-28 11:44:40 +02:00