From b4c8bf1bbe1bf7109c663d34839357341b0d9392 Mon Sep 17 00:00:00 2001
From: Bo-Yi Wu <appleboy.tw@gmail.com>
Date: Sun, 17 May 2020 18:11:22 +0800
Subject: [PATCH] chore(performance): improve countParams (#2378)

* update

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>

* chore: update

* chore: improve countParams performance

* update

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>

* chore: add comment
---
 tree.go | 45 +++++++++++++++++++++++++++++++++++++--------
 1 file changed, 37 insertions(+), 8 deletions(-)

diff --git a/tree.go b/tree.go
index f528fa3b..18ada811 100644
--- a/tree.go
+++ b/tree.go
@@ -5,10 +5,18 @@
 package gin
 
 import (
+	"bytes"
 	"net/url"
+	"reflect"
 	"strings"
 	"unicode"
 	"unicode/utf8"
+	"unsafe"
+)
+
+var (
+	strColon = []byte(":")
+	strStar  = []byte("*")
 )
 
 // Param is a single URL parameter, consisting of a key and a value.
@@ -72,14 +80,35 @@ func longestCommonPrefix(a, b string) int {
 	return i
 }
 
+// bytesToStr converts byte slice to a string without memory allocation.
+// See https://groups.google.com/forum/#!msg/Golang-Nuts/ENgbUzYvCuU/90yGx7GUAgAJ .
+//
+// Note it may break if string and/or slice header will change
+// in the future go versions.
+func bytesToStr(b []byte) string {
+	return *(*string)(unsafe.Pointer(&b))
+}
+
+// strToBytes converts string to a byte slice without memory allocation.
+//
+// Note it may break if string and/or slice header will change
+// in the future go versions.
+func strToBytes(s string) (b []byte) {
+	/* #nosec G103 */
+	bh := (*reflect.SliceHeader)(unsafe.Pointer(&b))
+	/* #nosec G103 */
+	sh := *(*reflect.StringHeader)(unsafe.Pointer(&s))
+	bh.Data = sh.Data
+	bh.Len = sh.Len
+	bh.Cap = sh.Len
+	return b
+}
+
 func countParams(path string) uint16 {
 	var n uint
-	for i := range []byte(path) {
-		switch path[i] {
-		case ':', '*':
-			n++
-		}
-	}
+	s := strToBytes(path)
+	n += uint(bytes.Count(s, strColon))
+	n += uint(bytes.Count(s, strStar))
 	return uint16(n)
 }
 
@@ -163,7 +192,7 @@ walk:
 
 			n.children = []*node{&child}
 			// []byte for proper unicode char conversion, see #65
-			n.indices = string([]byte{n.path[i]})
+			n.indices = bytesToStr([]byte{n.path[i]})
 			n.path = path[:i]
 			n.handlers = nil
 			n.wildChild = false
@@ -223,7 +252,7 @@ walk:
 			// Otherwise insert it
 			if c != ':' && c != '*' {
 				// []byte for proper unicode char conversion, see #65
-				n.indices += string([]byte{c})
+				n.indices += bytesToStr([]byte{c})
 				child := &node{
 					fullPath: fullPath,
 				}