re
/
enumer
forked from mirror/enumer
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Implement Scan with a type switch 

This is just a minor (and a bit opinionated) tweak in Scan. While using
the generated Scan method, realized that what's being returned from any
driver I've stumbled upon is actually []byte instead of string, thus
always causing a one failed type assertion on Scan.
This commit is contained in:
Kiril Vladimiroff 2020-03-05 16:18:52 +02:00
parent d46c853929
commit 78ada3fc29
No known key found for this signature in database
GPG Key ID: E8AC87A89B24A670
2 changed files with 31 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
golden_test.go
View File

@ -1682,14 +1682,16 @@ func (i *Prime) Scan(value interface{}) error {
return nil
}
str, ok := value.(string)
if !ok {
bytes, ok := value.([]byte)
if !ok {
return fmt.Errorf("value is not a byte slice")
}
str = string(bytes[:])
var str string
switch v := value.(type) {
case []byte:
str = string(b)
case string:
str = v
case fmt.Stringer:
str = v.String()
default:
return fmt.Errorf("invalid value of Prime: %[1]T(%[1]v)", value)
}
val, err := PrimeString(str)
@ -1867,14 +1869,16 @@ func (i *Prime) Scan(value interface{}) error {
return nil
}
str, ok := value.(string)
if !ok {
bytes, ok := value.([]byte)
if !ok {
return fmt.Errorf("value is not a byte slice")
}
str = string(bytes[:])
var str string
switch v := value.(type) {
case []byte:
str = string(b)
case string:
str = v
case fmt.Stringer:
str = v.String()
default:
return fmt.Errorf("invalid value of Prime: %[1]T(%[1]v)", value)
}
val, err := PrimeString(str)

18
sql.go
View File

@ -12,14 +12,16 @@ const scanMethod = `func (i *%[1]s) Scan(value interface{}) error {
return nil
}
str, ok := value.(string)
if !ok {
bytes, ok := value.([]byte)
if !ok {
return fmt.Errorf("value is not a byte slice")
}
str = string(bytes[:])
var str string
switch v := value.(type) {
case []byte:
str = string(b)
case string:
str = v
case fmt.Stringer:
str = v.String()
default:
return fmt.Errorf("invalid value of %[1]s: %%[1]T(%%[1]v)", value)
}
val, err := %[1]sString(str)