re
/
cobra
forked from mirror/cobra
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
902 Commits 3 Branches 21 Tags 12 MiB
Commit Graph

902 Commits

Author SHA1 Message Date
Albert Nigmatzianov 6202b5942b Refactor flags mechanisms 
I think It's more obvious now to understand the inheritance of flags.

Fix #403
Fix #404

Performance improvements:
benchmark                     old ns/op     new ns/op     delta
BenchmarkInheritedFlags-4     6536          5595          -14.40%
BenchmarkLocalFlags-4         3193          3235          +1.32%

benchmark                     old allocs     new allocs     delta
BenchmarkInheritedFlags-4     49             39             -20.41%
BenchmarkLocalFlags-4         23             21             -8.70%

benchmark                     old bytes     new bytes     delta
BenchmarkInheritedFlags-4     2040          1000          -50.98%
BenchmarkLocalFlags-4         1008          544           -46.03%
 2017-04-20 15:38:50 +02:00
Elliot Morrison-Reed a3cd8ab85a Use os.Getenv("HOME") instead of "$HOME" for windows compatibility (#337) 2017-04-20 15:35:06 +02:00
Albert Nigmatzianov b655df6ce8 Get rid of flagErrorBuf (#417) 
Fix #27
 2017-04-19 09:23:43 -04:00
Albert Nigmatzianov f95d58bdf3 Fix #401 (#402) 
* doc: Add and edit docs

* doc: Add tests
 2017-04-19 14:39:58 +02:00
Théotime Lévêque b6cb395893 Fix typo in docstring (#360) 2017-04-17 19:03:07 +02:00
korya 0a0df1e881 Use valid exit code value in `os.Exit` call (#405) 
Exit code value range is 0-255. I think the examples in the main README document should be valid both syntactically and semantically.
 2017-04-17 19:02:17 +02:00
Albert Nigmatzianov 9350054794 Keep only one newline between Aliases and Flags in help (#410) 
Fix #409
 2017-04-17 18:55:55 +02:00
tomerf 5deb57bbca Fixed completion of dash parameters arguments (#415) 2017-04-08 10:45:37 -04:00
Tamir Duberstein 7aeaa2cce6 Avoid storing pointer to nil (#411) 
* Fix shellcheck

Before this change:

	In - line 204:
	    declare -F $next_command >/dev/null && $next_command
	               ^-- SC2086: Double quote to prevent globbing and word splitting.

	--- FAIL: TestBashCompletions (0.34s)
		bash_completions_test.go:138: shellcheck failed: exit status 1

* Avoid storing pointer to nil

Before this change, the new test fails with:

	--- FAIL: TestSetOutput (0.00s)
		command_test.go:198: expected setting output to nil to revert back to stdout, got <nil>
 2017-04-02 10:14:34 -04:00
Albert Nigmatzianov 6421115516 doc: Fix govet complaints (#408) 2017-04-01 15:45:39 -05:00
Tamir Duberstein 7be4beda01 remove help command before adding it (#399) 
This fixes an issue where each Execute call grows the number of times
`help` appears in the help command by 1.
 2017-03-14 12:12:53 -05:00
Sebastiaan van Stijn 16c014f1a1 Add "docker" to readme 
Docker (https://github.com/docker/docker) now
also uses Cobra for the CLI. A majority of the
commands have been migrated (still some left),
but adding it already :)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2017-03-09 10:45:09 -05:00
Albert Nigmatzianov 0960ff7fa9 Rename IsHelpCommand to IsAdditionalHelpTopicCommand (#398) 
Fixes #393
 2017-03-09 10:37:15 -05:00
Nikola Kovacs 24bb44aac8 Fix SilenceUsage and SilenceErrors in readme (#397) 
You have to set them to true to silence the default output, not false.
 2017-03-08 14:37:25 -05:00
Albert Nigmatzianov fcd0c5a1df Some fixes related to help command (#394) 
* Add dots in the end of docs

* Make UsageTemplate show help command

Fix #366

* Fix output of help if it's invalid command
 2017-02-28 14:17:48 -05:00
Eric Paris 92ea23a837 Fix subcommand locations with NoOptDefValue flags (#391) 
If one ran a command like

./root --boolFlag subcmd1 subcmd2

Thing worked fine. The code recognized that --boolFlag followed by a
space meant the next word was not the argument to --boolFlag. But other
flag types with a NoOptDefValue (like a Count flag) would not ignore the
"argument".  On a command like:

./root --countflag subcmd1 subcmd2

The processor, when looking for a subcommand, would first throw out the
`--countflag subcmd1` and then look for subcmd2 under root.

The fix is to ignore the next word after any NoOptDefVal flag, not just
boolean flags.
 2017-02-23 08:12:51 -05:00
Bjørn Erik Pedersen ee4055870c Update the Travis Go versions 2017-02-17 17:45:07 +01:00
Di Xu b5d8e8f46a cache command name (#390) 2017-02-09 11:54:17 -05:00
Daniel Nephin 99600f6874 Add a tags field for user defined tags on a Command. (#359) 
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
 2017-02-07 16:20:48 -05:00
French Ben 35136c09d8 Added support for yaml ouptut in docs gen (#380) 
Signed-off-by: French Ben <frenchben@docker.com>
 2017-01-30 16:45:31 -05:00
Vincent Batts c29ece4386 Go vet (#345) 
* bash_completions: cleanup for go vet

The gnarly block of string in the Fprint tripped up go vet and was not
easy to read.

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

* test: cleanup for go vet

Looks like copy'pasta and an unused variable

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
 2017-01-26 14:32:19 -05:00
Oleg Atamanenko 0f056af21f Added godocs to public methods. (#386) 
* Added godocs to public methods.

* Fix gofmt formatting.
 2017-01-24 11:30:45 -05:00
Apurva Chitnis dc208f4211 Added useful info for setting up bash autocompletion. (#384) 2017-01-18 13:55:16 -05:00
Raphael 'kena' Poss 1dd5ff2e11 Make SEE ALSO references and generated file names agree with each other. 2016-12-29 00:59:22 -07:00
Philipp Muens de09d9ce07 Update README with missing import statements (#373) 2016-12-22 10:12:50 -05:00
Qinglan Peng b62566898a fmt package should be imported (#370) 
Signed-off-by: Qinglan Peng <qinglanpeng@zju.edu.cn>
 2016-12-14 10:19:52 -05:00
Yuanxiao 9495bc009a echo msg not echo msg msg (#364) 2016-11-16 08:20:53 -05:00
Julien Kassar 6b74a60562 Update doc/man_docs.md (#363) 2016-11-15 09:16:05 -05:00
Ben Gadbois 6e91dded25 Make gofmt -s pass (#355) 2016-10-25 18:28:26 -07:00
Eric Paris 856b96dcb4 Merge pull request #353 from bogem/helpfunc 
Fix condition in HelpFunc
 2016-10-14 18:20:36 -04:00
bogem 011f19e8ec Fix condition in HelpFunc 
I think, it's more obvious, what does this method
 2016-10-14 20:34:35 +02:00
Eric Paris ec2fe78599 Merge pull request #286 from dnephin/merge_flags_before_adding_help 
Merge persistent flags before checking for a help flag
 2016-10-10 11:14:18 -04:00
Eric Paris b620a7591d Merge pull request #283 from dnephin/add_flag_usage_func 
Add support for setting a function to handle flag parsing errors
 2016-10-10 11:13:51 -04:00
Daniel Nephin 67feb8173c Add support for setting a function to handle flag parsing errors. 
The default pflag error is to only print the bad flag. This enables an application
to include a usage message or other details about the error.

Signed-off-by: Daniel Nephin <dnephin@gmail.com>
 2016-10-10 10:56:48 -04:00
Eric Paris 9c28e4bbd7 Merge pull request #339 from bogem/fixes 
Some fixes
 2016-08-30 13:49:25 -04:00
bogem 5da98880f3 Edit documentation 2016-08-30 22:14:27 +05:00
bogem 101d434d44 Simplify OnInitialize func 2016-08-30 21:58:52 +05:00
bogem 71a9c0834b Simplify condition with err 2016-08-30 21:57:12 +05:00
Eric Paris d671d98363 Merge pull request #338 from icaoweiwei/patch-2016-08-29-2 
Fix typo
 2016-08-30 11:26:59 -04:00
Cao Weiwei 4a087062c6 Fix typo 
Signed-off-by: Cao Weiwei <cao.weiwei30@zte.com.cn>
 2016-08-29 00:18:06 +08:00
Eric Paris 37c3f80603 Merge pull request #332 from broady/master 
travis: fix build matrix config
 2016-08-23 17:51:50 -04:00
Chris Broadfoot ed0a8cae34 travis: fix build matrix config 2016-08-23 13:41:01 -07:00
Eric Paris 8e9c5e77eb Merge pull request #331 from broady/fmtetc 
gofmt, govet, run those in Travis
 2016-08-23 16:37:01 -04:00
Chris Broadfoot d1371ecdb4 gofmt, govet, run those in Travis, add 1.7 2016-08-23 13:30:43 -07:00
Eric Paris 1f4717172e Merge pull request #327 from bogem/fixes 
Some small fixes
 2016-08-22 09:59:44 -04:00
bogem 6e17f4e2c5 Fix typos 2016-08-20 12:04:53 +05:00
bogem ec452170d2 Fix error messages in cobra_test 2016-08-20 12:02:26 +05:00
Eric Paris 7c674d9e72 Merge pull request #313 from euank/swift-as-a-cobra-hidden-as-a-ninja 
Display neither hidden nor deprecated flags in bash completion
 2016-08-02 18:37:37 -04:00
Euan Kemp 40e19b3f3b Don't display deprecated flags in bash completions 2016-08-02 15:01:33 -07:00
Euan Kemp 75daccd5b8 Don't display hidden flags in bash completions 2016-08-02 14:49:33 -07:00