re
/
cobra
forked from mirror/cobra
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
663 Commits 3 Branches 21 Tags 12 MiB
Commit Graph

13 Commits

Author SHA1 Message Date
Haim Ashkenazi 66a98807d4 zsh-completion: test to verify that we're always running on root cmd. 2019-06-07 10:09:50 -04:00
Haim Ashkenazi 7b62c7df78 zsh-completion: --version and --help still doesn't work correctly 
When invoking from subcommand. Modified the test to prove.
 2019-06-07 10:09:50 -04:00
Haim Ashkenazi 7ce08e227e zsh-completion: completion should always parse the root command! 
It was running on the command it was invoked from which caused some
additional helpers (--help, --version) not to be generated.
 2019-06-07 10:09:50 -04:00
Haim Ashkenazi 91e80cc4a4 zsh-completion: remove bad test 
I thought there was a bug in the boolSlice definition but it seems
It was my mistake in identifying what's going on. Also removed the
provisioning to skip tests (doesn't seem to be needed anymore).
 2019-06-07 10:09:50 -04:00
Haim Ashkenazi 50f385938e zsh-completion: added support for filename globbing. 2019-06-07 10:09:50 -04:00
Haim Ashkenazi df12a0a249 zsh-completion: two fixes for identifying flag usage: 
Fixed after input from @eparis:
- Decide on option parameter by checking NoOptDefVal
- Slices also could be specified multiple times.
 2019-06-07 10:09:50 -04:00
Haim Ashkenazi ec4b8c974c zsh-completions: revised flags completion rendering + new features: 
- If the flags are not bool the completion expects argument.
- You don't have to specify file extensions for file completion to
  work.
- Allow multiple occurrences of flag if type is stringArray.

Need to verify that these assumption are correct :)
 2019-06-07 10:09:50 -04:00
Haim Ashkenazi 2662787697 zsh-completion: added support for subcommand description. 
Also make the template more elegant on the way...
 2019-06-07 10:09:50 -04:00
Haim Ashkenazi f0508c8e76 zsh-completion ignores hidden commands and flags :) 2019-06-07 10:09:50 -04:00
Haim Ashkenazi a15d099018 zsh-completion fixed reference to cmd name 
cmd.Use is not the command name :). Found it once I figured out
that I need to execute the command in order to fully test the
generated completion.
 2019-06-07 10:09:50 -04:00
Haim Ashkenazi 7e2436b79d First try at better zsh completions: 
A very basic POC. Need to refactor to generate completion
structure before passing to the template to avoid repeated
computations.

What works:
  * Real zsh completion (not built on bash)
  * Basic flags (with long flag and optional shorthand)
  * Basic filename completion indication (not with file extensions though)

What's missing:
  * File extensions to filename completions
  * Positional args
  * Do we require handling only short flags?
 2019-06-07 10:09:50 -04:00
Albert Nigmatzianov 65c8acb228 Improve tests 2017-11-09 07:56:43 +01:00
bpicode d7ba19510d Add basic zsh completion (command hierarchy only) 
Partially fixes #107
See PR #497
 2017-07-30 02:44:28 -06:00