30503fe98e
Exposes bug #498 - unexpected results for Histograms in testutil
...
Signed-off-by: PhilipGough <philip.p.gough@gmail.com>
2018-11-14 11:58:43 +00:00
ca9acd2391
Merge pull request #497 from prometheus/beorn7/testing
...
Fix testutil metric comparison
2018-11-13 16:56:41 +01:00
86702ea6b4
Fix metric comparison for empty labels
...
reflect.DeepEqual is not suitable for zero occurrences of repeated
proto messages. This changes the comparison to act on the string
representation of proto messages.
Signed-off-by: beorn7 <beorn@soundcloud.com>
2018-11-13 16:25:02 +01:00
1db43792db
Expose bug #494
...
Signed-off-by: beorn7 <beorn@soundcloud.com>
2018-11-13 15:48:48 +01:00
abad2d1bd4
Merge pull request #490 from prometheus/beorn7/release
...
Cut v0.9.1
2018-11-03 15:23:28 +01:00
8aa7f38ed0
Cut v0.9.1
...
This is only adding good things, not really a "patch" release, but our
pre-1.0 versioning semantics is explained in the README.md.
Signed-off-by: beorn7 <beorn@soundcloud.com>
2018-11-02 20:09:09 +01:00
da11cf2c83
Merge pull request #488 from peterj/master
...
Add more info to the inconsistent cardinality errors
2018-11-02 19:52:54 +01:00
1444b917ab
Merge pull request #489 from sevagh/master
...
WriteToTextfile function for node exporter textfiles
2018-11-02 19:44:36 +01:00
88f4223778
Fix permissions of tempfile
...
Signed-off-by: Sevag Hanssian <sevag.hanssian@gmail.com>
2018-11-02 09:59:03 -07:00
f1bec54758
Update the ExampleRegister test
...
Signed-off-by: Peter Jausovec <peter.jausovec@oracle.com>
2018-11-02 09:46:03 -07:00
924d5919f3
Improve WriteToTextfile doc
...
Signed-off-by: Sevag Hanssian <sevag.hanssian@gmail.com>
2018-11-02 09:31:41 -07:00
b686a9e02e
Remove fmt from import
...
Signed-off-by: Peter Jausovec <peter.jausovec@oracle.com>
2018-11-02 09:21:12 -07:00
ea348d7c20
Update code based on the PR feedback
...
Signed-off-by: Peter Jausovec <peter.jausovec@oracle.com>
2018-11-02 09:01:14 -07:00
42e6616334
Use code that already existed
...
Signed-off-by: Sevag Hanssian <sevag.hanssian@gmail.com>
2018-11-02 08:37:26 -07:00
1d54dabd43
Add WriteToTextfile test
...
Signed-off-by: Sevag Hanssian <sevag.hanssian@gmail.com>
2018-10-31 23:34:50 -07:00
c5bdd15ac3
Remove typo
...
Signed-off-by: Sevag Hanssian <sevag.hanssian@gmail.com>
2018-10-31 15:31:42 -07:00
e6fe89ce22
Add support for histograms and summaries
...
Signed-off-by: Sevag Hanssian <sevag.hanssian@gmail.com>
2018-10-31 15:27:11 -07:00
9416ff209b
First commit - WriteToTextfile
...
Signed-off-by: Sevag Hanssian <sevag.hanssian@gmail.com>
2018-10-31 14:22:11 -07:00
ceb819208d
copy/pasta error
...
Signed-off-by: Peter Jausovec <peter.jausovec@oracle.com>
2018-10-31 11:16:16 -07:00
4fe949f2fd
Add missing fmt import
...
Signed-off-by: Peter Jausovec <peter.jausovec@oracle.com>
2018-10-31 11:09:12 -07:00
902733d080
Add more info to the inconsistent cardinality errors
...
Signed-off-by: Peter Jausovec <peter.jausovec@oracle.com>
2018-10-31 11:01:42 -07:00
f30f428035
Add a way to return the body of a 5xx response. ( #484 )
...
expose body when handling HTTP errors
Signed-off-by: Marcin Owsiany <marcin@owsiany.pl>
2018-10-25 18:44:21 +01:00
16f375c74d
Merge pull request #482 from prometheus/beorn7/http
...
Use gzip from a pool and stream while encoding metrics
2018-10-22 13:47:59 +02:00
fb0f7fe8c2
Pull up HTTP changes into deprecated functions
...
So that also users of those can benefit. Obviously, we will end
updating deprecated functions one day (at latest once v0.10 is out).
Signed-off-by: beorn7 <beorn@soundcloud.com>
2018-10-22 12:36:33 +02:00
62361fc0fb
Use streaming encoding of metrics
...
Signed-off-by: beorn7 <beorn@soundcloud.com>
2018-10-22 01:04:52 +02:00
752f50d366
Merge branch 'use-gzip-pool' of github.com:glefloch/client_golang into beorn7/http
2018-10-20 00:51:31 +02:00
c2c6fd2ab4
Fix PR comments
...
Signed-off-by: glefloch <glfloch@gmail.com>
2018-10-19 13:51:45 +02:00
fdf4cbc87b
Use sync.Pool for gzipWriter
...
Signed-off-by: glefloch <glfloch@gmail.com>
2018-10-17 13:17:33 +02:00
1cafe34db7
Merge pull request #480 from prometheus/beorn7/release
...
Release v0.9.0
2018-10-15 16:52:39 +02:00
b2c0ab4f6e
Release v0.9.0
...
This ends a long time of not really tagging versions (as it didn't
make a lot of sense - we could have tagged every commit with a new
minor release essentially). I still worked through the git log and GH
issues to create a nice CHANGELOG.md.
As dependency management tools really love version tags these days, I
plan to tag more often from now on. The ideas behind the pre-1.0
version numbers are explained in the README.md as changed in this
commit.
I also changed the issue template accordingly.
Signed-off-by: beorn7 <beorn@soundcloud.com>
2018-10-15 13:28:28 +02:00
0b47a5c709
Move ISSUE_TEMPLATE into .github directory
...
Much less confusing...
Signed-off-by: beorn7 <beorn@soundcloud.com>
2018-10-14 23:36:14 +02:00
7866eead36
Merge pull request #478 from prometheus/beorn7/testing2
...
Add a concurrent end-to-end test for observe-register-gather
2018-10-10 18:13:31 +02:00
5e8ac3cd58
Add a concurrent end-to-end test for observe-register-gather
...
This is an attempt to expose
https://github.com/istio/istio/issues/8906 . The failure to do so
makes me believe the error is either already fixed in current
client_golang, or something weird I haven't spotted yet is happening
in the istio code.
Signed-off-by: beorn7 <beorn@soundcloud.com>
2018-10-10 16:59:24 +02:00
e5d4a249c9
Adjust TestRegisterWithOrGet to the present ( #477 )
...
Signed-off-by: beorn7 <beorn@soundcloud.com>
2018-10-10 16:58:48 +02:00
93edea3720
Do not parse json on 204 responses ( #476 )
...
* Do not return BadResponse for no content
Signed-off-by: Adam Jaso <2285656+adamjaso@users.noreply.github.com>
2018-10-10 17:20:17 +03:00
e1fb14a776
Adjust TestRegisterWithOrGet to the present
...
Signed-off-by: beorn7 <beorn@soundcloud.com>
2018-10-10 15:41:21 +02:00
0a8115f42e
Merge pull request #474 from prometheus/beorn7/testing
...
Add check for duplicated label name
2018-10-01 19:40:01 +02:00
edb489a1ef
Add check for duplicated label names
...
Fixes #471
Signed-off-by: beorn7 <beorn@soundcloud.com>
2018-09-30 16:25:48 +02:00
dd9e125455
Expose failure to detect duplicate label names
...
This is #471 .
Signed-off-by: beorn7 <beorn@soundcloud.com>
2018-09-30 16:25:48 +02:00
daeaac0cfb
Merge pull request #472 from prometheus/beorn7/registry
...
Fix a few minor things...
2018-09-29 11:53:47 +02:00
ff0177896a
Be more precise about concurrency requirements
...
Signed-off-by: beorn7 <beorn@soundcloud.com>
2018-09-29 10:47:28 +02:00
7eb5e8a08a
Drain the desc channel after registering
...
This avoids leaking goroutines.
Signed-off-by: beorn7 <beorn@soundcloud.com>
2018-09-29 10:44:19 +02:00
2d5a6493f8
Merge pull request #467 from daveworth/patch-1
...
fix exponential buckets failure message
2018-09-26 16:21:55 +02:00
c2c648fdcb
fix exponential buckets failure message
...
it appears there is a copy/paste error in the exponential buckets test failure message which is fixed here.
Signed-off-by: David Worth <dworth@strava.com>
2018-09-25 17:42:06 -06:00
f69c853d21
Merge pull request #466 from prometheus/beorn7/histogram
...
Ensure 64bit alignment on 32bit platforms for histograms
2018-09-24 13:34:49 +02:00
7973e4709d
Ensure 64bit alignment on 32bit platforms for histograms
...
Signed-off-by: beorn7 <beorn@soundcloud.com>
2018-09-24 13:28:13 +02:00
73edb9af66
Merge pull request #462 from prometheus/beorn7/testing
...
Add Go 1.11
2018-09-19 13:43:04 +02:00
3a6edf5ff8
Handle items newly deprecated in Go 1.11
...
Remove where possible and ignore staticcheck warnings where we have
to.
Signed-off-by: beorn7 <beorn@soundcloud.com>
2018-09-19 13:30:14 +02:00
2c6e80549e
Add Go 1.11.
...
Since the staticcheck support for older Go versions will disappear,
update the exclusion regexp.
Signed-off-by: beorn7 <beorn@soundcloud.com>
2018-09-19 12:24:24 +02:00
e637cec7d9
Merge pull request #460 from prometheus/beorn7/desc
...
Detect invalid Descs in const metrics, but also allow empty Help strings.
2018-09-17 12:21:22 +02:00
PhilipGough