Commit Graph

5 Commits

Author SHA1 Message Date
Daniel Bornkessel 05891fd731 Remove explicit WriteHeader call to have correct content type
According to the documentation:

    // WriteHeader sends an HTTP response header with status code.
    // If WriteHeader is not called explicitly, the first call to Write
    // will trigger an implicit WriteHeader(http.StatusOK).
    // Thus explicit calls to WriteHeader are mainly used to
    // send error codes.

and

    // Header returns the header map that will be sent by WriteHeader.
    // Changing the header after a call to WriteHeader (or Write) has
    // no effect.

so calling `w.Header().Set(contentType, jsonContentType)` after calling
`w.WriteHeader` does not set the content type -- the call can be removed
though as it always set `http.StatusOK` which will be done anyways
2013-01-03 18:44:50 +01:00
Daniel Bornkessel 4cb006cce4 Split Gauge into Gauge and Counter
Counter is a separate metric now
2012-12-19 11:49:38 +01:00
Matt T. Proud e0b92aec7a - Separate out the packages' files' documentation into a separate documentation file per package.
- Provide better examples in the examples subdirectory.
- Make the comments consistent in terms of using multi-line format for future-proofing.
- Extract major constants out.
2012-05-24 20:02:44 +02:00
Matt T. Proud 5ea9b1a0b5 - Improved comments throughout the package.
- Added normal and exponential distributions to one of the examples.
- Improved the naming of a couple of local variables.
- Handled an error in the AccumulatingBucket ValueForIndex function whereby
  the vestigal old behavior was accidentally preserved and not updated.
  This could have been caught had the tests been updated first.
- Simplify Histogram prospectiveIndexForPercentile such that various
  small tasks it performs are extracted into separate functions for easier
  testing and code comprehension.
- Remedy a regression in Histogram prospectiveIndexForPercentile whereby
  the prospective index may have included the terminating element of a
  bucket.
- Provide help for Histogram prospectiveIndexForPercentile such that requesting
  the terminating element of a bucket will fast-forward to the first element of
  the next non-empty bucket.
- Fix TallingBucket's boundary constant, because they were originally keyed toward
  percentages [0, 100], not decimal-based ones.  The antique tests had been
  temporarily commented out, which prevented this regression from being exposed.
2012-05-22 09:20:09 +02:00
Matt T. Proud a1f4f3eec2 - Extract main out of the package root and into the examples/ hierarchy. 2012-05-21 10:43:21 +02:00