From f504d69affe11ec1ccb2e5948127f86878c9fd57 Mon Sep 17 00:00:00 2001 From: Luke Hanley Date: Wed, 28 Mar 2018 14:04:30 +0100 Subject: [PATCH] promhttp: fix DNSDone should call Done, not Start (#395) When tracing, it appears DNSDone is instead calling the supplied DNSStart function --- prometheus/promhttp/instrument_client_1_8.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/prometheus/promhttp/instrument_client_1_8.go b/prometheus/promhttp/instrument_client_1_8.go index 0bd80c3..a034d1e 100644 --- a/prometheus/promhttp/instrument_client_1_8.go +++ b/prometheus/promhttp/instrument_client_1_8.go @@ -81,8 +81,8 @@ func InstrumentRoundTripperTrace(it *InstrumentTrace, next http.RoundTripper) Ro } }, DNSDone: func(_ httptrace.DNSDoneInfo) { - if it.DNSStart != nil { - it.DNSStart(time.Since(start).Seconds()) + if it.DNSDone != nil { + it.DNSDone(time.Since(start).Seconds()) } }, ConnectStart: func(_, _ string) {