re
/
client_golang
forked from mirror/client_golang
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Unflake TestGoCollectorGoroutines 

This is not a great solution, but it's also hard to test for this
moving target.

Signed-off-by: beorn7 <beorn@grafana.com>
This commit is contained in:
beorn7 2019-10-14 19:44:28 +02:00
parent 3ddc3cfbe5
commit 6fa429cf42
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
prometheus/go_collector_test.go
View File

@ -44,9 +44,14 @@ func TestGoCollectorGoroutines(t *testing.T) {
go func() {
c.Collect(metricCh)
go func(c <-chan struct{}) {
<-c
}(endGoroutineCh)
for i := 1; i <= 10; i++ {
// Start 10 goroutines to be sure we'll detect an
// increase even if unrelated goroutines happen to
// terminate during this test.
go func(c <-chan struct{}) {
<-c
}(endGoroutineCh)
}
<-waitCh
c.Collect(metricCh)
close(endCollectionCh)
@ -73,9 +78,8 @@ func TestGoCollectorGoroutines(t *testing.T) {
continue
}
if diff := int(pb.GetGauge().GetValue()) - old; diff != 1 {
// TODO: This is flaky in highly concurrent situations.
t.Errorf("want 1 new goroutine, got %d", diff)
if diff := old - int(pb.GetGauge().GetValue()); diff > -1 {
t.Errorf("want at least one new goroutine, got %d fewer", diff)
}
case <-time.After(1 * time.Second):
t.Fatalf("expected collect timed out")