re
/
client_golang
forked from mirror/client_golang
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

don't reuse memstats

This commit is contained in:
Kevin Pike 2015-10-05 07:37:59 -07:00
parent 8a031ee219
commit 6c7a1db6bf
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
prometheus/go_collector.go
View File

@ -11,8 +11,6 @@ type goCollector struct {
goroutines Gauge goroutines Gauge
gcDesc *Desc gcDesc *Desc
// memstats object to reuse
ms *runtime.MemStats
// metrics to describe and collect // metrics to describe and collect
metrics memStatsMetrics metrics memStatsMetrics
} }
@ -21,7 +19,6 @@ type goCollector struct {
// go process. // go process.
func NewGoCollector() *goCollector { func NewGoCollector() *goCollector {
return &goCollector{ return &goCollector{
ms: new(runtime.MemStats),
goroutines: NewGauge(GaugeOpts{ goroutines: NewGauge(GaugeOpts{
Namespace: "go", Namespace: "go",
Name: "goroutines", Name: "goroutines",
@ -267,13 +264,14 @@ func (c *goCollector) Collect(ch chan<- Metric) {
quantiles[0.0] = stats.PauseQuantiles[0].Seconds() quantiles[0.0] = stats.PauseQuantiles[0].Seconds()
ch <- MustNewConstSummary(c.gcDesc, uint64(stats.NumGC), float64(stats.PauseTotal.Seconds()), quantiles) ch <- MustNewConstSummary(c.gcDesc, uint64(stats.NumGC), float64(stats.PauseTotal.Seconds()), quantiles)
runtime.ReadMemStats(c.ms) ms := &runtime.MemStats{}
runtime.ReadMemStats(ms)
for _, i := range c.metrics { for _, i := range c.metrics {
ch <- MustNewConstMetric(i.desc, i.valType, i.eval(c.ms)) ch <- MustNewConstMetric(i.desc, i.valType, i.eval(ms))
} }
} }
// memStatsMetrics provide description, value, and value type for memstat metrics // memStatsMetrics provide description, value, and value type for memstat metrics.
type memStatsMetrics []struct { type memStatsMetrics []struct {
desc *Desc desc *Desc
eval func(*runtime.MemStats) float64 eval func(*runtime.MemStats) float64