From 66b5a26cec40dd699091293fa638267abcec78ba Mon Sep 17 00:00:00 2001 From: Karsten Weiss Date: Fri, 13 Apr 2018 22:15:28 +0200 Subject: [PATCH] Remove unnecessary for loop in makeLabelPairs() Fixes: value.go:155:2: should replace loop with labelPairs = append(labelPairs, desc.constLabelPairs...) (S1011) Signed-off-by: Karsten Weiss --- prometheus/value.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/prometheus/value.go b/prometheus/value.go index 543b57c..9fb7eab 100644 --- a/prometheus/value.go +++ b/prometheus/value.go @@ -152,9 +152,7 @@ func makeLabelPairs(desc *Desc, labelValues []string) []*dto.LabelPair { Value: proto.String(labelValues[i]), }) } - for _, lp := range desc.constLabelPairs { - labelPairs = append(labelPairs, lp) - } + labelPairs = append(labelPairs, desc.constLabelPairs...) sort.Sort(LabelPairSorter(labelPairs)) return labelPairs }