Merge branch 'develop'

This commit is contained in:
Andy Pan 2018-08-31 23:16:23 +08:00
commit 7c881fbcab
3 changed files with 15 additions and 51 deletions

View File

@ -131,41 +131,3 @@ func TestCodeCov(t *testing.T) {
p.ReSize(AntsSize) p.ReSize(AntsSize)
t.Logf("pool with func, after resize, capacity:%d, running:%d", p.Cap(), p.Running()) t.Logf("pool with func, after resize, capacity:%d, running:%d", p.Cap(), p.Running())
} }
// func TestNoPool(t *testing.T) {
// var wg sync.WaitGroup
// for i := 0; i < n; i++ {
// wg.Add(1)
// go func() {
// demoPoolFunc(n)
// wg.Done()
// }()
// }
// wg.Wait()
// mem := runtime.MemStats{}
// runtime.ReadMemStats(&mem)
// t.Logf("memory usage:%d", mem.TotalAlloc/GiB)
// }
//func TestCustomPool(t *testing.T) {
// p, _ := ants.NewPool(30000)
// var wg sync.WaitGroup
// for i := 0; i < n; i++ {
// wg.Add(1)
// p.Submit(func() {
// demoFunc()
// //demoFunc()
// wg.Done()
// })
// }
// wg.Wait()
//
// //t.Logf("pool capacity:%d", p.Cap())
// //t.Logf("free workers number:%d", p.Free())
//
// t.Logf("running workers number:%d", p.Running())
// mem := runtime.MemStats{}
// runtime.ReadMemStats(&mem)
// t.Logf("memory usage:%d", mem.TotalAlloc/1024)
//}

View File

@ -67,7 +67,7 @@ func (p *Pool) periodicallyPurge() {
p.lock.Unlock() p.lock.Unlock()
return return
} }
n := 0 n := -1
for i, w := range idleWorkers { for i, w := range idleWorkers {
if currentTime.Sub(w.recycleTime) <= p.expiryDuration { if currentTime.Sub(w.recycleTime) <= p.expiryDuration {
break break
@ -76,11 +76,12 @@ func (p *Pool) periodicallyPurge() {
w.task <- nil w.task <- nil
idleWorkers[i] = nil idleWorkers[i] = nil
} }
n++ if n > -1 {
if n >= len(idleWorkers) { if n >= len(idleWorkers)-1 {
p.workers = idleWorkers[:0] p.workers = idleWorkers[:0]
} else { } else {
p.workers = idleWorkers[n:] p.workers = idleWorkers[n+1:]
}
} }
p.lock.Unlock() p.lock.Unlock()
} }

View File

@ -68,7 +68,7 @@ func (p *PoolWithFunc) periodicallyPurge() {
p.lock.Unlock() p.lock.Unlock()
return return
} }
n := 0 n := -1
for i, w := range idleWorkers { for i, w := range idleWorkers {
if currentTime.Sub(w.recycleTime) <= p.expiryDuration { if currentTime.Sub(w.recycleTime) <= p.expiryDuration {
break break
@ -77,11 +77,12 @@ func (p *PoolWithFunc) periodicallyPurge() {
w.args <- nil w.args <- nil
idleWorkers[i] = nil idleWorkers[i] = nil
} }
n++ if n > -1 {
if n >= len(idleWorkers) { if n >= len(idleWorkers)-1 {
p.workers = idleWorkers[:0] p.workers = idleWorkers[:0]
} else { } else {
p.workers = idleWorkers[n:] p.workers = idleWorkers[n+1:]
}
} }
p.lock.Unlock() p.lock.Unlock()
} }