mirror of https://github.com/spf13/viper.git
Updated TestBindPFlagsStringSlice() to highlight a failure
When pflag marked as changed, the value is not detected (and lower priority value used)
This commit is contained in:
parent
b7a3b95476
commit
cc7e906d88
|
@ -613,6 +613,8 @@ func TestBindPFlags(t *testing.T) {
|
|||
}
|
||||
|
||||
func TestBindPFlagsStringSlice(t *testing.T) {
|
||||
defaultVal := []string{"default"}
|
||||
|
||||
for _, testValue := range []struct {
|
||||
Expected []string
|
||||
Value string
|
||||
|
@ -624,6 +626,8 @@ func TestBindPFlagsStringSlice(t *testing.T) {
|
|||
|
||||
for _, changed := range []bool{true, false} {
|
||||
v := New() // create independent Viper object
|
||||
v.SetDefault("stringslice", defaultVal)
|
||||
|
||||
flagSet := pflag.NewFlagSet("test", pflag.ContinueOnError)
|
||||
flagSet.StringSlice("stringslice", testValue.Expected, "test")
|
||||
flagSet.Visit(func(f *pflag.Flag) {
|
||||
|
@ -645,7 +649,11 @@ func TestBindPFlagsStringSlice(t *testing.T) {
|
|||
if err := v.Unmarshal(val); err != nil {
|
||||
t.Fatalf("%+#v cannot unmarshal: %s", testValue.Value, err)
|
||||
}
|
||||
assert.Equal(t, testValue.Expected, val.StringSlice)
|
||||
if changed {
|
||||
assert.Equal(t, testValue.Expected, val.StringSlice)
|
||||
} else {
|
||||
assert.Equal(t, defaultVal, val.StringSlice)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue