tidwall
23b016d192
Fix excessive memory usage for objects with TTLs
...
This commit fixes an issue where Tile38 was using lots of extra
memory to track objects that are marked to expire. This was
creating problems with applications that set big TTLs.
How it worked before:
Every collection had a unique hashmap that stores expiration
timestamps for every object in that collection. Along with
the hashmaps, there's also one big server-wide list that gets
appended every time a new SET+EX is performed.
From a background routine, this list is looped over at least
10 times per second and is randomly searched for potential
candidates that might need expiring. The routine then removes
those entries from the list and tests if the objects matching
the entries have actually expired. If so, these objects are
deleted them from the database. When at least 25% of
the 20 candidates are deleted the loop is immediately
continued, otherwise the loop backs off with a 100ms pause.
Why this was a problem.
The list grows one entry for every SET+EX. When TTLs are long,
like 24-hours or more, it would take at least that much time
before the entry is removed. So for databased that have objects
that use TTLs and are updated often this could lead to a very
large list.
How it was fixed.
The list was removed and the hashmap is now search randomly. This
required a new hashmap implementation, as the built-in Go map
does not provide an operation for randomly geting entries. The
chosen implementation is a robinhood-hash because it provides
open-addressing, which makes for simple random bucket selections.
Issue #502
2019-10-29 11:19:33 -07:00
Jordan Armstrong
324b3b06d9
Fix go vet error in stats_cpu.go for non-linux/darwin builds
2019-10-28 22:39:27 -03:00
Jordan Armstrong
e0eca0d55e
Replace isJsonNumber with version from gjson
2019-10-28 22:35:44 -03:00
Josh Baker
df477bf3f4
Merge pull request #464 from rshura/area-expression
...
Add area expressions.
2019-10-28 13:45:10 -07:00
tidwall
10f7bfc445
Fix invalid pubsub format for json output
...
This commit fixes a bug that causes bad formatting for geofence
notifications when a client's output is set to JSON.
closes #499
2019-10-28 12:51:44 -07:00
Jordan Armstrong
41fb410e2e
Strictly check if values to JSET are numbers
...
Fixes #493
2019-10-26 23:37:48 -03:00
tidwall
87185319b2
Fix JSET cancels expiry
...
issue #498
2019-10-08 09:45:46 -07:00
tidwall
639f6e2deb
Replaced boxtree for rbang
2019-09-12 18:42:53 -07:00
tidwall
3d96b17258
GC pauses be gone
2019-09-04 12:47:30 -07:00
tidwall
2571ce5106
Minimize AOF buffer releases
2019-09-03 17:01:26 -07:00
tidwall
4bd6b4b838
Moved ReadMemStats into a background polling function
...
This will keep profile commands such as SERVER and STATS from
stopping the world.
2019-09-03 16:57:49 -07:00
tidwall
e167e88e8f
removed diag
2019-09-03 16:39:51 -07:00
tidwall
b6884fce63
diagnostics
2019-09-03 16:35:42 -07:00
tidwall
aedd972516
Fixed invalid count for nearby queries
...
closes #489
2019-08-22 15:53:37 -07:00
saltatory
ec5a5342a2
Added RLock on connections map
2019-08-09 08:48:23 -07:00
tidwall
f7888c1edf
Fixed malformed json for chans command
...
Mentioned by ds2xor on Slack
2019-08-03 10:10:28 -07:00
Alex Roitman
b9e2c67933
Fix lua pool pruning
2019-08-01 11:55:52 -07:00
Alex Roitman
dd09ffbe13
Fix parser for multiple negations.
2019-06-14 10:02:26 -07:00
Alex Roitman
7c541949b1
Unnecessary code.
2019-06-13 14:12:42 -07:00
Alex Roitman
eb214cb889
Better naming and comments.
2019-06-13 13:33:07 -07:00
Alex Roitman
2d83e18934
Add expression errors test. Make parser stricter.
2019-06-13 13:10:47 -07:00
Alex Roitman
0c3a5d02ca
Fixes
2019-06-13 12:04:04 -07:00
Alex Roitman
3ded4e3a44
Refactor using method expressions, to avoid repeating code.
2019-06-13 10:56:33 -07:00
Alex Roitman
81f57ba6f6
Fix one case in expression/expression tests
2019-06-13 09:53:17 -07:00
Alex Roitman
496ace25d3
Refactoring/cleanup/fixes.
2019-06-11 17:13:33 -07:00
Alex Roitman
d0ca579f5c
Add area expressions.
...
Add parser.
Hook up to test command.
Add tests for expressions in test command.
2019-06-10 14:47:42 -07:00
Josh Baker
aa73fcd17b
Added unsubscribing from active channel
...
related #448
2019-06-04 13:49:32 -07:00
Melissa Baker
46f5d2d224
Fixed nearby json field results showing wrong data
...
issue #453
2019-05-28 12:17:59 -07:00
tidwall
3ae59274e3
Removed evio option
2019-04-26 11:50:49 -07:00
Alex Roitman
cbf10b7472
Rework timeouts to allow prepending any command with the TIMEOUT seconds
2019-04-25 14:15:53 -07:00
Alex Roitman
49111a4dce
Add timeouts for lua scripts
2019-04-24 17:00:52 -07:00
Alex Roitman
31525487c3
Add timeout tests. Fix a bug.
2019-04-24 13:20:57 -07:00
Alex Roitman
e514a0287f
Add timeout subcommand to scan/search commands.
...
Use per-query timeout for those commands, if it was given.
2019-04-24 12:02:39 -07:00
tidwall
0aecef6a5c
Added TIMEOUT command
2019-04-24 05:09:41 -07:00
tidwall
bb33467da1
Fix crash with fence ROAM
...
closes #440
2019-04-23 11:16:55 -07:00
tidwall
8c69fbff31
Fixed clients blocking while webook sending
...
Closes #428
2019-03-16 15:43:33 -07:00
tidwall
762607dc0a
Added geofence delivery counter
2019-03-14 11:23:23 -07:00
tidwall
5333fab870
Recycle aof buffer
2019-03-10 10:48:14 -07:00
tidwall
fc3e8b4359
Fix nearby with match query invalid results
...
closes #421
2019-03-01 06:55:26 -07:00
Steven Wolfe
fd20190bff
Verify hook names match for processing
2019-02-22 15:58:13 -07:00
Parham Alvani
e0ddd5e6a6
Adds Server command for lua scripts.
2019-02-17 13:28:20 +03:30
tidwall
fb7259b10b
Changed clip errors and json result type
2019-02-12 05:33:20 -07:00
tidwall
62f44ed055
Merge branch 'master' of https://github.com/tidwall/tile38
2019-02-12 05:06:10 -07:00
Josh Baker
6fffa75b58
Merge pull request #409 from rshura/test_cmd
...
Test command
2019-02-12 05:05:50 -07:00
tidwall
14b616b150
More test fields
2019-02-11 15:42:35 -07:00
tidwall
92c1ce8ef9
Update tinybtree dep
2019-02-11 13:39:29 -07:00
Alex Roitman
c849ab19ac
Implement test command
2019-02-08 13:57:29 -08:00
Alex Roitman
f7ba43360e
Typo in error messages
2019-02-08 13:56:07 -08:00
Steven Wolfe
79c902efbf
Adding more replication data to INFO response
2019-01-18 14:51:20 -07:00
Steven Wolfe
ffd8ca915c
Testing for valid INFO and CLIENT Json output
2019-01-15 11:08:19 -07:00
Steven Wolfe
0740ca13cd
JSON Output for INFO and CLIENT
2019-01-14 15:29:29 -07:00
Steven Wolfe
4392fb44bd
Fixing KEYS command and tests
2019-01-14 11:06:12 -07:00
Steven Wolfe
4ad2e920f5
Merge branch 'sl/requirevalid' of https://github.com/stevelacy/tile38 into stevelacy-sl/requirevalid
2019-01-10 12:49:48 -07:00
Steve Lacy
1a8993feaf
Add RequireValid env variable and parse options
2019-01-10 09:36:58 -07:00
Steven Wolfe
eb2ff76f86
Sorting > 1 and docs
2019-01-09 10:35:50 -07:00
Steven Wolfe
a5fbcf5f15
Ensuring channel publish order
2019-01-09 00:23:53 -07:00
tidwall
ed31f2bd4c
Merge branch 'lua/distance_to' of https://github.com/rshura/tile38 into rshura-lua/distance_to
2019-01-06 10:29:59 -07:00
tidwall
d7d0baa954
Fix roam fence missing
2019-01-06 10:23:57 -07:00
Alex Roitman
5e215c247d
Add distance_to function to the tile38 namespace in lua.
...
distance_to(lat_a, lon_a, lat_b, lon_b) returns distance in meters between points A and B.
2019-01-04 14:57:00 -08:00
Alex Roitman
e1c82e17f7
Refactor to be more consistent with redis responses.
2018-12-28 14:46:54 -08:00
Alex Roitman
01a7dda2a1
Add RENAME and RENAMENX commands.
2018-12-27 17:15:53 -08:00
tidwall
1c972ad578
Fix massinsert dev call
2018-12-03 15:35:32 -07:00
tidwall
f795567f9c
Merge branch 'master' into Ext-server-stats
2018-11-29 15:22:48 -08:00
tidwall
6b2fc1f37f
Fix multiple matches on different key hooks
2018-11-29 15:15:26 -08:00
Steven Wolfe
8619d35a5b
Adding ext to SERVER command for more info
2018-11-26 14:19:08 -07:00
tidwall
8b29e98359
Optimized spatial index for fences
2018-11-23 18:15:14 -07:00
tidwall
f2c217c216
Refactor and comment command details
2018-11-23 15:53:33 -07:00
tidwall
1197cca40c
Avoid extra broadcasts
2018-11-23 15:38:49 -07:00
tidwall
8906d8e65a
Refactor and consolidate variables
2018-11-23 02:14:26 -07:00
tidwall
37531f9350
Removed unused atomics
2018-11-23 01:39:04 -07:00
tidwall
58421ef806
Removed unused code
2018-11-23 01:24:35 -07:00
tidwall
669823950a
Fix script load issue
2018-11-20 10:25:48 -08:00
tidwall
737561fa8b
Fix version not being set at build, close #386
2018-11-15 13:45:55 -07:00
tidwall
a0f3b0049f
Fix aof loading problem
2018-11-15 09:15:39 -07:00
Josh Baker
37afa7e92b
Merge pull request #385 from stevelacy/sl/server_version
...
Add server command for `version` - closes #384
2018-11-15 04:18:28 -07:00
tidwall
4c3ac62191
Hotfix replica sync needs flushing
2018-11-13 12:04:16 -07:00
Steve Lacy
5c6c280559
Add server command for `version` - closes #384
2018-11-13 10:24:15 -07:00
tidwall
6616b86eda
Default numloops to number goprocs
2018-11-11 09:29:07 -07:00
tidwall
7cc9154eb8
Correct threads equals cpu
2018-11-11 09:05:26 -07:00
tidwall
d065b979da
net prewrite optimization
2018-11-11 09:05:26 -07:00
tidwall
464c193d73
Prewrite optimization flag
2018-11-11 09:05:26 -07:00
tidwall
3bf91077d9
Hang on to lower command
2018-11-11 09:05:26 -07:00
tidwall
161c6faff9
Added evio flag
2018-11-11 09:03:47 -07:00
tidwall
933f243c6c
Code cleanup
2018-11-11 09:03:47 -07:00
tidwall
e46c945f2c
Fix windows build issue
2018-11-05 10:58:01 -07:00
tidwall
07bae979a5
Added Cursor interface
2018-11-02 06:09:56 -07:00
Josh Baker
0ea2ec216c
Merge pull request #378 from rshura/fast_cursor
...
Fast cursor
2018-11-02 05:14:53 -07:00
tidwall
a4986d9cf8
Removed unneeded params
2018-11-02 05:09:51 -07:00
Alex Roitman
0933c541f4
Refactor cursor/paging.
2018-10-31 22:01:37 -07:00
Alex Roitman
b94f3685b6
Move iterating up to the cursor before any tests.
2018-10-31 22:01:24 -07:00
Alex Roitman
f45d81d692
Simplification
2018-10-31 01:30:10 -07:00
Alex Roitman
d2c687d61e
camelCase
2018-10-31 00:45:16 -07:00
Alex Roitman
63b41691e6
Clean up obsolete code.
2018-10-31 00:40:09 -07:00
Alex Roitman
18d7398d50
Minor refactoring
2018-10-29 18:18:04 -07:00
Alex Roitman
2383594048
Use haversine instead of distance in knn if distance is not required.
2018-10-29 15:32:47 -07:00
tidwall
555e47036c
Replaced net package with evio
...
- Added threads startup flag
- Replaced net package with evio
- Refactored controller into server
2018-10-28 15:51:47 -07:00
tidwall
6257ddba78
Faster point in polygon / GeoJSON updates
...
The big change is that the GeoJSON package has been completely
rewritten to fix a few of geometry calculation bugs, increase
performance, and to better follow the GeoJSON spec RFC 7946.
GeoJSON updates
- A LineString now requires at least two points.
- All json members, even foreign, now persist with the object.
- The bbox member persists too but is no longer used for geometry
calculations. This is change in behavior. Previously Tile38 would
treat the bbox as the object's physical rectangle.
- Corrections to geometry intersects and within calculations.
Faster spatial queries
- The performance of Point-in-polygon and object intersect operations
are greatly improved for complex polygons and line strings. It went
from O(n) to roughly O(log n).
- The same for all collection types with many children, including
FeatureCollection, GeometryCollection, MultiPoint, MultiLineString,
and MultiPolygon.
Codebase changes
- The pkg directory has been renamed to internal
- The GeoJSON internal package has been moved to a seperate repo at
https://github.com/tidwall/geojson . It's now vendored.
Please look out for higher memory usage for datasets using complex
shapes. A complex shape is one that has 64 or more points. For these
shapes it's expected that there will be increase of least 54 bytes per
point.
2018-10-13 04:30:48 -07:00