fix #717 not returned metrics

expired_keys never incremented
additional metrics not returned from metrics endpoint
This commit is contained in:
Maxim Kropotov 2024-02-12 20:48:18 +02:00
parent 946031456e
commit c78c8b4287
2 changed files with 30 additions and 7 deletions

View File

@ -32,6 +32,7 @@ func (s *Server) backgroundExpireObjects(now time.Time) {
if nano < o.Expires() { if nano < o.Expires() {
return false return false
} }
s.statsExpired.Add(1)
msgs = append(msgs, &Message{Args: []string{"del", key, o.ID()}}) msgs = append(msgs, &Message{Args: []string{"del", key, o.ID()}})
return true return true
}) })

View File

@ -92,13 +92,7 @@ func (s *Server) Collect(ch chan<- prometheus.Metric) {
s.extStats(m) s.extStats(m)
for metric, descr := range metricDescriptions { for metric, descr := range metricDescriptions {
val, ok := m[metric].(float64) val, ok := toFloat(m[metric])
if !ok {
val2, ok2 := m[metric].(int)
if ok2 {
val, ok = float64(val2), true
}
}
if ok { if ok {
ch <- prometheus.MustNewConstMetric(descr, prometheus.GaugeValue, val) ch <- prometheus.MustNewConstMetric(descr, prometheus.GaugeValue, val)
} }
@ -155,3 +149,31 @@ func (s *Server) Collect(ch chan<- prometheus.Metric) {
return true return true
}) })
} }
func toFloat(val interface{}) (float64, bool) {
switch v := val.(type) {
case float64:
return v, true
case int64:
return float64(v), true
case uint64:
return float64(v), true
case float32:
return float64(v), true
case int:
return float64(v), true
case int32:
return float64(v), true
case uint32:
return float64(v), true
case int16:
return float64(v), true
case uint16:
return float64(v), true
case int8:
return float64(v), true
case uint8:
return float64(v), true
}
return 0, false
}