From 694ad1fb62f4d245c96e79f9f93b0e1166009888 Mon Sep 17 00:00:00 2001 From: tidwall Date: Sat, 31 Jul 2021 07:42:58 -0700 Subject: [PATCH] Update btree/buntdb --- go.mod | 6 +- go.sum | 15 +- internal/collection/collection.go | 6 +- internal/server/crud.go | 2 +- internal/server/server.go | 4 +- tests/616/main.go | 4 +- vendor/github.com/tidwall/btree/PATH_HINT.md | 43 ++++++ vendor/github.com/tidwall/btree/README.md | 38 ++--- vendor/github.com/tidwall/btree/btree.go | 122 ++++++++++----- vendor/github.com/tidwall/buntdb/README.md | 7 +- vendor/github.com/tidwall/buntdb/buntdb.go | 45 ++++-- vendor/github.com/tidwall/buntdb/go.mod | 6 +- vendor/github.com/tidwall/buntdb/go.sum | 12 +- vendor/github.com/tidwall/gjson/README.md | 10 +- vendor/github.com/tidwall/gjson/gjson.go | 152 ++++--------------- vendor/github.com/tidwall/grect/go.mod | 2 +- vendor/github.com/tidwall/grect/go.sum | 4 +- vendor/modules.txt | 8 +- 18 files changed, 255 insertions(+), 231 deletions(-) create mode 100644 vendor/github.com/tidwall/btree/PATH_HINT.md diff --git a/go.mod b/go.mod index a4cabae4..ca3093e8 100644 --- a/go.mod +++ b/go.mod @@ -15,11 +15,11 @@ require ( github.com/peterh/liner v1.2.1 github.com/prometheus/client_golang v1.10.0 github.com/streadway/amqp v1.0.0 - github.com/tidwall/btree v0.5.0 - github.com/tidwall/buntdb v1.2.3 + github.com/tidwall/btree v0.6.0 + github.com/tidwall/buntdb v1.2.5 github.com/tidwall/geoindex v1.4.3 github.com/tidwall/geojson v1.2.7 - github.com/tidwall/gjson v1.7.4 + github.com/tidwall/gjson v1.8.0 github.com/tidwall/match v1.0.3 github.com/tidwall/pretty v1.1.0 github.com/tidwall/redbench v0.1.0 diff --git a/go.sum b/go.sum index 0edf71ee..a902eb6b 100644 --- a/go.sum +++ b/go.sum @@ -410,20 +410,21 @@ github.com/stretchr/testify v1.5.1/go.mod h1:5W2xD1RspED5o8YsWQXVCued0rvSQ+mT+I5 github.com/stretchr/testify v1.6.1 h1:hDPOHmpOpP40lSULcqw7IrRb/u7w6RpDC9399XyoNd0= github.com/stretchr/testify v1.6.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg= github.com/tidwall/btree v0.4.2/go.mod h1:huei1BkDWJ3/sLXmO+bsCNELL+Bp2Kks9OLyQFkzvA8= -github.com/tidwall/btree v0.5.0 h1:IBfCtOj4uOMQcodv3wzYVo0zPqSJObm71mE039/dlXY= -github.com/tidwall/btree v0.5.0/go.mod h1:TzIRzen6yHbibdSfK6t8QimqbUnoxUSrZfeW7Uob0q4= -github.com/tidwall/buntdb v1.2.3 h1:AoGVe4yrhKmnEPHrPrW5EUOATHOCIk4VtFvd8xn/ZtU= -github.com/tidwall/buntdb v1.2.3/go.mod h1:+i/gBwYOHWG19wLgwMXFLkl00twh9+VWkkaOhuNQ4PA= +github.com/tidwall/btree v0.6.0 h1:JLYAFGV+1gjyFi3iQbO/fupBin+Ooh7dxqVV0twJ1Bo= +github.com/tidwall/btree v0.6.0/go.mod h1:TzIRzen6yHbibdSfK6t8QimqbUnoxUSrZfeW7Uob0q4= +github.com/tidwall/buntdb v1.2.5 h1:eRLLh0pJkoSu/6bALIzGH7VPxhFcrWNId6FSHgi8yfc= +github.com/tidwall/buntdb v1.2.5/go.mod h1:zpXqlA5D2772I4cTqV3ifr2AZihDgi8FV7xAQu6edfc= github.com/tidwall/cities v0.1.0 h1:CVNkmMf7NEC9Bvokf5GoSsArHCKRMTgLuubRTHnH0mE= github.com/tidwall/cities v0.1.0/go.mod h1:lV/HDp2gCcRcHJWqgt6Di54GiDrTZwh1aG2ZUPNbqa4= github.com/tidwall/geoindex v1.4.3 h1:zowx7LtzibIE6JPbL6CRgVgw9qp13dJ8Pzfa4/f+4us= github.com/tidwall/geoindex v1.4.3/go.mod h1:NQJQszWCH4+KlD0wY+mgQ2hK/GdSH+9+ZRknDY8bOHc= github.com/tidwall/geojson v1.2.7 h1:AyJ8LrkS2kWEr7bi+Hzu1FsD0YjXinraO7i/6MKl1gs= github.com/tidwall/geojson v1.2.7/go.mod h1:pt8JcRqaBGmX3N/1a2fP/a5GmOKPX4Yx+ejlDGEMtyI= -github.com/tidwall/gjson v1.7.4 h1:19cchw8FOxkG5mdLRkGf9jqIqEyqdZhPqW60XfyFxk8= github.com/tidwall/gjson v1.7.4/go.mod h1:5/xDoumyyDNerp2U36lyolv46b3uF/9Bu6OfyQ9GImk= -github.com/tidwall/grect v0.1.1 h1:+kMEkxhoqB7rniVXzMEIA66XwU07STgINqxh+qVIndY= -github.com/tidwall/grect v0.1.1/go.mod h1:CzvbGiFbWUwiJ1JohXLb28McpyBsI00TK9Y6pDWLGRQ= +github.com/tidwall/gjson v1.8.0 h1:Qt+orfosKn0rbNTZqHYDqBrmm3UDA4KRkv70fDzG+PQ= +github.com/tidwall/gjson v1.8.0/go.mod h1:5/xDoumyyDNerp2U36lyolv46b3uF/9Bu6OfyQ9GImk= +github.com/tidwall/grect v0.1.2 h1:wKVeQVZhjaFCKTTlpkDe3Ex4ko3cMGW3MRKawRe8uQ4= +github.com/tidwall/grect v0.1.2/go.mod h1:v+n4ewstPGduVJebcp5Eh2WXBJBumNzyhK8GZt4gHNw= github.com/tidwall/lotsa v1.0.1/go.mod h1:X6NiU+4yHA3fE3Puvpnn1XMDrFZrE9JO2/w+UMuqgR8= github.com/tidwall/lotsa v1.0.2 h1:dNVBH5MErdaQ/xd9s769R31/n2dXavsQ0Yf4TMEHHw8= github.com/tidwall/lotsa v1.0.2/go.mod h1:X6NiU+4yHA3fE3Puvpnn1XMDrFZrE9JO2/w+UMuqgR8= diff --git a/internal/collection/collection.go b/internal/collection/collection.go index 41344cfd..2bce6966 100644 --- a/internal/collection/collection.go +++ b/internal/collection/collection.go @@ -76,10 +76,10 @@ type Collection struct { // New creates an empty collection func New() *Collection { col := &Collection{ - items: btree.New(byID), + items: btree.NewNonConcurrent(byID), index: geoindex.Wrap(&rtree.RTree{}), - values: btree.New(byValue), - expires: btree.New(byExpires), + values: btree.NewNonConcurrent(byValue), + expires: btree.NewNonConcurrent(byExpires), fieldMap: make(map[string]int), fieldArr: make([]string, 0), fieldValues: &fieldValues{}, diff --git a/internal/server/crud.go b/internal/server/crud.go index e67243f7..fd4d8b0c 100644 --- a/internal/server/crud.go +++ b/internal/server/crud.go @@ -502,7 +502,7 @@ func (server *Server) cmdFlushDB(msg *Message) (res resp.Value, d commandDetails err = errInvalidNumberOfArguments return } - server.cols = btree.New(byCollectionKey) + server.cols = btree.NewNonConcurrent(byCollectionKey) server.hooks = make(map[string]*Hook) server.hooksOut = make(map[string]*Hook) server.hookTree = rtree.RTree{} diff --git a/internal/server/server.go b/internal/server/server.go index d7ac15fb..81b5c897 100644 --- a/internal/server/server.go +++ b/internal/server/server.go @@ -159,7 +159,7 @@ func Serve(host string, port int, dir string, useHTTP bool, metricsAddr string) http: useHTTP, pubsub: newPubsub(), monconns: make(map[net.Conn]bool), - cols: btree.New(byCollectionKey), + cols: btree.NewNonConcurrent(byCollectionKey), } server.hookex.Expired = func(item expire.Item) { @@ -989,7 +989,7 @@ func randomKey(n int) string { func (server *Server) reset() { server.aofsz = 0 - server.cols = btree.New(byCollectionKey) + server.cols = btree.NewNonConcurrent(byCollectionKey) } func (server *Server) command(msg *Message, client *Client) ( diff --git a/tests/616/main.go b/tests/616/main.go index 1b0681e2..82c501ca 100644 --- a/tests/616/main.go +++ b/tests/616/main.go @@ -33,12 +33,12 @@ func main() { "The SCAN and ACTUAL values should reach about 1850 and stay\n" + "roughly the same from there on.\n") var mu sync.Mutex - objs := btree.New(func(a, b interface{}) bool { + objs := btree.NewNonConcurrent(func(a, b interface{}) bool { ajson := a.(string) bjson := b.(string) return gjson.Get(ajson, "id").String() < gjson.Get(bjson, "id").String() }) - expires := btree.New(func(a, b interface{}) bool { + expires := btree.NewNonConcurrent(func(a, b interface{}) bool { ajson := a.(string) bjson := b.(string) if gjson.Get(ajson, "properties.ex").Int() < gjson.Get(bjson, "properties.ex").Int() { diff --git a/vendor/github.com/tidwall/btree/PATH_HINT.md b/vendor/github.com/tidwall/btree/PATH_HINT.md new file mode 100644 index 00000000..0b2c4055 --- /dev/null +++ b/vendor/github.com/tidwall/btree/PATH_HINT.md @@ -0,0 +1,43 @@ +# B-tree Path Hints + +I use a thing I call path hints in my B-tree [C](https://github.com/tidwall/btree.c) and [Go](https://github.com/tidwall/btree) implementations. It's a search optimization. + +## The B-tree + +A standard [B-tree](https://en.wikipedia.org/wiki/B-tree) is an ordered tree-based data structure that stores its items in nodes. The B-tree has a single root node, which may have children nodes, and those children nodes may also have children nodes. + +image + +Searching for items in a B-tree is fast. [O(log N)](https://en.wikipedia.org/wiki/Big_O_notation) to be exact. +This is because the [binary search algorithm](https://en.wikipedia.org/wiki/Binary_search_algorithm) is used. + +A binary search works by first comparing the item at the middle-most index of the root node with the target item. +If the middle item is greater than the target item, then it divides the node in two and does the binary search on the left part of the node. If the middle is less, it searches the right part. And so on. If the target item is found, then the search stop. If the item is not found, then the search is passed to the child node at the appropriate index. This traversal terminates when item is found or there are no more child nodes. + +image + +## The Path + +Each index is a component of the path to the item (or where the item should be stored, if it does not exist in the tree). + +Take the first example image. The item 9 is at path “1/0”. The item 16 is at path “1”. The item 21 is at path “2/1”. The item 5 is at path “0/2”. + +## The Path Hint + +A Path Hint is a predefined path that is provided to B-tree operations. It’s just a hint that says, “Hey B-tree, instead of starting your binary search with the middle index, start with what I provide you. My path may be wrong, and if so please provide me with the correct path so I get it right the next time.” + +I’ve found using path hints can lead to a little performance increase of 150% - 300%. This is because in real-world cases the items that I’m working with are usually nearby each other in the tree. + +Take for example inserting a group of timeseries points. They may often be received as chucks of near-contiguous items. +Or, I'm sequentially inserting an ordered group of rows somewhere in the middle of a table. +Or, I have a Redis-style key/value store, where the keys look have the common structure “user:98512:name”, “user:98512:email”, and I want to update a bunch of values for specified user. +Using a path hint may help to avoid the unnecessary binary searching in each of these examples. + +While I may see a 3x boost in when the path hint is right on, I'll only see around 5% decrease when the path hint is totally wrong. + +## Using a Path Hint + +For single-threaded programs, it’s possible to use one shared path hint per B-tree for the life of the program. +For multi-threaded programs, I find it best to use one path hint per B-tree , per thread. +For server-client programs, one path hint per B-tree, per client should suffice. + diff --git a/vendor/github.com/tidwall/btree/README.md b/vendor/github.com/tidwall/btree/README.md index aa2c53a0..3612d113 100644 --- a/vendor/github.com/tidwall/btree/README.md +++ b/vendor/github.com/tidwall/btree/README.md @@ -9,7 +9,7 @@ An [efficient](#performance) [B-tree](https://en.wikipedia.org/wiki/B-tree) impl - `Copy()` method with copy-on-write support. - Fast bulk loading for pre-ordered data using the `Load()` method. - All operations are thread-safe. -- Path hinting optimization for operations with nearby keys. +- [Path hinting](PATH_HINT.md) optimization for operations with nearby keys. ## Installing @@ -155,7 +155,7 @@ DeleteHint(item, *hint) # delete an item This implementation was designed with performance in mind. -The following benchmarks were run on my 2019 Macbook Pro (2.4 GHz 8-Core Intel Core i9) using Go 1.15.3. The items are simple 8-byte ints. +The following benchmarks were run on my 2019 Macbook Pro (2.4 GHz 8-Core Intel Core i9) using Go 1.16.5. The items are simple 8-byte ints. - `google`: The [google/btree](https://github.com/google/btree) package - `tidwall`: The [tidwall/btree](https://github.com/tidwall/btree) package @@ -163,29 +163,29 @@ The following benchmarks were run on my 2019 Macbook Pro (2.4 GHz 8-Core Intel C ``` ** sequential set ** -google: set-seq 1,000,000 ops in 160ms, 6,262,097/sec, 159 ns/op, 31.0 MB, 32 bytes/op -tidwall: set-seq 1,000,000 ops in 142ms, 7,020,721/sec, 142 ns/op, 36.6 MB, 38 bytes/op -tidwall: set-seq-hint 1,000,000 ops in 87ms, 11,503,315/sec, 86 ns/op, 36.6 MB, 38 bytes/op -tidwall: load-seq 1,000,000 ops in 37ms, 27,177,242/sec, 36 ns/op, 36.6 MB, 38 bytes/op -go-arr: append 1,000,000 ops in 49ms, 20,574,760/sec, 48 ns/op +google: set-seq 1,000,000 ops in 163ms, 6,140,597/sec, 162 ns/op, 30.9 MB, 32 bytes/op +tidwall: set-seq 1,000,000 ops in 141ms, 7,075,240/sec, 141 ns/op, 36.6 MB, 38 bytes/op +tidwall: set-seq-hint 1,000,000 ops in 79ms, 12,673,902/sec, 78 ns/op, 36.6 MB, 38 bytes/op +tidwall: load-seq 1,000,000 ops in 40ms, 24,887,293/sec, 40 ns/op, 36.6 MB, 38 bytes/op +go-arr: append 1,000,000 ops in 51ms, 19,617,269/sec, 50 ns/op ** random set ** -google: set-rand 1,000,000 ops in 606ms, 1,649,921/sec, 606 ns/op, 21.5 MB, 22 bytes/op -tidwall: set-rand 1,000,000 ops in 543ms, 1,841,590/sec, 543 ns/op, 26.7 MB, 27 bytes/op -tidwall: set-rand-hint 1,000,000 ops in 573ms, 1,745,624/sec, 572 ns/op, 26.4 MB, 27 bytes/op -tidwall: set-again 1,000,000 ops in 452ms, 2,212,581/sec, 451 ns/op, 27.1 MB, 28 bytes/op -tidwall: set-after-copy 1,000,000 ops in 472ms, 2,117,457/sec, 472 ns/op, 27.9 MB, 29 bytes/op -tidwall: load-rand 1,000,000 ops in 551ms, 1,816,498/sec, 550 ns/op, 26.1 MB, 27 bytes/op +google: set-rand 1,000,000 ops in 666ms, 1,501,583/sec, 665 ns/op, 21.5 MB, 22 bytes/op +tidwall: set-rand 1,000,000 ops in 569ms, 1,756,845/sec, 569 ns/op, 26.7 MB, 27 bytes/op +tidwall: set-rand-hint 1,000,000 ops in 670ms, 1,491,637/sec, 670 ns/op, 26.4 MB, 27 bytes/op +tidwall: set-again 1,000,000 ops in 488ms, 2,050,667/sec, 487 ns/op, 27.1 MB, 28 bytes/op +tidwall: set-after-copy 1,000,000 ops in 494ms, 2,022,980/sec, 494 ns/op, 27.9 MB, 29 bytes/op +tidwall: load-rand 1,000,000 ops in 594ms, 1,682,937/sec, 594 ns/op, 26.1 MB, 27 bytes/op ** sequential get ** -google: get-seq 1,000,000 ops in 133ms, 7,497,604/sec, 133 ns/op -tidwall: get-seq 1,000,000 ops in 110ms, 9,082,972/sec, 110 ns/op -tidwall: get-seq-hint 1,000,000 ops in 55ms, 18,289,945/sec, 54 ns/op +google: get-seq 1,000,000 ops in 141ms, 7,078,690/sec, 141 ns/op +tidwall: get-seq 1,000,000 ops in 124ms, 8,075,925/sec, 123 ns/op +tidwall: get-seq-hint 1,000,000 ops in 40ms, 25,142,979/sec, 39 ns/op ** random get ** -google: get-rand 1,000,000 ops in 149ms, 6,704,337/sec, 149 ns/op -tidwall: get-rand 1,000,000 ops in 131ms, 7,616,296/sec, 131 ns/op -tidwall: get-rand-hint 1,000,000 ops in 216ms, 4,632,532/sec, 215 ns/op +google: get-rand 1,000,000 ops in 152ms, 6,593,518/sec, 151 ns/op +tidwall: get-rand 1,000,000 ops in 128ms, 7,783,293/sec, 128 ns/op +tidwall: get-rand-hint 1,000,000 ops in 135ms, 7,403,823/sec, 135 ns/op ``` *You can find the benchmark utility at [tidwall/btree-benchmark](https://github.com/tidwall/btree-benchmark)* diff --git a/vendor/github.com/tidwall/btree/btree.go b/vendor/github.com/tidwall/btree/btree.go index a9d3b0f3..100cf74d 100644 --- a/vendor/github.com/tidwall/btree/btree.go +++ b/vendor/github.com/tidwall/btree/btree.go @@ -4,7 +4,9 @@ package btree -import "sync" +import ( + "sync" +) const maxItems = 255 // max items per node. max children is +1 const minItems = maxItems * 40 / 100 @@ -29,6 +31,7 @@ type BTree struct { root *node count int less func(a, b interface{}) bool + locks bool } func (tr *BTree) newNode(leaf bool) *node { @@ -49,12 +52,26 @@ type PathHint struct { // New returns a new BTree func New(less func(a, b interface{}) bool) *BTree { + return newBTree(less, true) +} + +// NewNonConcurrent returns a new BTree which is not safe for concurrent +// write operations by multiple goroutines. +// +// This is useful for when you do not need the BTree to manage the locking, +// but would rather do it yourself. +func NewNonConcurrent(less func(a, b interface{}) bool) *BTree { + return newBTree(less, false) +} + +func newBTree(less func(a, b interface{}) bool, locks bool) *BTree { if less == nil { panic("nil less") } tr := new(BTree) tr.mu = new(sync.RWMutex) tr.less = less + tr.locks = locks return tr } @@ -131,10 +148,10 @@ func (tr *BTree) SetHint(item interface{}, hint *PathHint) (prev interface{}) { if item == nil { panic("nil item") } - tr.mu.Lock() - prev = tr.setHint(item, hint) - tr.mu.Unlock() - return prev + if tr.lock() { + defer tr.unlock() + } + return tr.setHint(item, hint) } func (tr *BTree) setHint(item interface{}, hint *PathHint) (prev interface{}) { @@ -284,8 +301,9 @@ func (tr *BTree) Get(key interface{}) interface{} { // GetHint gets a value for key using a path hint func (tr *BTree) GetHint(key interface{}, hint *PathHint) interface{} { - tr.mu.RLock() - defer tr.mu.RUnlock() + if tr.rlock() { + defer tr.runlock() + } if tr.root == nil || key == nil { return nil } @@ -316,10 +334,10 @@ func (tr *BTree) Delete(key interface{}) interface{} { // DeleteHint deletes a value for a key using a path hint func (tr *BTree) DeleteHint(key interface{}, hint *PathHint) interface{} { - tr.mu.Lock() - prev := tr.deleteHint(key, hint) - tr.mu.Unlock() - return prev + if tr.lock() { + defer tr.unlock() + } + return tr.deleteHint(key, hint) } func (tr *BTree) deleteHint(key interface{}, hint *PathHint) interface{} { @@ -463,8 +481,9 @@ func (tr *BTree) delete(cn **node, max bool, key interface{}, // Pass nil for pivot to scan all item in ascending order // Return false to stop iterating func (tr *BTree) Ascend(pivot interface{}, iter func(item interface{}) bool) { - tr.mu.RLock() - defer tr.mu.RUnlock() + if tr.rlock() { + defer tr.runlock() + } if tr.root == nil { return } @@ -526,8 +545,9 @@ func (n *node) reverse(iter func(item interface{}) bool) bool { // Pass nil for pivot to scan all item in descending order // Return false to stop iterating func (tr *BTree) Descend(pivot interface{}, iter func(item interface{}) bool) { - tr.mu.RLock() - defer tr.mu.RUnlock() + if tr.rlock() { + defer tr.runlock() + } if tr.root == nil { return } @@ -568,8 +588,9 @@ func (tr *BTree) Load(item interface{}) interface{} { if item == nil { panic("nil item") } - tr.mu.Lock() - defer tr.mu.Unlock() + if tr.lock() { + defer tr.unlock() + } if tr.root == nil { return tr.setHint(item, nil) } @@ -604,8 +625,9 @@ func (tr *BTree) Load(item interface{}) interface{} { // Min returns the minimum item in tree. // Returns nil if the tree has no items. func (tr *BTree) Min() interface{} { - tr.mu.RLock() - defer tr.mu.RUnlock() + if tr.rlock() { + defer tr.runlock() + } if tr.root == nil { return nil } @@ -621,8 +643,9 @@ func (tr *BTree) Min() interface{} { // Max returns the maximum item in tree. // Returns nil if the tree has no items. func (tr *BTree) Max() interface{} { - tr.mu.RLock() - defer tr.mu.RUnlock() + if tr.rlock() { + defer tr.runlock() + } if tr.root == nil { return nil } @@ -638,8 +661,9 @@ func (tr *BTree) Max() interface{} { // PopMin removes the minimum item in tree and returns it. // Returns nil if the tree has no items. func (tr *BTree) PopMin() interface{} { - tr.mu.Lock() - defer tr.mu.Unlock() + if tr.lock() { + defer tr.unlock() + } if tr.root == nil { return nil } @@ -678,8 +702,9 @@ func (tr *BTree) PopMin() interface{} { // PopMax removes the minimum item in tree and returns it. // Returns nil if the tree has no items. func (tr *BTree) PopMax() interface{} { - tr.mu.Lock() - defer tr.mu.Unlock() + if tr.lock() { + defer tr.unlock() + } if tr.root == nil { return nil } @@ -717,8 +742,9 @@ func (tr *BTree) PopMax() interface{} { // GetAt returns the value at index. // Return nil if the tree is empty or the index is out of bounds. func (tr *BTree) GetAt(index int) interface{} { - tr.mu.RLock() - defer tr.mu.RUnlock() + if tr.rlock() { + defer tr.runlock() + } if tr.root == nil || index < 0 || index >= tr.count { return nil } @@ -743,8 +769,9 @@ func (tr *BTree) GetAt(index int) interface{} { // DeleteAt deletes the item at index. // Return nil if the tree is empty or the index is out of bounds. func (tr *BTree) DeleteAt(index int) interface{} { - tr.mu.Lock() - defer tr.mu.Unlock() + if tr.lock() { + defer tr.unlock() + } if tr.root == nil || index < 0 || index >= tr.count { return nil } @@ -804,8 +831,9 @@ outer: // Height returns the height of the tree. // Returns zero if tree has no items. func (tr *BTree) Height() int { - tr.mu.RLock() - defer tr.mu.RUnlock() + if tr.rlock() { + defer tr.runlock() + } var height int if tr.root != nil { n := tr.root @@ -823,8 +851,9 @@ func (tr *BTree) Height() int { // Walk iterates over all items in tree, in order. // The items param will contain one or more items. func (tr *BTree) Walk(iter func(item []interface{})) { - tr.mu.RLock() - defer tr.mu.RUnlock() + if tr.rlock() { + defer tr.runlock() + } if tr.root != nil { tr.root.walk(iter) } @@ -845,11 +874,34 @@ func (n *node) walk(iter func(item []interface{})) { // Copy the tree. This operation is very fast because it only performs a // shadowed copy. func (tr *BTree) Copy() *BTree { - tr.mu.Lock() + if tr.lock() { + defer tr.unlock() + } tr.cow = new(cow) tr2 := *tr tr2.mu = new(sync.RWMutex) tr2.cow = new(cow) - tr.mu.Unlock() return &tr2 } + +func (tr *BTree) lock() bool { + if tr.locks { + tr.mu.Lock() + } + return tr.locks +} + +func (tr *BTree) unlock() { + tr.mu.Unlock() +} + +func (tr *BTree) rlock() bool { + if tr.locks { + tr.mu.RLock() + } + return tr.locks +} + +func (tr *BTree) runlock() { + tr.mu.RUnlock() +} diff --git a/vendor/github.com/tidwall/buntdb/README.md b/vendor/github.com/tidwall/buntdb/README.md index cdb199e1..34a35531 100644 --- a/vendor/github.com/tidwall/buntdb/README.md +++ b/vendor/github.com/tidwall/buntdb/README.md @@ -3,7 +3,6 @@ src="logo.png" width="307" height="150" border="0" alt="BuntDB">
-Go Report Card Godoc LICENSE

@@ -28,7 +27,6 @@ Features - Flexible [iteration](#iterating) of data; ascending, descending, and ranges - [Durable append-only file](#append-only-file) format for persistence - Option to evict old items with an [expiration](#data-expiration) TTL -- Tight codebase, under 2K loc using the `cloc` command - ACID semantics with locking [transactions](#transactions) that support rollbacks @@ -457,8 +455,9 @@ Any index can be put in descending order by wrapping it's less function with `bu ```go db.CreateIndex("last_name_age", "*", -buntdb.IndexJSON("name.last"), -buntdb.Desc(buntdb.IndexJSON("age"))) + buntdb.IndexJSON("name.last"), + buntdb.Desc(buntdb.IndexJSON("age")), +) ``` This will create a multi value index where the last name is ascending and the age is descending. diff --git a/vendor/github.com/tidwall/buntdb/buntdb.go b/vendor/github.com/tidwall/buntdb/buntdb.go index 6e612a7b..d0877448 100644 --- a/vendor/github.com/tidwall/buntdb/buntdb.go +++ b/vendor/github.com/tidwall/buntdb/buntdb.go @@ -69,6 +69,7 @@ type DB struct { keys *btree.BTree // a tree of all item ordered by key exps *btree.BTree // a tree of items ordered by expiration idxs map[string]*index // the index trees. + insIdxs []*index // a reuse buffer for gathering indexes flushes int // a count of the number of disk flushes closed bool // set when the database has been closed config Config // the database configuration @@ -139,8 +140,8 @@ type exctx struct { func Open(path string) (*DB, error) { db := &DB{} // initialize trees and indexes - db.keys = btree.New(lessCtx(nil)) - db.exps = btree.New(lessCtx(&exctx{db})) + db.keys = btreeNew(lessCtx(nil)) + db.exps = btreeNew(lessCtx(&exctx{db})) db.idxs = make(map[string]*index) // initialize default configuration db.config = Config{ @@ -283,7 +284,7 @@ func (idx *index) clearCopy() *index { } // initialize with empty trees if nidx.less != nil { - nidx.btr = btree.New(lessCtx(nidx)) + nidx.btr = btreeNew(lessCtx(nidx)) } if nidx.rect != nil { nidx.rtr = rtred.New(nidx) @@ -295,7 +296,7 @@ func (idx *index) clearCopy() *index { func (idx *index) rebuild() { // initialize trees if idx.less != nil { - idx.btr = btree.New(lessCtx(idx)) + idx.btr = btreeNew(lessCtx(idx)) } if idx.rect != nil { idx.rtr = rtred.New(idx) @@ -454,16 +455,23 @@ func (db *DB) SetConfig(config Config) error { // will be replaced with the new one, and return the previous item. func (db *DB) insertIntoDatabase(item *dbItem) *dbItem { var pdbi *dbItem + // Generate a list of indexes that this item will be inserted in to. + idxs := db.insIdxs + for _, idx := range db.idxs { + if idx.match(item.key) { + idxs = append(idxs, idx) + } + } prev := db.keys.Set(item) if prev != nil { // A previous item was removed from the keys tree. Let's // fully delete this item from all indexes. pdbi = prev.(*dbItem) if pdbi.opts != nil && pdbi.opts.ex { - // Remove it from the exipres tree. + // Remove it from the expires tree. db.exps.Delete(pdbi) } - for _, idx := range db.idxs { + for _, idx := range idxs { if idx.btr != nil { // Remove it from the btree index. idx.btr.Delete(pdbi) @@ -479,10 +487,7 @@ func (db *DB) insertIntoDatabase(item *dbItem) *dbItem { // expires tree db.exps.Set(item) } - for _, idx := range db.idxs { - if !idx.match(item.key) { - continue - } + for i, idx := range idxs { if idx.btr != nil { // Add new item to btree index. idx.btr.Set(item) @@ -491,7 +496,11 @@ func (db *DB) insertIntoDatabase(item *dbItem) *dbItem { // Add new item to rtree index. idx.rtr.Insert(item) } + // clear the index + idxs[i] = nil } + // reuse the index list slice + db.insIdxs = idxs[:0] // we must return the previous item to the caller. return pdbi } @@ -512,6 +521,9 @@ func (db *DB) deleteFromDatabase(item *dbItem) *dbItem { db.exps.Delete(pdbi) } for _, idx := range db.idxs { + if !idx.match(pdbi.key) { + continue + } if idx.btr != nil { // Remove it from the btree index. idx.btr.Delete(pdbi) @@ -908,8 +920,8 @@ func (db *DB) readLoad(rd io.Reader, modTime time.Time) (n int64, err error) { db.deleteFromDatabase(&dbItem{key: parts[1]}) } else if (parts[0][0] == 'f' || parts[0][0] == 'F') && strings.ToLower(parts[0]) == "flushdb" { - db.keys = btree.New(lessCtx(nil)) - db.exps = btree.New(lessCtx(&exctx{db})) + db.keys = btreeNew(lessCtx(nil)) + db.exps = btreeNew(lessCtx(&exctx{db})) db.idxs = make(map[string]*index) } else { return totalSize, ErrInvalid @@ -1054,8 +1066,8 @@ func (tx *Tx) DeleteAll() error { } // now reset the live database trees - tx.db.keys = btree.New(lessCtx(nil)) - tx.db.exps = btree.New(lessCtx(&exctx{tx.db})) + tx.db.keys = btreeNew(lessCtx(nil)) + tx.db.exps = btreeNew(lessCtx(&exctx{tx.db})) tx.db.idxs = make(map[string]*index) // finally re-create the indexes @@ -2300,3 +2312,8 @@ func btreeDescendLessOrEqual(tr *btree.BTree, pivot interface{}, ) { tr.Descend(pivot, iter) } + +func btreeNew(less func(a, b interface{}) bool) *btree.BTree { + // Using NewNonConcurrent because we're managing our own locks. + return btree.NewNonConcurrent(less) +} diff --git a/vendor/github.com/tidwall/buntdb/go.mod b/vendor/github.com/tidwall/buntdb/go.mod index cd77790c..171f550b 100644 --- a/vendor/github.com/tidwall/buntdb/go.mod +++ b/vendor/github.com/tidwall/buntdb/go.mod @@ -3,9 +3,9 @@ module github.com/tidwall/buntdb go 1.16 require ( - github.com/tidwall/btree v0.4.2 - github.com/tidwall/gjson v1.7.4 - github.com/tidwall/grect v0.1.1 + github.com/tidwall/btree v0.6.0 + github.com/tidwall/gjson v1.8.0 + github.com/tidwall/grect v0.1.2 github.com/tidwall/lotsa v1.0.2 github.com/tidwall/match v1.0.3 github.com/tidwall/rtred v0.1.2 diff --git a/vendor/github.com/tidwall/buntdb/go.sum b/vendor/github.com/tidwall/buntdb/go.sum index 8cf5f843..421bd3e9 100644 --- a/vendor/github.com/tidwall/buntdb/go.sum +++ b/vendor/github.com/tidwall/buntdb/go.sum @@ -1,9 +1,9 @@ -github.com/tidwall/btree v0.4.2 h1:aLwwJlG+InuFzdAPuBf9YCAR1LvSQ9zhC5aorFPlIPs= -github.com/tidwall/btree v0.4.2/go.mod h1:huei1BkDWJ3/sLXmO+bsCNELL+Bp2Kks9OLyQFkzvA8= -github.com/tidwall/gjson v1.7.4 h1:19cchw8FOxkG5mdLRkGf9jqIqEyqdZhPqW60XfyFxk8= -github.com/tidwall/gjson v1.7.4/go.mod h1:5/xDoumyyDNerp2U36lyolv46b3uF/9Bu6OfyQ9GImk= -github.com/tidwall/grect v0.1.1 h1:+kMEkxhoqB7rniVXzMEIA66XwU07STgINqxh+qVIndY= -github.com/tidwall/grect v0.1.1/go.mod h1:CzvbGiFbWUwiJ1JohXLb28McpyBsI00TK9Y6pDWLGRQ= +github.com/tidwall/btree v0.6.0 h1:JLYAFGV+1gjyFi3iQbO/fupBin+Ooh7dxqVV0twJ1Bo= +github.com/tidwall/btree v0.6.0/go.mod h1:TzIRzen6yHbibdSfK6t8QimqbUnoxUSrZfeW7Uob0q4= +github.com/tidwall/gjson v1.8.0 h1:Qt+orfosKn0rbNTZqHYDqBrmm3UDA4KRkv70fDzG+PQ= +github.com/tidwall/gjson v1.8.0/go.mod h1:5/xDoumyyDNerp2U36lyolv46b3uF/9Bu6OfyQ9GImk= +github.com/tidwall/grect v0.1.2 h1:wKVeQVZhjaFCKTTlpkDe3Ex4ko3cMGW3MRKawRe8uQ4= +github.com/tidwall/grect v0.1.2/go.mod h1:v+n4ewstPGduVJebcp5Eh2WXBJBumNzyhK8GZt4gHNw= github.com/tidwall/lotsa v1.0.2 h1:dNVBH5MErdaQ/xd9s769R31/n2dXavsQ0Yf4TMEHHw8= github.com/tidwall/lotsa v1.0.2/go.mod h1:X6NiU+4yHA3fE3Puvpnn1XMDrFZrE9JO2/w+UMuqgR8= github.com/tidwall/match v1.0.3 h1:FQUVvBImDutD8wJLN6c5eMzWtjgONK9MwIBCOrUJKeE= diff --git a/vendor/github.com/tidwall/gjson/README.md b/vendor/github.com/tidwall/gjson/README.md index 55620142..059570f9 100644 --- a/vendor/github.com/tidwall/gjson/README.md +++ b/vendor/github.com/tidwall/gjson/README.md @@ -14,8 +14,6 @@ It has features such as [one line retrieval](#get-a-value), [dot notation paths] Also check out [SJSON](https://github.com/tidwall/sjson) for modifying json, and the [JJ](https://github.com/tidwall/jj) command line tool. -For the Rust version go to [gjson.rs](https://github.com/tidwall/gjson.rs). - Getting Started =============== @@ -152,10 +150,6 @@ result.Less(token Result, caseSensitive bool) bool The `result.Value()` function returns an `interface{}` which requires type assertion and is one of the following Go types: -The `result.Array()` function returns back an array of values. -If the result represents a non-existent value, then an empty array will be returned. -If the result is not a JSON array, the return value will be an array containing one result. - ```go boolean >> bool number >> float64 @@ -165,6 +159,10 @@ array >> []interface{} object >> map[string]interface{} ``` +The `result.Array()` function returns back an array of values. +If the result represents a non-existent value, then an empty array will be returned. +If the result is not a JSON array, the return value will be an array containing one result. + ### 64-bit integers The `result.Int()` and `result.Uint()` calls are capable of reading all 64 bits, allowing for large JSON integers. diff --git a/vendor/github.com/tidwall/gjson/gjson.go b/vendor/github.com/tidwall/gjson/gjson.go index 7bb82e95..9687c0bb 100644 --- a/vendor/github.com/tidwall/gjson/gjson.go +++ b/vendor/github.com/tidwall/gjson/gjson.go @@ -714,10 +714,10 @@ type arrayPathResult struct { alogkey string query struct { on bool + all bool path string op string value string - all bool } } @@ -750,120 +750,27 @@ func parseArrayPath(path string) (r arrayPathResult) { } else if path[1] == '[' || path[1] == '(' { // query r.query.on = true - if true { - qpath, op, value, _, fi, ok := parseQuery(path[i:]) - if !ok { - // bad query, end now - break - } - r.query.path = qpath - r.query.op = op - r.query.value = value - i = fi - 1 - if i+1 < len(path) && path[i+1] == '#' { - r.query.all = true - } - } else { - var end byte - if path[1] == '[' { - end = ']' - } else { - end = ')' - } - i += 2 - // whitespace - for ; i < len(path); i++ { - if path[i] > ' ' { - break - } - } - s := i - for ; i < len(path); i++ { - if path[i] <= ' ' || - path[i] == '!' || - path[i] == '=' || - path[i] == '<' || - path[i] == '>' || - path[i] == '%' || - path[i] == end { - break - } - } - r.query.path = path[s:i] - // whitespace - for ; i < len(path); i++ { - if path[i] > ' ' { - break - } - } - if i < len(path) { - s = i - if path[i] == '!' { - if i < len(path)-1 && (path[i+1] == '=' || - path[i+1] == '%') { - i++ - } - } else if path[i] == '<' || path[i] == '>' { - if i < len(path)-1 && path[i+1] == '=' { - i++ - } - } else if path[i] == '=' { - if i < len(path)-1 && path[i+1] == '=' { - s++ - i++ - } - } - i++ - r.query.op = path[s:i] - // whitespace - for ; i < len(path); i++ { - if path[i] > ' ' { - break - } - } - s = i - for ; i < len(path); i++ { - if path[i] == '"' { - i++ - s2 := i - for ; i < len(path); i++ { - if path[i] > '\\' { - continue - } - if path[i] == '"' { - // look for an escaped slash - if path[i-1] == '\\' { - n := 0 - for j := i - 2; j > s2-1; j-- { - if path[j] != '\\' { - break - } - n++ - } - if n%2 == 0 { - continue - } - } - break - } - } - } else if path[i] == end { - if i+1 < len(path) && path[i+1] == '#' { - r.query.all = true - } - break - } - } - if i > len(path) { - i = len(path) - } - v := path[s:i] - for len(v) > 0 && v[len(v)-1] <= ' ' { - v = v[:len(v)-1] - } - r.query.value = v + qpath, op, value, _, fi, vesc, ok := + parseQuery(path[i:]) + if !ok { + // bad query, end now + break + } + if len(value) > 2 && value[0] == '"' && + value[len(value)-1] == '"' { + value = value[1 : len(value)-1] + if vesc { + value = unescape(value) } } + r.query.path = qpath + r.query.op = op + r.query.value = value + + i = fi - 1 + if i+1 < len(path) && path[i+1] == '#' { + r.query.all = true + } } } continue @@ -889,11 +796,11 @@ func parseArrayPath(path string) (r arrayPathResult) { // # middle // .cap # right func parseQuery(query string) ( - path, op, value, remain string, i int, ok bool, + path, op, value, remain string, i int, vesc, ok bool, ) { if len(query) < 2 || query[0] != '#' || (query[1] != '(' && query[1] != '[') { - return "", "", "", "", i, false + return "", "", "", "", i, false, false } i = 2 j := 0 // start of value part @@ -921,6 +828,7 @@ func parseQuery(query string) ( i++ for ; i < len(query); i++ { if query[i] == '\\' { + vesc = true i++ } else if query[i] == '"' { break @@ -929,7 +837,7 @@ func parseQuery(query string) ( } } if depth > 0 { - return "", "", "", "", i, false + return "", "", "", "", i, false, false } if j > 0 { path = trim(query[2:j]) @@ -966,7 +874,7 @@ func parseQuery(query string) ( path = trim(query[2:i]) remain = query[i+1:] } - return path, op, value, remain, i + 1, true + return path, op, value, remain, i + 1, vesc, true } func trim(s string) string { @@ -1266,8 +1174,14 @@ func parseObject(c *parseContext, i int, path string) (int, bool) { } func queryMatches(rp *arrayPathResult, value Result) bool { rpv := rp.query.value - if len(rpv) > 2 && rpv[0] == '"' && rpv[len(rpv)-1] == '"' { - rpv = rpv[1 : len(rpv)-1] + if len(rpv) > 0 && rpv[0] == '~' { + // convert to bool + rpv = rpv[1:] + if value.Bool() { + value = Result{Type: True} + } else { + value = Result{Type: False} + } } if !value.Exists() { return false diff --git a/vendor/github.com/tidwall/grect/go.mod b/vendor/github.com/tidwall/grect/go.mod index 9399750d..55dc4c0f 100644 --- a/vendor/github.com/tidwall/grect/go.mod +++ b/vendor/github.com/tidwall/grect/go.mod @@ -2,4 +2,4 @@ module github.com/tidwall/grect go 1.15 -require github.com/tidwall/gjson v1.7.4 +require github.com/tidwall/gjson v1.8.0 diff --git a/vendor/github.com/tidwall/grect/go.sum b/vendor/github.com/tidwall/grect/go.sum index 7dd8de53..72eee42e 100644 --- a/vendor/github.com/tidwall/grect/go.sum +++ b/vendor/github.com/tidwall/grect/go.sum @@ -1,5 +1,5 @@ -github.com/tidwall/gjson v1.7.4 h1:19cchw8FOxkG5mdLRkGf9jqIqEyqdZhPqW60XfyFxk8= -github.com/tidwall/gjson v1.7.4/go.mod h1:5/xDoumyyDNerp2U36lyolv46b3uF/9Bu6OfyQ9GImk= +github.com/tidwall/gjson v1.8.0 h1:Qt+orfosKn0rbNTZqHYDqBrmm3UDA4KRkv70fDzG+PQ= +github.com/tidwall/gjson v1.8.0/go.mod h1:5/xDoumyyDNerp2U36lyolv46b3uF/9Bu6OfyQ9GImk= github.com/tidwall/match v1.0.3 h1:FQUVvBImDutD8wJLN6c5eMzWtjgONK9MwIBCOrUJKeE= github.com/tidwall/match v1.0.3/go.mod h1:eRSPERbgtNPcGhD8UCthc6PmLEQXEWd3PRB5JTxsfmM= github.com/tidwall/pretty v1.1.0 h1:K3hMW5epkdAVwibsQEfR/7Zj0Qgt4DxtNumTq/VloO8= diff --git a/vendor/modules.txt b/vendor/modules.txt index a39c7f68..67147a46 100644 --- a/vendor/modules.txt +++ b/vendor/modules.txt @@ -162,10 +162,10 @@ github.com/rcrowley/go-metrics # github.com/streadway/amqp v1.0.0 ## explicit github.com/streadway/amqp -# github.com/tidwall/btree v0.5.0 +# github.com/tidwall/btree v0.6.0 ## explicit github.com/tidwall/btree -# github.com/tidwall/buntdb v1.2.3 +# github.com/tidwall/buntdb v1.2.5 ## explicit github.com/tidwall/buntdb # github.com/tidwall/cities v0.1.0 @@ -180,10 +180,10 @@ github.com/tidwall/geoindex/child github.com/tidwall/geojson github.com/tidwall/geojson/geo github.com/tidwall/geojson/geometry -# github.com/tidwall/gjson v1.7.4 +# github.com/tidwall/gjson v1.8.0 ## explicit github.com/tidwall/gjson -# github.com/tidwall/grect v0.1.1 +# github.com/tidwall/grect v0.1.2 github.com/tidwall/grect # github.com/tidwall/lotsa v1.0.2 github.com/tidwall/lotsa