Vladimir Mihailenco
60081bdd55
Merge pull request #2148 from signalfx/cluster-pipeline-err
...
fix: additional node failures in clustered pipelined reads
2022-07-28 13:27:22 +03:00
Vladimir Mihailenco
f99baf4fed
Merge pull request #2153 from kavu/fix/2126_ringshards_panic
...
fix: Handle panic in ringShards Hash function when Ring got closed
2022-07-28 13:25:06 +03:00
Vladimir Mihailenco
1492628ad0
Merge pull request #2157 from kavu/fix/ring_heartbeat_leak
...
fix: provide a signal channel to end heartbeat goroutine
2022-07-28 13:23:32 +03:00
Vladimir Mihailenco
6343311c4a
Merge pull request #2166 from go-redis/dependabot/go_modules/github.com/onsi/gomega-1.20.0
...
chore(deps): bump github.com/onsi/gomega from 1.19.0 to 1.20.0
2022-07-28 13:18:40 +03:00
dependabot[bot]
2be58234e3
chore(deps): bump github.com/onsi/gomega from 1.19.0 to 1.20.0
...
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega ) from 1.19.0 to 1.20.0.
- [Release notes](https://github.com/onsi/gomega/releases )
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md )
- [Commits](https://github.com/onsi/gomega/compare/v1.19.0...v1.20.0 )
---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-07-25 01:30:21 +00:00
Knut Zuidema
43d0cbb9b8
feat(extra/redisprometheus): prometheus.Collector implementation for redis clients
...
Signed-off-by: Knut Zuidema <me@knutzuidema.de>
2022-07-21 16:02:50 +02:00
Mikhail Mazurskiy
9e16c79951
fix: don't panic when test cannot start
2022-07-21 20:10:08 +10:00
Max Riveiro
20d0ca235e
fix: replace heartbeat signal channel with context.WithCancel
2022-07-20 12:20:03 +03:00
Max Riveiro
f032c126db
fix: provide a signal channel to end heartbeat goroutine
2022-07-14 22:58:53 +03:00
Knut Zuidema
e061db8c13
refactor: remove unused context attributes ( #2154 )
...
* refactor: remove unused context field
2022-07-14 13:43:42 +03:00
Max Riveiro
a80b84f01f
fix: handle panic in ringShards Hash function when Ring got closed
...
Fixes #2126
2022-07-13 18:09:42 +03:00
Knut Zuidema
092a692384
refactor: remove unused context attribute from conn ( #2150 )
2022-07-13 08:49:28 +03:00
Ben Keith
03376a5d9c
fix: additional node failures in clustered pipelined reads
...
This causes a node to be marked as failing if the client is in READONLY mode
and any error occurs that is either a LOADING error (existing behvaior) or
any non-redis error (e.g. connection error, timeout, etc.). This prevents that
node from being tried again on the next attempt as usually non-redis errors are
a strong indication that that node is not operational or degraded in some way.
2022-07-07 15:09:48 -04:00
Vladimir Mihailenco
9c34c5345f
Merge pull request #2146 from jsha/log-cmdsinfo-error
...
cluster: log errors from cmdsInfoCache
2022-07-07 09:04:24 +03:00
Jacob Hoffman-Andrews
fa4d1ea839
fix: log errors from cmdsInfoCache
...
Since the error gets swallowed in cmdInfo(), it's important to log it so
it's possible for the user to see what the error was.
2022-07-06 14:58:53 -07:00
Vladimir Mihailenco
9f5aacde23
Merge pull request #2137 from signalfx/latency-errs
...
Disregard failed Pings in updateLatency() for cluster nodes
2022-07-03 08:55:48 +03:00
Ben Keith
64f972fbea
fix: disregard failed pings in updateLatency() for cluster nodes
...
It is possible that a ping command might fail very quickly due to an
immediate connection refused message or some other server failure
condition. In this case, the derived latency is not reliable and should
not be used to compare this node to other nodes in the cluster.
This change will only count successful Ping commands in the average
latency and in the case of no successful Pings, set the latency to an
arbitrarily high value to make this node have the least priority when
routing by latency.
2022-07-01 11:04:26 -04:00
youseebiggirl
89d6dfe09a
fix: ignore Nil error when reading EntriesRead
2022-06-25 15:11:46 +03:00
Vladimir Mihailenco
a40b4f0f69
Merge pull request #2125 from go-redis/dependabot/github_actions/wagoid/commitlint-github-action-5
...
chore(deps): bump wagoid/commitlint-github-action from 4 to 5
2022-06-20 08:44:19 +03:00
dependabot[bot]
6e561bc5b9
chore(deps): bump wagoid/commitlint-github-action from 4 to 5
...
Bumps [wagoid/commitlint-github-action](https://github.com/wagoid/commitlint-github-action ) from 4 to 5.
- [Release notes](https://github.com/wagoid/commitlint-github-action/releases )
- [Changelog](https://github.com/wagoid/commitlint-github-action/blob/master/CHANGELOG.md )
- [Commits](https://github.com/wagoid/commitlint-github-action/compare/v4...v5 )
---
updated-dependencies:
- dependency-name: wagoid/commitlint-github-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-06-20 01:28:00 +00:00
Vladimir Mihailenco
25db55cdc0
Merge pull request #2119 from szyhf/szyhf-patch-1
...
fix : #2114 for redis-server not support Hello
2022-06-12 10:48:59 +03:00
Back Yu
b6d2a92529
fix : #2114 for redis-server not support Hello
...
Using `strings.HasPrefix` instead of `equal`
2022-06-10 21:19:02 +08:00
Vladimir Mihailenco
4ddd7d1803
chore: remove WithContext
2022-06-05 09:58:05 +03:00
Vladimir Mihailenco
0768a688c6
chore: update readme
2022-06-04 18:20:41 +03:00
Vladimir Mihailenco
53c26684c1
Merge pull request #2112 from go-redis/release/v9.0.0-beta.1
...
Release/v9.0.0 beta.1
2022-06-04 18:19:49 +03:00
Vladimir Mihailenco
58e087fe08
chore: release v9.0.0-beta.1 (release.sh)
2022-06-04 18:02:11 +03:00
Vladimir Mihailenco
98300d72b9
chore: cleanup
2022-06-04 18:00:44 +03:00
Vladimir Mihailenco
27f0addeb2
Merge pull request #2111 from go-redis/chore/v9
...
chore: v9
2022-06-04 17:58:40 +03:00
Vladimir Mihailenco
a18fad5bd3
chore: v9
2022-06-04 17:42:06 +03:00
Vladimir Mihailenco
a8e56a2961
Merge pull request #2110 from go-redis/feat/redis-7
...
feat: upgrade to Redis 7
2022-06-04 17:38:02 +03:00
Vladimir Mihailenco
d09c27e604
feat: upgrade to Redis 7
2022-06-04 17:25:12 +03:00
Vladimir Mihailenco
c98c5f0eeb
fix: update ChannelWithSubscriptions to accept options
2022-06-04 16:20:10 +03:00
Vladimir Mihailenco
f44b325a6d
Merge pull request #2109 from go-redis/fix/build
...
chore: fix build
2022-06-04 16:19:25 +03:00
Vladimir Mihailenco
b0bb514059
fix: update COMMAND parser for Redis 7
2022-06-04 16:07:28 +03:00
Vladimir Mihailenco
3a722be811
fix: fix tests
2022-06-04 15:25:01 +03:00
Vladimir Mihailenco
91171f5e19
feat: add ClientUnpause
2022-06-04 15:09:18 +03:00
Vladimir Mihailenco
a15a89ea58
chore: fix build
2022-06-04 14:52:46 +03:00
Vladimir Mihailenco
0aa94538ee
Merge branch 'v9'
2022-06-04 14:28:10 +03:00
renzheng.wang
52af8ba852
update cluster slots reply checking logic for Redis 7 ( #2108 )
...
fix: update cluster slots reply checking logic for redis 7
2022-06-04 13:24:32 +03:00
Vladimir Mihailenco
1980be0f9f
chore: fix golangci-lint
2022-06-04 10:50:58 +03:00
Vladimir Mihailenco
74fb9f0a8b
Merge pull request #2072 from go-redis/dependabot/github_actions/actions/setup-go-3
...
chore(deps): bump actions/setup-go from 2 to 3
2022-06-04 10:31:03 +03:00
janbar
56a3dbc7b6
feat: provide a username and password callback method, so that the plaintext username and password will not be stored in the memory, and the username and password will only be generated once when the CredentialsProvider is called. After the method is executed, the username and password strings on the stack will be released. ( #2097 )
...
Co-authored-by: janbar <janbar@163.com>
2022-06-04 10:26:04 +03:00
raynor
fca64a6a70
fix(baseClient): fix retryTimeout in _process, default value should be 0
2022-06-04 00:41:55 +08:00
Vladimir Mihailenco
2465baaab5
chore: move sponsors up
2022-05-03 17:50:48 +03:00
Vladimir Mihailenco
a4da15b8ad
chore: add sponsors
2022-05-03 17:48:11 +03:00
Bogus Jung
1fdcbf86bb
fix: test code
2022-04-28 20:32:58 +09:00
Bogus Jung
07e15d2876
fix: tags for structToMap "json" -> "key"
2022-04-28 20:32:20 +09:00
Vladimir Mihailenco
60d62a8a40
Merge pull request #2073 from go-redis/dependabot/github_actions/golangci/golangci-lint-action-3
...
chore(deps): bump golangci/golangci-lint-action from 2 to 3
2022-04-21 08:46:59 +03:00
neilnaveen
8ed3773467
chore: Set permissions for GitHub actions
...
Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.
- Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions
https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
[Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/ )
Signed-off-by: neilnaveen <42328488+neilnaveen@users.noreply.github.com>
2022-04-20 15:48:57 +00:00
Vladimir Mihailenco
4c8b4d1619
chore: mention kvrocks
2022-04-14 17:55:34 +03:00