Commit Graph

2368 Commits

Author SHA1 Message Date
Nelz bf8d4aa60c
feat(redisotel): ability to override TracerProvider (#1998) 2022-01-18 08:44:05 +02:00
nick comer 52276c393d feat: extract dialer to `DefaultDialer` to allow wrapping
Allowing the default dialing function to be wrapped allows for library
users to let the library continue to own the logic for dialing and let
users wrap the function for more observability.

My use case is to override `Options.Dialer` and add Jaeger tracing to
gain insight into the cost of new connections on a latency sensitive API.

```go
	defDialer := redis.DefaultDialer(opts)
	opts.Dialer = func(ctx context.Context, network, addr string) (net.Conn, error) {
		span, ctx := opentracing.StartSpanFromContext(ctx, "cache-repo-redis: new redis connection")
		defer span.Finish()

		return defDialer(ctx, network, addr)
	}
```

Without this, I end up needing to copy-paste the code from the internal
code, which is less-than-ideal since I don't want to own the maintenance
of this logic.
2022-01-14 16:01:09 -05:00
Vladimir Mihailenco f1dd3d5898
Merge pull request #1968 from Juneezee/go1.17
build: update `go` directive in `go.mod` to 1.17
2022-01-12 16:22:36 +02:00
gzjiangtao2014 f4bf09cfc8 chore: export cmder.SetFirstKeyPos to support build module commands 2022-01-11 14:47:55 +08:00
Vladimir Mihailenco 955df2c4c4 chore: update link 2021-12-29 10:45:45 +02:00
Eng Zer Jun 463389046e
build: update `go` directive in `go.mod` to 1.17
This commit enables support for module graph pruning and lazy module
loading for projects that are at Go 1.17 or higher.

Reference: https://go.dev/ref/mod#go-mod-file-go
Reference: https://go.dev/ref/mod#graph-pruning
Reference: https://go.dev/ref/mod#lazy-loading
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2021-12-27 08:31:17 +08:00
Vladimir Mihailenco 333fee1a8f fix: set timeout for WAIT command. Fixes #1963 2021-12-26 16:42:17 +02:00
Vladimir Mihailenco f737d9a830 chore: remove Discord 2021-12-24 15:33:36 +02:00
wjdqhry 4ce90461a5 fix: remove comment 2021-12-22 14:26:40 +09:00
wjdqhry bf334e7738 feat: enable struct on HSet 2021-12-17 11:54:43 +09:00
Vladimir Mihailenco e9a8bb4f86
Merge pull request #1954 from Ci-Jie/bugfix/tweak-some-feature-links
chore: tweak feature links
2021-11-25 12:10:11 +02:00
James3 Li(李麒傑) cc87acb6d6 chore: tweak feature links 2021-11-25 17:02:28 +08:00
Vladimir Mihailenco 5c9b845659 chore: add missing readme 2021-11-23 15:42:05 +02:00
Bastien Penavayre e19bbb26e2 feat: Add redis v7's NX, XX, GT, LT expire variants 2021-11-21 16:02:40 +02:00
Vladimir Mihailenco 5aefa73462
Merge pull request #1942 from go-redis/dependabot/go_modules/github.com/onsi/gomega-1.17.0
chore(deps): bump github.com/onsi/gomega from 1.16.0 to 1.17.0
2021-11-21 15:55:28 +02:00
Vladimir Mihailenco 10b3668010
Merge pull request #1940 from ffenix113/master
Update some argument counts in allocs.
2021-11-21 15:55:17 +02:00
dependabot[bot] 1790c2b9ab
chore(deps): bump github.com/onsi/gomega from 1.16.0 to 1.17.0
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.16.0 to 1.17.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/gomega/compare/v1.16.0...v1.17.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-20 15:54:43 +00:00
Vladimir Mihailenco dabd395d47
Merge pull request #1952 from go-redis/chore/del-keys-without-ttl
chore: add example how to delete keys without a ttl
2021-11-20 17:53:18 +02:00
Vladimir Mihailenco 383aa369b4 chore: don't enable all lints 2021-11-19 17:09:58 +02:00
Vladimir Mihailenco 9b48b5e45f chore: add example how to delete keys without a ttl 2021-11-19 17:05:07 +02:00
ffenix113 f6974ebb5c fix: update some argument counts in pre-allocs
In some cases number of pre-allocated places in
argument array is missing 1 or 2 elements,
which results in re-allocation of twice as large array
2021-11-05 19:13:47 +01:00
Vladimir Mihailenco 47ac23e055 Merge branch 'master' of github.com:go-redis/redis 2021-11-05 16:17:26 +02:00
Vladimir Mihailenco c7e913ce48 chore: update otel example 2021-11-05 16:17:17 +02:00
Vladimir Mihailenco 25378ca292
Merge pull request #1934 from kristinnardal2/redisotel-span-kind
fix(extra/redisotel): set span.kind attribute to client
2021-10-27 11:48:22 +03:00
Kristinn Björgvin Árdal 065b200070 fix(extra/redisotel): set span.kind attribute to client
According to the opentelemetry specification this should always be set to client for database client
libraries.

I've also removed the SetAttributes call and instead set the attributes during creation of the span.
This is what the library SHOULD be doing according to the opentelemetry api specification.
2021-10-27 10:28:48 +02:00
Vladimir Mihailenco 38d398f630 chore: fix linter 2021-10-24 09:55:27 +03:00
Vladimir Mihailenco a52a508bbf
Merge pull request #1930 from Pyrodash/master
feat: add support for time.Duration write and scan
2021-10-24 09:54:17 +03:00
Jackie a2a463b123 test: add test case for setting and scanning durations 2021-10-23 00:10:30 +02:00
Jackie 2f1b74e20c feat: add support for time.Duration write and scan 2021-10-21 18:37:17 +02:00
dependabot[bot] 0260525aa0
Bump github.com/onsi/ginkgo from 1.16.4 to 1.16.5 (#1925)
Bumps [github.com/onsi/ginkgo](https://github.com/onsi/ginkgo) from 1.16.4 to 1.16.5.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/ginkgo/compare/v1.16.4...v1.16.5)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-18 17:17:47 +08:00
Vladimir Mihailenco ca2b16333e
Merge pull request #1922 from HurSungYun/cmdInfo_logging_context
chore: use ctx parameter in cmdInfo
2021-10-15 12:13:27 +03:00
Ethan Hur a67d9129e6 chore: use ctx parameter in cmdInfo 2021-10-15 14:49:00 +09:00
Vladimir Mihailenco 2b6611c4fd Merge branch 'master' of github.com:go-redis/redis 2021-10-05 10:07:16 +03:00
Vladimir Mihailenco acf1c1831b chore: fix links 2021-10-05 10:07:08 +03:00
Vladimir Mihailenco 40c1cc3f31
Merge pull request #1918 from pfreixes/add_whitespace_before_addr
fix: add whitespace for avoid unlikely colisions
2021-10-05 08:55:04 +03:00
Pau Freixes 96f53a0159 fix: format 2021-10-04 17:22:18 +02:00
Pau Freixes 7f7c181761 fix: add whitespace for avoid unlikely colisions 2021-10-04 15:53:57 +02:00
Vladimir Mihailenco fa515240d4
Merge pull request #1917 from go-redis/release/v8.11.4
chore: release v8.11.4 (release.sh)
2021-10-04 16:40:48 +03:00
Vladimir Mihailenco 0457d0add6 chore: release v8.11.4 (release.sh) 2021-10-04 16:28:19 +03:00
Vladimir Mihailenco 6dcfc56151 chore: use conv commit message 2021-10-04 16:27:16 +03:00
Vladimir Mihailenco 86258a11a9 chore: lazy reload when moved or ask 2021-10-04 13:16:33 +03:00
Pau Freixes 98bb99ddc2
Fix Redis Cluster issue during roll outs of new nodes with same addr (#1914)
* fix: recycle connections in some Redis Cluster scenarios

This issue was surfaced in a Cloud Provider solution that used for
rolling out new nodes using the same address (hostname) of the nodes
that will be replaced in a Redis Cluster, while the former ones once
depromoted as Slaves would continue in service during some mintues
for redirecting traffic.

The solution basically identifies when the connection could be stale
since a MOVED response will be returned using the same address (hostname)
that is being used by the connection. At that moment we consider the
connection as no longer usable forcing to recycle the connection.
2021-10-04 13:10:42 +03:00
Vladimir Mihailenco 507203108a chore: add Lua scripting example 2021-09-27 17:29:41 +03:00
Vladimir Mihailenco 739c188212 chore: tweak GH actions to run all jobs 2021-09-27 12:08:34 +03:00
Vladimir Mihailenco cc09f96b8f
Merge pull request #1909 from go-redis/feature/slice-helpers
feat: add Cmd.{String,Int,Float,Bool}Slice helpers and an example
2021-09-27 11:46:25 +03:00
Vladimir Mihailenco 5d3d293cc9 feat: add Cmd.{String,Int,Float,Bool}Slice helpers and an example 2021-09-27 11:11:05 +03:00
Vladimir Mihailenco 329d87fc44
Merge pull request #1906 from Stavrospanakakis/master
feat: add SetVal method for each command
2021-09-26 09:16:44 +03:00
Stavros Panakakakis 168981da2d feat: add SetVal method for each command 2021-09-25 18:12:26 +03:00
Vladimir Mihailenco afd8445978 chore: update link 2021-09-24 17:10:01 +03:00
Vladimir Mihailenco e2ecabec44
Merge pull request #1904 from go-redis/fix/upd-dependencies
chore: update dependencies
2021-09-23 17:27:16 +03:00