mirror of https://github.com/go-redis/redis.git
add more trace details to dialer spans
This commit is contained in:
parent
2c0d528736
commit
ea78cc7d7e
|
@ -14,6 +14,8 @@ import (
|
||||||
|
|
||||||
"github.com/go-redis/redis/v8/internal"
|
"github.com/go-redis/redis/v8/internal"
|
||||||
"github.com/go-redis/redis/v8/internal/pool"
|
"github.com/go-redis/redis/v8/internal/pool"
|
||||||
|
"go.opentelemetry.io/otel/api/trace"
|
||||||
|
"go.opentelemetry.io/otel/label"
|
||||||
)
|
)
|
||||||
|
|
||||||
// Limiter is the interface of a rate limiter or a circuit breaker.
|
// Limiter is the interface of a rate limiter or a circuit breaker.
|
||||||
|
@ -243,7 +245,14 @@ func newConnPool(opt *Options) *pool.ConnPool {
|
||||||
var conn net.Conn
|
var conn net.Conn
|
||||||
err := internal.WithSpan(ctx, "dialer", func(ctx context.Context) error {
|
err := internal.WithSpan(ctx, "dialer", func(ctx context.Context) error {
|
||||||
var err error
|
var err error
|
||||||
|
trace.SpanFromContext(ctx).SetAttributes(
|
||||||
|
label.String("redis.network", opt.Network),
|
||||||
|
label.String("redis.addr", opt.Addr),
|
||||||
|
)
|
||||||
conn, err = opt.Dialer(ctx, opt.Network, opt.Addr)
|
conn, err = opt.Dialer(ctx, opt.Network, opt.Addr)
|
||||||
|
if err != nil {
|
||||||
|
internal.RecordError(ctx, err)
|
||||||
|
}
|
||||||
return err
|
return err
|
||||||
})
|
})
|
||||||
return conn, err
|
return conn, err
|
||||||
|
|
Loading…
Reference in New Issue