From df7fe4e2ce722a5ae9051795cf7448f7fc8d3011 Mon Sep 17 00:00:00 2001 From: Vladimir Mihailenco Date: Sat, 5 Sep 2020 17:39:26 +0300 Subject: [PATCH] Update changelog --- CHANGELOG.md | 18 ++++++++++-------- sentinel.go | 6 +++--- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8617ca78..30fd5864 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,15 +1,20 @@ # Changelog +> :heart: [**Uptrace.dev** - distributed traces, logs, and errors in one place](https://uptrace.dev) + ## v8 (unreleased) - All commands require `context.Context` as a first argument, e.g. `rdb.Ping(ctx)`. If you are not - using `context.Context` yet, the simplest option is to define package variable - `var ctx = context.TODO()` and use it when `ctx` is expected. -- Ring uses Rendezvous Hashing by default which provides better distribution. This means that - existing keys must be moved to a new location or key will be inaccessible / lost. To use old - hashing scheme: + using `context.Context` yet, the simplest option is to define global package variable + `var ctx = context.TODO()` and use it when `ctx` is required. - `Cluster.ForEachNode` is renamed to `ForEachShard` for consistency with `Ring`. +- Added `redisext.OpenTemetryHook` that adds + [Redis OpenTelemetry instrumentation](https://redis.uptrace.dev/tracing/). + +- Ring uses Rendezvous Hashing by default which provides better distribution. You need to move + existing keys to a new location or keys will be inaccessible / lost. To use old hashing scheme: + ```go import "github.com/golang/groupcache/consistenthash" @@ -20,9 +25,6 @@ ring := redis.NewRing(&redis.RingOptions{ }) ``` -- Added `redisext.OpenTemetryHook` that adds - [Redis OpenTelemetry instrumentation](https://redis.uptrace.dev/tracing/). - ## v7.3 - New option `Options.Username` which causes client to use `AuthACL`. Be aware if your connection diff --git a/sentinel.go b/sentinel.go index dd735dc9..41b142a0 100644 --- a/sentinel.go +++ b/sentinel.go @@ -26,6 +26,9 @@ type FailoverOptions struct { // Sentinel password from "requirepass " (if enabled) in Sentinel configuration SentinelPassword string + // Enables read-only commands on slave nodes. + ReadOnly bool + // Following options are copied from Options struct. Dialer func(ctx context.Context, network, addr string) (net.Conn, error) @@ -51,9 +54,6 @@ type FailoverOptions struct { IdleCheckFrequency time.Duration TLSConfig *tls.Config - - // Enables read-only commands on slave nodes. - ReadOnly bool } func (opt *FailoverOptions) options() *Options {