From 4d4a65774c300fe58993e4e284cee11158e68aef Mon Sep 17 00:00:00 2001 From: Adam Snyder Date: Thu, 9 Feb 2023 12:10:16 -0800 Subject: [PATCH] test: Disable tests for cancelled context --- commands_test.go | 6 ++++-- internal_test.go | 3 ++- pubsub_test.go | 3 ++- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/commands_test.go b/commands_test.go index 821d335a..57ec19e6 100644 --- a/commands_test.go +++ b/commands_test.go @@ -4843,7 +4843,8 @@ var _ = Describe("Commands", func() { Expect(err).To(Equal(redis.Nil)) }) - Describe("canceled context", func() { + // https://github.com/redis/go-redis/issues/2276 + PDescribe("canceled context", func() { It("should unblock XRead", func() { ctx2, cancel := context.WithCancel(ctx) errCh := make(chan error, 1) @@ -5042,7 +5043,8 @@ var _ = Describe("Commands", func() { Expect(n).To(Equal(int64(2))) }) - Describe("canceled context", func() { + // https://github.com/redis/go-redis/issues/2276 + PDescribe("canceled context", func() { It("should unblock XReadGroup", func() { ctx2, cancel := context.WithCancel(ctx) errCh := make(chan error, 1) diff --git a/internal_test.go b/internal_test.go index 494cb96e..90e802bc 100644 --- a/internal_test.go +++ b/internal_test.go @@ -352,7 +352,8 @@ var _ = Describe("withConn", func() { Expect(client.connPool.Len()).To(Equal(1)) }) - It("should remove the connection from the pool if the context is canceled", func() { + // https://github.com/redis/go-redis/issues/2276 + PIt("should remove the connection from the pool if the context is canceled", func() { var conn *pool.Conn ctx2, cancel := context.WithCancel(ctx) diff --git a/pubsub_test.go b/pubsub_test.go index 43b60f0a..f069a914 100644 --- a/pubsub_test.go +++ b/pubsub_test.go @@ -569,7 +569,8 @@ var _ = Describe("PubSub", func() { Expect(msg.Payload).To(Equal(text)) }) - Describe("canceled context", func() { + // https://github.com/redis/go-redis/issues/2276 + PDescribe("canceled context", func() { It("should unblock ReceiveMessage", func() { pubsub := client.Subscribe(ctx, "mychannel") defer pubsub.Close()