mirror
/
logrus
mirror of https://github.com/sirupsen/logrus.git
1
0
Fork 1
Code Issues Packages Projects Releases Wiki Activity

Only convert []bytes into a String() when needed for a panic, and not on other log levels

This commit is contained in:
Paul Querna 2014-09-23 17:05:07 -07:00
parent 89b6d460f0
commit f96066e3bf
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
entry.go
View File

@ -70,7 +70,7 @@ func (entry *Entry) WithFields(fields Fields) *Entry {
return &Entry{Logger: entry.Logger, Data: data} return &Entry{Logger: entry.Logger, Data: data}
} }
func (entry *Entry) log(level Level, msg string) string { func (entry *Entry) log(level Level, msg string) {
entry.Time = time.Now() entry.Time = time.Now()
entry.Level = level entry.Level = level
entry.Message = msg entry.Message = msg
@ -92,7 +92,9 @@ func (entry *Entry) log(level Level, msg string) string {
fmt.Fprintf(os.Stderr, "Failed to write to log, %v", err) fmt.Fprintf(os.Stderr, "Failed to write to log, %v", err)
} }
return reader.String() if level <= PanicLevel {
panic(reader.String())
}
} }
func (entry *Entry) Debug(args ...interface{}) { func (entry *Entry) Debug(args ...interface{}) {
@ -132,8 +134,7 @@ func (entry *Entry) Fatal(args ...interface{}) {
func (entry *Entry) Panic(args ...interface{}) { func (entry *Entry) Panic(args ...interface{}) {
if entry.Logger.Level >= PanicLevel { if entry.Logger.Level >= PanicLevel {
msg := entry.log(PanicLevel, fmt.Sprint(args...)) entry.log(PanicLevel, fmt.Sprint(args...))
panic(msg)
} }
panic(fmt.Sprint(args...)) panic(fmt.Sprint(args...))
} }