mirror
/
jwt
mirror of https://github.com/golang-jwt/jwt.git
1
0
Fork 1
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #47 from kofalt/master 

Fix timing side-channel attack in hmac comparison
This commit is contained in:
Dave Grijalva 2014-12-28 17:36:52 -08:00
parent d9679c1420 9a3c6fd1e3
commit 7b97402710
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hmac.go
View File

@ -1,7 +1,6 @@
package jwt package jwt
import ( import (
"bytes"
"crypto" "crypto"
"crypto/hmac" "crypto/hmac"
"errors" "errors"
@ -57,7 +56,7 @@ func (m *SigningMethodHMAC) Verify(signingString, signature string, key interfac
hasher := hmac.New(m.Hash.New, keyBytes) hasher := hmac.New(m.Hash.New, keyBytes)
hasher.Write([]byte(signingString)) hasher.Write([]byte(signingString))
if !bytes.Equal(sig, hasher.Sum(nil)) { if !hmac.Equal(sig, hasher.Sum(nil)) {
err = ErrSignatureInvalid err = ErrSignatureInvalid
} }
} }