From d66af581b4b6467b9f09a1eade855b29394d0150 Mon Sep 17 00:00:00 2001
From: Deviller <mailmaniak@gmail.com>
Date: Thu, 19 Nov 2020 14:24:34 +0300
Subject: [PATCH] Fix Association.Replace() error returning (#3766)

* Fix Association.Replace() error returning

* Fallback to gorm.Model at TestAssociationNotNullClear()
---
 association.go             |  4 ++--
 tests/associations_test.go | 36 ++++++++++++++++++++++++++++++++++++
 2 files changed, 38 insertions(+), 2 deletions(-)

diff --git a/association.go b/association.go
index 0f2102f7..7adb8c91 100644
--- a/association.go
+++ b/association.go
@@ -118,7 +118,7 @@ func (association *Association) Replace(values ...interface{}) error {
 
 			if _, pvs := schema.GetIdentityFieldValuesMap(reflectValue, primaryFields); len(pvs) > 0 {
 				column, values := schema.ToQueryValues(rel.FieldSchema.Table, foreignKeys, pvs)
-				tx.Where(clause.IN{Column: column, Values: values}).UpdateColumns(updateMap)
+				association.Error = tx.Where(clause.IN{Column: column, Values: values}).UpdateColumns(updateMap).Error
 			}
 		case schema.Many2Many:
 			var (
@@ -154,7 +154,7 @@ func (association *Association) Replace(values ...interface{}) error {
 				tx.Where(clause.Not(clause.IN{Column: relColumn, Values: relValues}))
 			}
 
-			tx.Delete(modelValue)
+			association.Error = tx.Delete(modelValue).Error
 		}
 	}
 	return association.Error
diff --git a/tests/associations_test.go b/tests/associations_test.go
index c1a4e2b2..f470338f 100644
--- a/tests/associations_test.go
+++ b/tests/associations_test.go
@@ -3,6 +3,7 @@ package tests_test
 import (
 	"testing"
 
+	"gorm.io/gorm"
 	. "gorm.io/gorm/utils/tests"
 )
 
@@ -32,6 +33,41 @@ func TestInvalidAssociation(t *testing.T) {
 	}
 }
 
+func TestAssociationNotNullClear(t *testing.T) {
+	type Profile struct {
+		gorm.Model
+		Number   string
+		MemberID uint `gorm:"not null"`
+	}
+
+	type Member struct {
+		gorm.Model
+		Profiles []Profile
+	}
+
+	DB.Migrator().DropTable(&Member{}, &Profile{})
+
+	if err := DB.AutoMigrate(&Member{}, &Profile{}); err != nil {
+		t.Fatalf("Failed to migrate, got error: %v", err)
+	}
+
+	member := &Member{
+		Profiles: []Profile{{
+			Number: "1",
+		}, {
+			Number: "2",
+		}},
+	}
+
+	if err := DB.Create(&member).Error; err != nil {
+		t.Fatalf("Failed to create test data, got error: %v", err)
+	}
+
+	if err := DB.Model(member).Association("Profiles").Clear(); err == nil {
+		t.Fatalf("No error occured during clearind not null association")
+	}
+}
+
 func TestForeignKeyConstraints(t *testing.T) {
 	type Profile struct {
 		ID       uint