mirror
/
gorm
mirror of https://github.com/go-gorm/gorm.git
1
0
Fork 1
Code Issues Packages Projects Releases Wiki Activity

Don't need NOT IN conditions when there are no primary keys found

This commit is contained in:
Jinzhu 2015-12-30 15:34:56 +08:00
parent 9a63fb28ba
commit 934e97b018
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
association.go
View File

@ -156,9 +156,11 @@ func (association *Association) Replace(values ...interface{}) *Association {
} }
newPrimaryKeys = association.getPrimaryKeys(associationForeignFieldNames, field.Interface()) newPrimaryKeys = association.getPrimaryKeys(associationForeignFieldNames, field.Interface())
if len(newPrimaryKeys) > 0 {
sql := fmt.Sprintf("%v NOT IN (%v)", toQueryCondition(scope, relationship.AssociationForeignDBNames), toQueryMarks(newPrimaryKeys)) sql := fmt.Sprintf("%v NOT IN (%v)", toQueryCondition(scope, relationship.AssociationForeignDBNames), toQueryMarks(newPrimaryKeys))
newDB = newDB.Where(sql, toQueryValues(newPrimaryKeys)...) newDB = newDB.Where(sql, toQueryValues(newPrimaryKeys)...)
} }
}
if relationship.Kind == "many_to_many" { if relationship.Kind == "many_to_many" {
association.setErr(relationship.JoinTableHandler.Delete(relationship.JoinTableHandler, newDB, relationship)) association.setErr(relationship.JoinTableHandler.Delete(relationship.JoinTableHandler, newDB, relationship))