Fix NamedArguments with nested struct, close #3596

clause/expression.go

@@ -91,16 +91,25 @@ func (expr NamedExpr) Build(builder Builder) {
 				namedMap[k] = v
 			}
 		default:
-			reflectValue := reflect.Indirect(reflect.ValueOf(value))
+			var appendFieldsToMap func(reflect.Value)
-			switch reflectValue.Kind() {
+			appendFieldsToMap = func(reflectValue reflect.Value) {
-			case reflect.Struct:
+				reflectValue = reflect.Indirect(reflectValue)
-				modelType := reflectValue.Type()
+				switch reflectValue.Kind() {
-				for i := 0; i < modelType.NumField(); i++ {
+				case reflect.Struct:
-					if fieldStruct := modelType.Field(i); ast.IsExported(fieldStruct.Name) {
+					modelType := reflectValue.Type()
-						namedMap[fieldStruct.Name] = reflectValue.Field(i).Interface()
+					for i := 0; i < modelType.NumField(); i++ {
+						if fieldStruct := modelType.Field(i); ast.IsExported(fieldStruct.Name) {
+							namedMap[fieldStruct.Name] = reflectValue.Field(i).Interface()
+
+							if fieldStruct.Anonymous {
+								appendFieldsToMap(reflectValue.Field(i))
+							}
+						}
 					}
 				}
 			}
+
+			appendFieldsToMap(reflect.ValueOf(value))
 		}
 	}
 

clause/expression_test.go

@@ -37,9 +37,13 @@ func TestExpr(t *testing.T) {
 }
 
 func TestNamedExpr(t *testing.T) {
+	type Base struct {
+		Name2 string
+	}
+
 	type NamedArgument struct {
 		Name1 string
-		Name2 string
+		Base
 	}
 
 	results := []struct {
@@ -73,7 +77,7 @@ func TestNamedExpr(t *testing.T) {
 		ExpectedVars: []interface{}{"jinzhu", "jinzhu2", "jinzhu", nil},
 	}, {
 		SQL:          "@@test AND name1 = @Name1 AND name2 = @Name2 AND name3 = @Name1 @Notexist",
-		Vars:         []interface{}{NamedArgument{Name1: "jinzhu", Name2: "jinzhu2"}},
+		Vars:         []interface{}{NamedArgument{Name1: "jinzhu", Base: Base{Name2: "jinzhu2"}}},
 		Result:       "@@test AND name1 = ? AND name2 = ? AND name3 = ? ?",
 		ExpectedVars: []interface{}{"jinzhu", "jinzhu2", "jinzhu", nil},
 	}, {