Commit Graph

353 Commits

Author SHA1 Message Date
cds 2a36f8cd42 Replace t.Error(); return statement pairs with single t.Fatal() 2012-09-11 10:13:11 -05:00
cds 40b65367c5 Added missing db.Close() and rows.Close() calls; fixes tests on vmhgfs filesystems.
Individual tests were never successfully removing 'foo.db' (the error was ignored), which caused everything but the first test to fail on my vmhgfs filesystem.  Adding the relevant defer db.Close() and rows.Close() calls fixed the leaks, enabling os.Remove() to work.
2012-09-11 09:23:21 -05:00
cds 54826d9585 Fix erroneous error message for sql.Open() 2012-09-11 08:41:45 -05:00
cds 3456489fa1 gofmt + fix erroneous t.Errorf("foo:", err) statements to t.Error("foo:", err) .
Original:
--- FAIL: TestInsert (0.00 seconds)
	sqlite3_test.go:42: Failed to create table:%!(EXTRA *errors.errorString=unable to open database file)

With corrections:
--- FAIL: TestInsert (0.00 seconds)
	sqlite3_test.go:42: Failed to create table: unable to open database file
2012-09-11 08:35:53 -05:00
mattn 3ae2f4307c Merge pull request #19 from leskets/master
bug fix: Byte slice results belong to the caller and so must be copies.
2012-08-21 09:23:37 -07:00
Thomas Leske a4e5e7a617 bug fix: Byte slices belong to the caller and so must be copies.
With the exeption of slices in the result type sql.RawBytes,
new calls to Sqlite must not corrupt slices.
2012-08-20 17:20:58 +02:00
mattn 8f1b649756 Merge pull request #18 from coolaj86/patch-1
MacPorts -> Homebrew
2012-08-06 17:00:48 -07:00
AJ ONeal 080d45fdc2 MacPorts -> Homebrew
Nobody should be using MacPorts anymore.
2012-08-06 17:24:53 -06:00
mattn f7f964e7ea Merge pull request #17 from amattn/master
update to README file
2012-07-09 01:10:01 -07:00
amattn 28bd73b5c3 Readme update 2012-07-08 16:45:22 -07:00
mattn a407c70cfd Merge pull request #15 from jander/master
Handle bool values with "BOOLEAN" columns.
2012-05-27 18:14:31 -07:00
jander d869678d3c Update sqlite3_test.go 2012-05-27 00:13:36 +08:00
jander 2f4a8f3f2c Update sqlite3_test.go 2012-05-27 00:10:29 +08:00
jander ed17eae07a fix TestBoolean 2012-05-27 00:09:12 +08:00
jander 1bfaa5b7d2 add bool type test: TestBoolean 2012-05-25 23:16:03 +08:00
jander 6865865265 Handle bool values with "BOOLEAN" columns. 2012-05-25 17:01:03 +08:00
mattn d9c069459a remove Makefile. 2012-05-15 20:49:45 +09:00
mattn 78a8e6baac remove Makefile. 2012-05-15 20:49:11 +09:00
mattn ea2c1e7a8c Merge pull request #12 from jgallagher/master
Minor tweaks, plus add support for "timestamp" columns.
2012-05-15 04:43:57 -07:00
John Gallagher db2c00ccd8 Increase busy timeout to 5 seconds.
500ms is short enough that go-sql-test sometimes fails with "database
locked", and it's the value used by Python's sqlite3 driver.
2012-04-07 00:37:02 -04:00
John Gallagher 3abc337b8e Handle time.Time values with "timestamp" columns. 2012-04-07 00:29:24 -04:00
John Gallagher e85c34cf5c Fix typo (Tailed -> Failed). 2012-04-06 22:46:11 -04:00
mattn 5691b2a3f4 add travis recepi. 2012-03-30 00:39:03 +09:00
mattn 08b7452f81 update. 2012-03-29 12:48:11 +09:00
mattn bba2094288 updated doc. 2012-03-29 12:46:32 +09:00
mattn 224815d665 merged #11
close #11
2012-03-12 14:20:55 +09:00
Sven Engelhardt 81a88cec73 database/sql expects io.EOF after all rows have been Next'ed
Return io.EOF, so rows.Next() will automatically call rows.Close()
after all results have been returned.
2012-03-02 09:06:56 +09:00
mattn fdc20cdbcb add example of Prepare()/QueryRow(). add db.Close(). close #7 2012-02-23 14:30:50 +09:00
mattn 8cbe65c9c3 merged bradfitz's patch. thanks. 2012-02-20 16:14:49 +09:00
mattn 93ab2db408 Merge pull request #6 from lye/master
Fix marshaling error in Go->SQLite boolean values
2012-02-06 20:19:51 -08:00
lye 3524ead0a5 For boolean values, marshal true to SQLite 1, not -1
SQLite stores boolean values as an integer, serializing true as 1 and
false as 0 [1], but it does not actually enforce this range. To match
the documentation (and fix the broken test case), this patch makes a Go
boolean true serialize properly to 1.

[1] http://www.sqlite.org/datatype3.html
2012-02-06 22:59:24 +00:00
lye 275bdb282a Added additional testcase for boolean roundtrips
This test creates a simple table, inserts some dummy boolean values,
then pulls them back out to ensure they are marshalled correctly.
2012-02-06 22:56:36 +00:00
mattn 7c18f62cf1 fixed package name. 2012-01-25 09:23:44 +09:00
mattn 78af0c22f5 Merge pull request #4 from bytbox/master
Update to build at tip (exp/sql -> database/sql)
2012-01-20 19:58:11 -08:00
Scott Lawrence 593643ef11 Updating README 2012-01-20 11:45:29 -05:00
Scott Lawrence c7906ff723 Updating example 2012-01-20 11:44:56 -05:00
Scott Lawrence f082596746 Fixing build at tip 2012-01-20 11:44:24 -05:00
Alien Science 5d9fdcab93 Fixed double free when closing SQLiteStmt
Rows should not close the statement because Stmt has its own close
function. This caused a double free error/crash on Fedora 16 x86_64.
2012-01-19 20:26:09 +01:00
mattn 9c4d0ce29a Merge pull request #2 from lye/master
Use pkg-config instead of a hardcoded LDFLAGS
2012-01-09 21:22:53 -08:00
lye 6a23a746e1 Use pkg-config instead of a hardcoded LDFLAGS 2012-01-10 00:16:34 +00:00
mattn f4359f417e gofix. 2011-12-07 20:40:45 +09:00
mattn 7d29362424 Merge pull request #1 from fiber/master
inserting zero-length strings failed.
2011-12-03 04:59:22 -08:00
mattn 48b031fa48 add README.mkd 2011-12-03 21:57:40 +09:00
Sven Engelhardt 01566134d1 allow to insert zero-length strings into database
&b[0] fails with an index out-of-bounds error for a slice with len()==0
2011-12-02 23:32:38 +01:00
mattn fdbb364aba fix LastInsertId()/RowsAffected(). 2011-11-15 11:03:31 +09:00
mattn e36e29f33e fix test. 2011-11-15 10:41:43 +09:00
mattn 7211b7212b last inserted row ID, affected rows. 2011-11-14 22:10:13 +09:00
mattn 650166a9cf clean 2011-11-14 10:09:46 +09:00
mattn 8c1b840c44 simple test. 2011-11-13 03:52:02 +09:00
mattn 41c5c95a6c transaction. 2011-11-13 03:20:52 +09:00