mirror
/
go-sqlite3
mirror of https://github.com/mattn/go-sqlite3.git
1
0
Fork 1
Code Issues Packages Projects Releases Wiki Activity

sqlite3: save an alloc during bind by using time.Time.AppendFormat 

This commit changes bind() to use time.Time.AppendFormat, which returns
a byte slice, instead of time.Time.Format, which returns a string that
must then be converted to a byte slice. This should save an allocation.
This commit is contained in:
Charlie Vieth 2023-04-20 22:58:40 -04:00
parent 3c0390b77c
commit 6c06c86425
No known key found for this signature in database
GPG Key ID: F6DBDE178E5DE3F0
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sqlite3.go
View File

@ -1977,7 +1977,8 @@ func (s *SQLiteStmt) bind(args []driver.NamedValue) error {
rv = C._sqlite3_bind_blob(s.s, n, unsafe.Pointer(&v[0]), C.int(ln)) rv = C._sqlite3_bind_blob(s.s, n, unsafe.Pointer(&v[0]), C.int(ln))
} }
case time.Time: case time.Time:
b := []byte(v.Format(SQLiteTimestampFormats[0])) b := make([]byte, 0, 35) // 35 == len(SQLiteTimestampFormats[0])
b = v.AppendFormat(b, SQLiteTimestampFormats[0])
rv = C._sqlite3_bind_text(s.s, n, (*C.char)(unsafe.Pointer(&b[0])), C.int(len(b))) rv = C._sqlite3_bind_text(s.s, n, (*C.char)(unsafe.Pointer(&b[0])), C.int(len(b)))
} }
if rv != C.SQLITE_OK { if rv != C.SQLITE_OK {