From 0486deea0daf3e1ba737b158c6f7ee7f2a74b7cb Mon Sep 17 00:00:00 2001 From: Attila Tajti Date: Mon, 26 Jan 2015 16:50:50 +0100 Subject: [PATCH] load extensions using the C API instead of SQL This fixes the problem of loading ICU, which needs to replace existing functions. Replacing existing functions are prohibited when a VM is running. --- sqlite3.go | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/sqlite3.go b/sqlite3.go index 4712f19..18ab545 100644 --- a/sqlite3.go +++ b/sqlite3.go @@ -287,21 +287,15 @@ func (d *SQLiteDriver) Open(dsn string) (driver.Conn, error) { return nil, errors.New(C.GoString(C.sqlite3_errmsg(db))) } - stmt, err := conn.Prepare("SELECT load_extension(?);") - if err != nil { - return nil, err - } - for _, extension := range d.Extensions { - if _, err = stmt.Exec([]driver.Value{extension}); err != nil { - return nil, err + cext := C.CString(extension) + defer C.free(unsafe.Pointer(cext)) + rv = C.sqlite3_load_extension(db, cext, nil, nil) + if rv != C.SQLITE_OK { + return nil, errors.New(C.GoString(C.sqlite3_errmsg(db))) } } - if err = stmt.Close(); err != nil { - return nil, err - } - rv = C.sqlite3_enable_load_extension(db, 0) if rv != C.SQLITE_OK { return nil, errors.New(C.GoString(C.sqlite3_errmsg(db)))