Merge pull request #130 from orisano/fix/decode-escaped-string-to-empty-interface

fix: fails decode escaped string to empty interface

decode_interface.go

@@ -275,23 +275,15 @@ func (d *interfaceDecoder) decodeEmptyInterface(buf []byte, cursor int64, p unsa
 			*(*interface{})(p) = v
 		}).decode(buf, cursor, p)
 	case '"':
-		cursor++
+		var v string
-		start := cursor
+		ptr := unsafe.Pointer(&v)
-		for {
+		dec := newStringDecoder(d.structName, d.fieldName)
-			switch buf[cursor] {
+		cursor, err := dec.decode(buf, cursor, ptr)
-			case '\\':
+		if err != nil {
-				cursor++
+			return 0, err
-				continue
+		}
-			case '"':
+		**(**interface{})(unsafe.Pointer(&p)) = v
-				literal := buf[start:cursor]
-				cursor++
-				**(**interface{})(unsafe.Pointer(&p)) = *(*string)(unsafe.Pointer(&literal))
 		return cursor, nil
-			case nul:
-				return 0, errUnexpectedEndOfJSON("string", cursor)
-			}
-			cursor++
-		}
 	case 't':
 		if cursor+3 >= int64(len(buf)) {
 			return 0, errUnexpectedEndOfJSON("bool(true)", cursor)

decode_test.go

@@ -197,6 +197,12 @@ func Test_Decoder(t *testing.T) {
 			assertEq(t, "interface.kind", "string", reflect.TypeOf(v).Kind().String())
 			assertEq(t, "interface", `hello`, fmt.Sprint(v))
 		})
+		t.Run("escaped string", func(t *testing.T) {
+			var v interface{}
+			assertErr(t, json.Unmarshal([]byte(`"he\"llo"`), &v))
+			assertEq(t, "interface.kind", "string", reflect.TypeOf(v).Kind().String())
+			assertEq(t, "interface", `he"llo`, fmt.Sprint(v))
+		})
 		t.Run("bool", func(t *testing.T) {
 			var v interface{}
 			assertErr(t, json.Unmarshal([]byte(`true`), &v))