From c2e744e1582818d85e319397e2f4a39f634cc262 Mon Sep 17 00:00:00 2001
From: Saksham Arya <arya.saksham@zomato.com>
Date: Wed, 20 Nov 2024 16:02:55 +0530
Subject: [PATCH 1/2] make headers thread safe

add reader lock
---
 context.go | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/context.go b/context.go
index c724daf3..f0f4d6cd 100644
--- a/context.go
+++ b/context.go
@@ -71,6 +71,9 @@ type Context struct {
 	// This mutex protects Keys map.
 	mu sync.RWMutex
 
+	// This mutex protects headers map
+	hmu sync.RWMutex
+
 	// Keys is a key/value pair exclusively for the context of each request.
 	Keys map[string]any
 
@@ -983,6 +986,8 @@ func (c *Context) Status(code int) {
 // It writes a header in the response.
 // If value == "", this method removes the header `c.Writer.Header().Del(key)`
 func (c *Context) Header(key, value string) {
+	c.hmu.Lock()
+	defer c.hmu.Unlock()
 	if value == "" {
 		c.Writer.Header().Del(key)
 		return
@@ -992,6 +997,8 @@ func (c *Context) Header(key, value string) {
 
 // GetHeader returns value from request headers.
 func (c *Context) GetHeader(key string) string {
+	c.hmu.RLock()
+	defer c.hmu.RUnlock()
 	return c.requestHeader(key)
 }
 

From cd86308ad15be29b05b191526ef7944e16e78bd5 Mon Sep 17 00:00:00 2001
From: Saksham Arya <arya.saksham@zomato.com>
Date: Wed, 20 Nov 2024 16:18:37 +0530
Subject: [PATCH 2/2] add test case

fix lint
---
 context_test.go | 24 ++++++++++++++++++++++--
 1 file changed, 22 insertions(+), 2 deletions(-)

diff --git a/context_test.go b/context_test.go
index 5b63a647..3d7818fb 100644
--- a/context_test.go
+++ b/context_test.go
@@ -166,7 +166,7 @@ func TestSaveUploadedFileWithPermission(t *testing.T) {
 	require.NoError(t, err)
 	mw.Close()
 	c, _ := CreateTestContext(httptest.NewRecorder())
-	c.Request, _ = http.NewRequest("POST", "/", buf)
+	c.Request, _ = http.NewRequest(http.MethodPost, "/", buf)
 	c.Request.Header.Set("Content-Type", mw.FormDataContentType())
 	f, err := c.FormFile("file")
 	require.NoError(t, err)
@@ -187,7 +187,7 @@ func TestSaveUploadedFileWithPermissionFailed(t *testing.T) {
 	require.NoError(t, err)
 	mw.Close()
 	c, _ := CreateTestContext(httptest.NewRecorder())
-	c.Request, _ = http.NewRequest("POST", "/", buf)
+	c.Request, _ = http.NewRequest(http.MethodPost, "/", buf)
 	c.Request.Header.Set("Content-Type", mw.FormDataContentType())
 	f, err := c.FormFile("file")
 	require.NoError(t, err)
@@ -3123,3 +3123,23 @@ func TestContextNext(t *testing.T) {
 	assert.True(t, exists)
 	assert.Equal(t, "value3", value)
 }
+
+func TestParallelHeaderWrite(t *testing.T) {
+	c, _ := CreateTestContext(httptest.NewRecorder())
+	wg := sync.WaitGroup{}
+	wg.Add(1)
+	go func() {
+		defer wg.Done()
+		for i := 0; i < 1000; i++ {
+			c.Header("key", "value")
+		}
+	}()
+	wg.Add(1)
+	go func() {
+		defer wg.Done()
+		for i := 0; i < 1000; i++ {
+			c.Header("key", "value")
+		}
+	}()
+	wg.Wait()
+}