From 8790d08909fc4d193c6c787c9c72f3089168f411 Mon Sep 17 00:00:00 2001
From: illiafox <61962654+illiafox@users.noreply.github.com>
Date: Thu, 21 Mar 2024 16:28:42 +0200
Subject: [PATCH] fix(uri): query binding bug (#3236)

* fix query mapping

* query binding test
---
 binding/query.go      |  4 ++--
 binding/query_test.go | 23 +++++++++++++++++++++++
 2 files changed, 25 insertions(+), 2 deletions(-)
 create mode 100644 binding/query_test.go

diff --git a/binding/query.go b/binding/query.go
index c958b88b..baa4aead 100644
--- a/binding/query.go
+++ b/binding/query.go
@@ -12,9 +12,9 @@ func (queryBinding) Name() string {
 	return "query"
 }
 
-func (queryBinding) Bind(req *http.Request, obj any) error {
+func (q queryBinding) Bind(req *http.Request, obj any) error {
 	values := req.URL.Query()
-	if err := mapForm(obj, values); err != nil {
+	if err := mapFormByTag(obj, values, q.Name()); err != nil {
 		return err
 	}
 	return validate(obj)
diff --git a/binding/query_test.go b/binding/query_test.go
new file mode 100644
index 00000000..72102040
--- /dev/null
+++ b/binding/query_test.go
@@ -0,0 +1,23 @@
+package binding
+
+import (
+	"net/http"
+	"net/url"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestQueryBinding(t *testing.T) {
+	var s struct {
+		Foo string `query:"foo"`
+	}
+
+	request := &http.Request{URL: &url.URL{RawQuery: "foo=BAR"}}
+
+	err := queryBinding{}.Bind(request, &s)
+	require.NoError(t, err)
+
+	assert.Equal(t, "BAR", s.Foo)
+}