mirror
/
gin
mirror of https://github.com/gin-gonic/gin.git
1
0
Fork 1
Code Issues Packages Projects Releases Wiki Activity

Only accepting 3xx status codes when redirecting. Swapped location and code arguments for Redirect signature

This commit is contained in:
Alexander Nyquist 2014-08-02 17:06:09 +02:00
parent e350ae7c7e
commit 64fb835e6f
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -302,7 +302,7 @@ func main() {
Issuing a HTTP redirect is easy: Issuing a HTTP redirect is easy:
```r.GET("/test", func(c *gin.Context) { ```r.GET("/test", func(c *gin.Context) {
c.Redirect("http://www.google.com/", 302) c.Redirect(301, "http://www.google.com/")
}) })
Both internal and external locations are supported. Both internal and external locations are supported.

6
context.go
View File

@ -248,8 +248,12 @@ func (c *Context) String(code int, format string, values ...interface{}) {
} }
// Returns a HTTP redirect to the specific location. // Returns a HTTP redirect to the specific location.
func (c *Context) Redirect(location string, code int) { func (c *Context) Redirect(code int, location string) {
if code >= 300 && code <= 308 {
c.Render(code, render.Redirect, location) c.Render(code, render.Redirect, location)
} else {
panic(fmt.Sprintf("Cannot send a redirect with status code %d", code))
}
} }
// Writes some data into the body stream and updates the HTTP code. // Writes some data into the body stream and updates the HTTP code.