From 1d0f938f28d7e592623264591605dc22ac141cc5 Mon Sep 17 00:00:00 2001
From: raymonder jin <rayjingithub@gmail.com>
Date: Fri, 25 Jun 2021 13:22:01 +0800
Subject: [PATCH] Fix insufficient slice check (#2755)

---
 tree.go      |  2 +-
 tree_test.go | 13 +++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/tree.go b/tree.go
index 5f35fff4..4b5656fb 100644
--- a/tree.go
+++ b/tree.go
@@ -459,7 +459,7 @@ walk: // Outer loop for walking the tree
 					}
 
 					// Save param value
-					if params != nil {
+					if params != nil && cap(*params) > 0 {
 						if value.params == nil {
 							value.params = params
 						}
diff --git a/tree_test.go b/tree_test.go
index 298c5ed0..7459317f 100644
--- a/tree_test.go
+++ b/tree_test.go
@@ -717,6 +717,19 @@ func TestTreeInvalidNodeType(t *testing.T) {
 	}
 }
 
+func TestTreeInvalidParamsType(t *testing.T) {
+	tree := &node{}
+	tree.wildChild = true
+	tree.children = append(tree.children, &node{})
+	tree.children[0].nType = 2
+
+	// set invalid Params type
+	params := make(Params, 0, 0)
+
+	// try to trigger slice bounds out of range with capacity 0
+	tree.getValue("/test", &params, false)
+}
+
 func TestTreeWildcardConflictEx(t *testing.T) {
 	conflicts := [...]struct {
 		route        string